From f5596901648966d8ec8dac4ef6438f9b2f9c4014 Mon Sep 17 00:00:00 2001
From: Kristian Hald <kristianhald@users.noreply.github.com>
Date: Sat, 14 Mar 2015 16:41:30 +0100
Subject: [PATCH] Updated the response classes so that they pass the convention
 tests and code analysis.

---
 Octokit/Models/Response/RepositoryHook.cs     | 38 +++++++++++++------
 .../Response/RepositoryHookConfiguration.cs   | 11 +++++-
 Octokit/Octokit-Mono.csproj                   |  1 +
 Octokit/Octokit-MonoAndroid.csproj            |  5 ++-
 Octokit/Octokit-Monotouch.csproj              |  3 +-
 Octokit/Octokit-Portable.csproj               |  2 +-
 Octokit/Octokit.csproj                        |  1 +
 7 files changed, 44 insertions(+), 17 deletions(-)

diff --git a/Octokit/Models/Response/RepositoryHook.cs b/Octokit/Models/Response/RepositoryHook.cs
index 92e22fdc..93d9af51 100644
--- a/Octokit/Models/Response/RepositoryHook.cs
+++ b/Octokit/Models/Response/RepositoryHook.cs
@@ -2,23 +2,39 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Globalization;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Octokit
 {
     [DebuggerDisplay("{DebuggerDisplay,nq}")]
     public class RepositoryHook
     {
-        public string Url { get; set; }
-        public DateTimeOffset CreatedAt { get; set; }
-        public DateTimeOffset UpdatedAt { get; set; }
-        public string Name { get; set; }
-        public IEnumerable<string> Events { get; set; }
-        public bool Active { get; set; }
-        public dynamic Config { get; set; }
-        public int Id { get; set; }
+        public RepositoryHook(int id, string url, DateTimeOffset createdAt, DateTimeOffset updatedAt, string name, IEnumerable<string> events, bool active, RepositoryHookConfiguration config)
+        {
+            Url = url;
+            CreatedAt = createdAt;
+            UpdatedAt = updatedAt;
+            Name = name;
+            Events = events;
+            Active = active;
+            Config = config;
+            Id = id;
+        }
+
+        public int Id { get; private set; }
+
+        public string Url { get; private set; }
+
+        public DateTimeOffset CreatedAt { get; private set; }
+
+        public DateTimeOffset UpdatedAt { get; private set; }
+
+        public string Name { get; private set; }
+
+        public IEnumerable<string> Events { get; private set; }
+
+        public bool Active { get; private set; }
+
+        public RepositoryHookConfiguration Config { get; private set; }
 
         internal string DebuggerDisplay
         {
diff --git a/Octokit/Models/Response/RepositoryHookConfiguration.cs b/Octokit/Models/Response/RepositoryHookConfiguration.cs
index 603967f2..b8cbd203 100644
--- a/Octokit/Models/Response/RepositoryHookConfiguration.cs
+++ b/Octokit/Models/Response/RepositoryHookConfiguration.cs
@@ -7,8 +7,15 @@ namespace Octokit
     [DebuggerDisplay("{DebuggerDisplay,nq}")]
     public class RepositoryHookConfiguration
     {
-        public string Url { get; set; }
-        public string ContentType { get; set; }
+        public RepositoryHookConfiguration(string contentType, string url)
+        {
+            ContentType = contentType;
+            Url = url;
+        }
+
+        public string Url { get; private set; }
+
+        public string ContentType { get; private set; }
 
         internal string DebuggerDisplay
         {
diff --git a/Octokit/Octokit-Mono.csproj b/Octokit/Octokit-Mono.csproj
index a61b2202..1d9a131f 100644
--- a/Octokit/Octokit-Mono.csproj
+++ b/Octokit/Octokit-Mono.csproj
@@ -387,6 +387,7 @@
     <Compile Include="Models\Response\PublicKey.cs" />
     <Compile Include="Models\Request\ReleaseAssetUpload.cs" />
     <Compile Include="Models\Request\RepositoryRequest.cs" />
+    <Compile Include="Models\Response\RepositoryHookConfiguration.cs" />
   </ItemGroup>
   <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
 </Project>
\ No newline at end of file
diff --git a/Octokit/Octokit-MonoAndroid.csproj b/Octokit/Octokit-MonoAndroid.csproj
index eddacf68..ab7d8ffb 100644
--- a/Octokit/Octokit-MonoAndroid.csproj
+++ b/Octokit/Octokit-MonoAndroid.csproj
@@ -102,7 +102,7 @@
     <Compile Include="Models\Request\RequestParameters.cs" />
     <Compile Include="Models\Response\Commit.cs" />
     <Compile Include="Models\Response\Activity.cs" />
-	<Compile Include="Models\Response\ActivityPayloads\ActivityPayload.cs" />
+    <Compile Include="Models\Response\ActivityPayloads\ActivityPayload.cs" />
     <Compile Include="Models\Response\ActivityPayloads\CommitCommentPayload.cs" />
     <Compile Include="Models\Response\ActivityPayloads\ForkEventPayload.cs" />
     <Compile Include="Models\Response\ActivityPayloads\IssueCommentPayload.cs" />
@@ -399,6 +399,7 @@
     <Compile Include="Models\Response\AccountType.cs" />
     <Compile Include="Models\Request\ReleaseAssetUpload.cs" />
     <Compile Include="Models\Request\RepositoryRequest.cs" />
+    <Compile Include="Models\Response\RepositoryHookConfiguration.cs" />
   </ItemGroup>
   <Import Project="$(MSBuildExtensionsPath)\Novell\Novell.MonoDroid.CSharp.targets" />
-</Project>
+</Project>
\ No newline at end of file
diff --git a/Octokit/Octokit-Monotouch.csproj b/Octokit/Octokit-Monotouch.csproj
index 8266661c..64be446f 100644
--- a/Octokit/Octokit-Monotouch.csproj
+++ b/Octokit/Octokit-Monotouch.csproj
@@ -99,7 +99,7 @@
     <Compile Include="Models\Request\RequestParameters.cs" />
     <Compile Include="Models\Response\Commit.cs" />
     <Compile Include="Models\Response\Activity.cs" />
-	<Compile Include="Models\Response\ActivityPayloads\ActivityPayload.cs" />
+    <Compile Include="Models\Response\ActivityPayloads\ActivityPayload.cs" />
     <Compile Include="Models\Response\ActivityPayloads\CommitCommentPayload.cs" />
     <Compile Include="Models\Response\ActivityPayloads\ForkEventPayload.cs" />
     <Compile Include="Models\Response\ActivityPayloads\IssueCommentPayload.cs" />
@@ -392,6 +392,7 @@
     <Compile Include="Models\Response\AccountType.cs" />
     <Compile Include="Models\Request\ReleaseAssetUpload.cs" />
     <Compile Include="Models\Request\RepositoryRequest.cs" />
+    <Compile Include="Models\Response\RepositoryHookConfiguration.cs" />
   </ItemGroup>
   <Import Project="$(MSBuildExtensionsPath)\Xamarin\iOS\Xamarin.MonoTouch.CSharp.targets" />
   <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
diff --git a/Octokit/Octokit-Portable.csproj b/Octokit/Octokit-Portable.csproj
index f8c1579d..458a24c2 100644
--- a/Octokit/Octokit-Portable.csproj
+++ b/Octokit/Octokit-Portable.csproj
@@ -269,7 +269,6 @@
     <Compile Include="Models\Response\ReleaseAsset.cs" />
     <Compile Include="Models\Response\Repository.cs" />
     <Compile Include="Models\Response\RepositoryHook.cs" />
-    <Compile Include="Models\Response\RepositoryHookConfiguration.cs" />
     <Compile Include="Models\Response\SearchRepositoryResult.cs" />
     <Compile Include="Models\Response\SshKey.cs" />
     <Compile Include="Models\Response\SshKeyInfo.cs" />
@@ -386,6 +385,7 @@
     <Compile Include="Models\Request\GistFileUpdate.cs" />
     <Compile Include="Models\Request\ReleaseAssetUpload.cs" />
     <Compile Include="Models\Request\RepositoryRequest.cs" />
+    <Compile Include="Models\Response\RepositoryHookConfiguration.cs" />
   </ItemGroup>
   <ItemGroup>
     <CodeAnalysisDictionary Include="..\CustomDictionary.xml">
diff --git a/Octokit/Octokit.csproj b/Octokit/Octokit.csproj
index 577b7094..f05330f8 100644
--- a/Octokit/Octokit.csproj
+++ b/Octokit/Octokit.csproj
@@ -112,6 +112,7 @@
     <Compile Include="Models\Response\RepositoryContent.cs" />
     <Compile Include="Models\Response\RepositoryContentChangeSet.cs" />
     <Compile Include="Models\Response\RepositoryContributor.cs" />
+    <Compile Include="Models\Response\RepositoryHookConfiguration.cs" />
     <Compile Include="Models\Response\RepositoryPermissions.cs" />
     <Compile Include="Models\Request\NewThreadSubscription.cs" />
     <Compile Include="Models\Response\DeployKey.cs" />