diff --git a/Octokit/ApiExtensions.cs b/Octokit/ApiExtensions.cs index eb3d2d97..e1eaca68 100644 --- a/Octokit/ApiExtensions.cs +++ b/Octokit/ApiExtensions.cs @@ -8,44 +8,44 @@ namespace Octokit { public static class ApiExtensions { - public static Task Get(this IApiConnection connection, Uri endpoint) + public static Task Get(this IApiConnection connection, Uri uri) { Ensure.ArgumentNotNull(connection, "connection"); - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); - return connection.Get(endpoint, null); + return connection.Get(uri, null); } - public static Task> GetAll(this IApiConnection connection, Uri endpoint) + public static Task> GetAll(this IApiConnection connection, Uri uri) { Ensure.ArgumentNotNull(connection, "connection"); - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); - return connection.GetAll(endpoint, null); + return connection.GetAll(uri, null); } - public static Task GetHtml(this IApiConnection connection, Uri endpoint) + public static Task GetHtml(this IApiConnection connection, Uri uri) { Ensure.ArgumentNotNull(connection, "connection"); - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); - return connection.GetHtml(endpoint, null); + return connection.GetHtml(uri, null); } - public static Task> GetHtml(this IConnection connection, Uri endpoint) + public static Task> GetHtml(this IConnection connection, Uri uri) { Ensure.ArgumentNotNull(connection, "connection"); - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); - return connection.GetHtml(endpoint, null); + return connection.GetHtml(uri, null); } - public static async Task> GetAsync(this IConnection connection, Uri endpoint) + public static async Task> GetAsync(this IConnection connection, Uri uri) { Ensure.ArgumentNotNull(connection, "connection"); - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); - return await connection.GetAsync(endpoint, null); + return await connection.GetAsync(uri, null); } } } diff --git a/Octokit/Http/ApiConnection.cs b/Octokit/Http/ApiConnection.cs index e288dc9b..492bcef5 100644 --- a/Octokit/Http/ApiConnection.cs +++ b/Octokit/Http/ApiConnection.cs @@ -128,9 +128,18 @@ namespace Octokit return await Post(uri, data, null, null); } - public async Task Post(Uri endpoint, object data, string contentType) + /// + /// Creates a new API resource in the list at the specified URI. + /// + /// The API resource's type. + /// URI of the API resource to get. + /// Object that describes the new API resource; this will be serialized and used as the request's body. + /// Content type of the API request. + /// The created API resource. + /// Thrown when an API error occurs. + public async Task Post(Uri uri, object data, string contentType) { - return await Post(endpoint, data, contentType, null); + return await Post(uri, data, contentType, null); } /// @@ -185,7 +194,7 @@ namespace Octokit /// Thrown when an API error occurs. public async Task Put(Uri uri, object data, string twoFactorAuthenticationCode) { - Ensure.ArgumentNotNull(uri, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); Ensure.ArgumentNotNull(data, "data"); Ensure.ArgumentNotNullOrEmptyString(twoFactorAuthenticationCode, "twoFactorAuthenticationCode"); @@ -204,7 +213,7 @@ namespace Octokit /// Thrown when an API error occurs. public async Task Patch(Uri uri, object data) { - Ensure.ArgumentNotNull(uri, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); Ensure.ArgumentNotNull(data, "data"); var response = await Connection.PatchAsync(uri, data); @@ -225,13 +234,13 @@ namespace Octokit } async Task> GetPage( - Uri endpoint, + Uri uri, IDictionary parameters, string accepts) { - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); - var response = await Connection.GetAsync>(endpoint, parameters, accepts); + var response = await Connection.GetAsync>(uri, parameters, accepts); return new ReadOnlyPagedCollection(response, Connection); } } diff --git a/Octokit/Http/Connection.cs b/Octokit/Http/Connection.cs index c676d2f9..c94dd280 100644 --- a/Octokit/Http/Connection.cs +++ b/Octokit/Http/Connection.cs @@ -70,69 +70,69 @@ namespace Octokit _apiInfoParser = new ApiInfoParser(); } - public async Task> GetAsync(Uri endpoint, IDictionary parameters) + public async Task> GetAsync(Uri uri, IDictionary parameters) { - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); - return await GetAsync(endpoint, parameters, null); + return await GetAsync(uri, parameters, null); } - public async Task> GetAsync(Uri endpoint, IDictionary parameters, string accepts) + public async Task> GetAsync(Uri uri, IDictionary parameters, string accepts) { - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); - return await SendData(endpoint.ApplyParameters(parameters), HttpMethod.Get, null, accepts: accepts); + return await SendData(uri.ApplyParameters(parameters), HttpMethod.Get, null, accepts: accepts); } - public async Task> GetHtml(Uri endpoint, IDictionary parameters) + public async Task> GetHtml(Uri uri, IDictionary parameters) { - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); return await GetHtml(new Request { Method = HttpMethod.Get, BaseAddress = BaseAddress, - Endpoint = endpoint.ApplyParameters(parameters) + Endpoint = uri.ApplyParameters(parameters) }); } - public async Task> PatchAsync(Uri endpoint, object body) + public async Task> PatchAsync(Uri uri, object body) { - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); Ensure.ArgumentNotNull(body, "body"); - return await SendData(endpoint, HttpVerb.Patch, body); + return await SendData(uri, HttpVerb.Patch, body); } - public async Task> PostAsync(Uri endpoint, object body) + public async Task> PostAsync(Uri uri, object body) { - return await SendData(endpoint, HttpMethod.Post, body); + return await SendData(uri, HttpMethod.Post, body); } - public async Task> PostAsync(Uri endpoint, object body, string contentType, string accepts) + public async Task> PostAsync(Uri uri, object body, string contentType, string accepts) { - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); Ensure.ArgumentNotNull(body, "body"); - return await SendData(endpoint, HttpMethod.Post, body, contentType, accepts); + return await SendData(uri, HttpMethod.Post, body, contentType, accepts); } - public async Task> PutAsync(Uri endpoint, object body) + public async Task> PutAsync(Uri uri, object body) { - return await SendData(endpoint, HttpMethod.Put, body); + return await SendData(uri, HttpMethod.Put, body); } - public async Task> PutAsync(Uri endpoint, object body, string twoFactorAuthenticationCode) + public async Task> PutAsync(Uri uri, object body, string twoFactorAuthenticationCode) { - return await SendData(endpoint, + return await SendData(uri, HttpMethod.Put, body, twoFactorAuthenticationCode: twoFactorAuthenticationCode); } async Task> SendData( - Uri endpoint, + Uri uri, HttpMethod method, object body, string contentType = "application/x-www-form-urlencoded", // Per: http://developer.github.com/v3/ @@ -140,13 +140,13 @@ namespace Octokit string twoFactorAuthenticationCode = null ) { - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); var request = new Request { Method = method, BaseAddress = BaseAddress, - Endpoint = endpoint, + Endpoint = uri, }; if (!String.IsNullOrEmpty(accepts)) @@ -168,15 +168,15 @@ namespace Octokit return await Run(request); } - public async Task DeleteAsync(Uri endpoint) + public async Task DeleteAsync(Uri uri) { - Ensure.ArgumentNotNull(endpoint, "endpoint"); + Ensure.ArgumentNotNull(uri, "uri"); await Run(new Request { Method = HttpMethod.Delete, BaseAddress = BaseAddress, - Endpoint = endpoint + Endpoint = uri }); } diff --git a/Octokit/Http/IConnection.cs b/Octokit/Http/IConnection.cs index 895be40d..c3e94f7c 100644 --- a/Octokit/Http/IConnection.cs +++ b/Octokit/Http/IConnection.cs @@ -6,16 +6,16 @@ namespace Octokit { public interface IConnection { - Task> GetHtml(Uri endpoint, IDictionary parameters); - Task> GetAsync(Uri endpoint, IDictionary parameters); - Task> GetAsync(Uri endpoint, IDictionary parameters, string accepts); - Task> PatchAsync(Uri endpoint, object body); - Task> PostAsync(Uri endpoint, object body); - Task> PostAsync(Uri endpoint, object body, string contentType, string accepts); - Task> PutAsync(Uri endpoint, object body); - Task> PutAsync(Uri endpoint, object body, string twoFactorAuthenticationCode); + Task> GetHtml(Uri uri, IDictionary parameters); + Task> GetAsync(Uri uri, IDictionary parameters); + Task> GetAsync(Uri uri, IDictionary parameters, string accepts); + Task> PatchAsync(Uri uri, object body); + Task> PostAsync(Uri uri, object body); + Task> PostAsync(Uri uri, object body, string contentType, string accepts); + Task> PutAsync(Uri uri, object body); + Task> PutAsync(Uri uri, object body, string twoFactorAuthenticationCode); - Task DeleteAsync(Uri endpoint); + Task DeleteAsync(Uri uri); Uri BaseAddress { get; }