From fc3e9c2cd28f91bbedd15a1f9b02945501441427 Mon Sep 17 00:00:00 2001
From: Jozef Izso <jozef.izso@gmail.com>
Date: Thu, 17 May 2018 13:48:45 +0200
Subject: [PATCH] Implement improved labels API (#1802)

* Implement new attributes for labels

* Include correct API header in all Labels calls

* Add integration tests for Create and Update methods for labels

* Use improved labels API in observable client

* found even more endpoints that need the preview header!

* RemoveFromIssue actually returns the list of remaining labels rather than null.  This change should be source compatible but not binary compatible

* Implement new labels search method in SearchClient

* Implement reactive client SearchLabels

* Improve documentation for label search methods

* more comment tidy up
---
 .../Clients/IObservableIssuesLabelsClient.cs  |   4 +-
 .../Clients/IObservableSearchClient.cs        |   8 ++
 .../Clients/ObservableIssuesLabelsClient.cs   |  24 ++--
 .../Clients/ObservableSearchClient.cs         |  12 ++
 .../Clients/IssuesLabelsClientTests.cs        |  48 ++++++++
 .../Clients/SearchClientTests.cs              |  10 ++
 .../Clients/IssuesLabelsClientTests.cs        |  48 ++++----
 Octokit.Tests/Clients/SearchClientTests.cs    | 106 ++++++++++++++++++
 .../ObservableIssuesLabelsClientTests.cs      |  28 ++---
 Octokit/Clients/IIssuesLabelsClient.cs        |   4 +-
 Octokit/Clients/ISearchClient.cs              |   8 ++
 Octokit/Clients/IssuesLabelsClient.cs         |  40 +++----
 Octokit/Clients/SearchClient.cs               |  12 ++
 Octokit/Helpers/AcceptHeaders.cs              |   2 +
 Octokit/Helpers/ApiUrls.cs                    |   9 ++
 Octokit/Models/Request/BaseSearchRequest.cs   |  17 ++-
 Octokit/Models/Request/LabelUpdate.cs         |   5 +
 Octokit/Models/Request/NewLabel.cs            |  12 ++
 Octokit/Models/Request/SearchLabelsRequest.cs |  82 ++++++++++++++
 Octokit/Models/Response/Label.cs              |  14 ++-
 Octokit/Models/Response/SearchLabelsResult.cs |  17 +++
 21 files changed, 436 insertions(+), 74 deletions(-)
 create mode 100644 Octokit/Models/Request/SearchLabelsRequest.cs
 create mode 100644 Octokit/Models/Response/SearchLabelsResult.cs

diff --git a/Octokit.Reactive/Clients/IObservableIssuesLabelsClient.cs b/Octokit.Reactive/Clients/IObservableIssuesLabelsClient.cs
index 4fe6f11d..aa84153e 100644
--- a/Octokit.Reactive/Clients/IObservableIssuesLabelsClient.cs
+++ b/Octokit.Reactive/Clients/IObservableIssuesLabelsClient.cs
@@ -263,7 +263,7 @@ namespace Octokit.Reactive
         /// <param name="name">The name of the repository</param>
         /// <param name="number">The number of the issue</param>
         /// <param name="labelName">The name of the label to remove</param>
-        IObservable<Unit> RemoveFromIssue(string owner, string name, int number, string labelName);
+        IObservable<Label> RemoveFromIssue(string owner, string name, int number, string labelName);
 
         /// <summary>
         /// Removes a label from an issue
@@ -274,7 +274,7 @@ namespace Octokit.Reactive
         /// <param name="repositoryId">The Id of the repository</param>
         /// <param name="number">The number of the issue</param>
         /// <param name="labelName">The name of the label to remove</param>
-        IObservable<Unit> RemoveFromIssue(long repositoryId, int number, string labelName);
+        IObservable<Label> RemoveFromIssue(long repositoryId, int number, string labelName);
 
         /// <summary>
         /// Replaces all labels on the specified issues with the provided labels
diff --git a/Octokit.Reactive/Clients/IObservableSearchClient.cs b/Octokit.Reactive/Clients/IObservableSearchClient.cs
index d3eb6135..4a47cd05 100644
--- a/Octokit.Reactive/Clients/IObservableSearchClient.cs
+++ b/Octokit.Reactive/Clients/IObservableSearchClient.cs
@@ -38,5 +38,13 @@ namespace Octokit.Reactive
         /// <param name="search"></param>
         /// <returns>List of files</returns>
         IObservable<SearchCodeResult> SearchCode(SearchCodeRequest search);
+
+        /// <summary>
+        /// search labels
+        /// https://developer.github.com/v3/search/#search-labels
+        /// </summary>
+        /// <param name="search"></param>
+        /// <returns>List of labels</returns>
+        IObservable<SearchLabelsResult> SearchLabels(SearchLabelsRequest search);
     }
 }
\ No newline at end of file
diff --git a/Octokit.Reactive/Clients/ObservableIssuesLabelsClient.cs b/Octokit.Reactive/Clients/ObservableIssuesLabelsClient.cs
index ff23308b..f3400c14 100644
--- a/Octokit.Reactive/Clients/ObservableIssuesLabelsClient.cs
+++ b/Octokit.Reactive/Clients/ObservableIssuesLabelsClient.cs
@@ -71,7 +71,7 @@ namespace Octokit.Reactive
             Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
             Ensure.ArgumentNotNull(options, nameof(options));
 
-            return _connection.GetAndFlattenAllPages<Label>(ApiUrls.IssueLabels(owner, name, number), options);
+            return _connection.GetAndFlattenAllPages<Label>(ApiUrls.IssueLabels(owner, name, number), null, AcceptHeaders.LabelsApiPreview, options);
         }
 
         /// <summary>
@@ -87,7 +87,7 @@ namespace Octokit.Reactive
         {
             Ensure.ArgumentNotNull(options, nameof(options));
 
-            return _connection.GetAndFlattenAllPages<Label>(ApiUrls.IssueLabels(repositoryId, number), options);
+            return _connection.GetAndFlattenAllPages<Label>(ApiUrls.IssueLabels(repositoryId, number), null, AcceptHeaders.LabelsApiPreview, options);
         }
 
         /// <summary>
@@ -133,7 +133,7 @@ namespace Octokit.Reactive
             Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
             Ensure.ArgumentNotNull(options, nameof(options));
 
-            return _connection.GetAndFlattenAllPages<Label>(ApiUrls.Labels(owner, name), options);
+            return _connection.GetAndFlattenAllPages<Label>(ApiUrls.Labels(owner, name), null, AcceptHeaders.LabelsApiPreview, options);
         }
 
         /// <summary>
@@ -148,7 +148,7 @@ namespace Octokit.Reactive
         {
             Ensure.ArgumentNotNull(options, nameof(options));
 
-            return _connection.GetAndFlattenAllPages<Label>(ApiUrls.Labels(repositoryId), options);
+            return _connection.GetAndFlattenAllPages<Label>(ApiUrls.Labels(repositoryId), null, AcceptHeaders.LabelsApiPreview, options);
         }
 
         /// <summary>
@@ -197,7 +197,7 @@ namespace Octokit.Reactive
             Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
             Ensure.ArgumentNotNull(options, nameof(options));
 
-            return _connection.GetAndFlattenAllPages<Label>(ApiUrls.MilestoneLabels(owner, name, number), options);
+            return _connection.GetAndFlattenAllPages<Label>(ApiUrls.MilestoneLabels(owner, name, number), null, AcceptHeaders.LabelsApiPreview, options);
         }
 
         /// <summary>
@@ -213,7 +213,7 @@ namespace Octokit.Reactive
         {
             Ensure.ArgumentNotNull(options, nameof(options));
 
-            return _connection.GetAndFlattenAllPages<Label>(ApiUrls.MilestoneLabels(repositoryId, number), options);
+            return _connection.GetAndFlattenAllPages<Label>(ApiUrls.MilestoneLabels(repositoryId, number), null, AcceptHeaders.LabelsApiPreview, options);
         }
 
         /// <summary>
@@ -401,13 +401,15 @@ namespace Octokit.Reactive
         /// <param name="name">The name of the repository</param>
         /// <param name="number">The number of the issue</param>
         /// <param name="labelName">The name of the label to remove</param>
-        public IObservable<Unit> RemoveFromIssue(string owner, string name, int number, string labelName)
+        public IObservable<Label> RemoveFromIssue(string owner, string name, int number, string labelName)
         {
             Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
             Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
             Ensure.ArgumentNotNullOrEmptyString(labelName, nameof(labelName));
 
-            return _client.RemoveFromIssue(owner, name, number, labelName).ToObservable();
+            return _client.RemoveFromIssue(owner, name, number, labelName)
+                .ToObservable()
+                .SelectMany(x => x); // HACK: DELETE is not compatible with GetAndFlattenPages
         }
 
         /// <summary>
@@ -419,11 +421,13 @@ namespace Octokit.Reactive
         /// <param name="repositoryId">The Id of the repository</param>
         /// <param name="number">The number of the issue</param>
         /// <param name="labelName">The name of the label to remove</param>
-        public IObservable<Unit> RemoveFromIssue(long repositoryId, int number, string labelName)
+        public IObservable<Label> RemoveFromIssue(long repositoryId, int number, string labelName)
         {
             Ensure.ArgumentNotNullOrEmptyString(labelName, nameof(labelName));
 
-            return _client.RemoveFromIssue(repositoryId, number, labelName).ToObservable();
+            return _client.RemoveFromIssue(repositoryId, number, labelName)
+                .ToObservable()
+                .SelectMany(x => x); // HACK: DELETE is not compatible with GetAndFlattenPages
         }
 
         /// <summary>
diff --git a/Octokit.Reactive/Clients/ObservableSearchClient.cs b/Octokit.Reactive/Clients/ObservableSearchClient.cs
index 3505de26..9f9b2c7f 100644
--- a/Octokit.Reactive/Clients/ObservableSearchClient.cs
+++ b/Octokit.Reactive/Clients/ObservableSearchClient.cs
@@ -64,5 +64,17 @@ namespace Octokit.Reactive
             Ensure.ArgumentNotNull(search, nameof(search));
             return _client.SearchCode(search).ToObservable();
         }
+
+        /// <summary>
+        /// search labels
+        /// https://developer.github.com/v3/search/#search-labels
+        /// </summary>
+        /// <param name="search"></param>
+        /// <returns>List of labels</returns>
+        public IObservable<SearchLabelsResult> SearchLabels(SearchLabelsRequest search)
+        {
+            Ensure.ArgumentNotNull(search, nameof(search));
+            return _client.SearchLabels(search).ToObservable();
+        }
     }
 }
\ No newline at end of file
diff --git a/Octokit.Tests.Integration/Clients/IssuesLabelsClientTests.cs b/Octokit.Tests.Integration/Clients/IssuesLabelsClientTests.cs
index 59c50038..e95b7c7f 100644
--- a/Octokit.Tests.Integration/Clients/IssuesLabelsClientTests.cs
+++ b/Octokit.Tests.Integration/Clients/IssuesLabelsClientTests.cs
@@ -46,6 +46,7 @@ public class IssuesLabelsClientTests : IDisposable
 
         Assert.Equal(1, issueLabelsInfo.Count);
         Assert.Equal(newLabel.Color, issueLabelsInfo[0].Color);
+        Assert.Equal(newLabel.Description, issueLabelsInfo[0].Description);
     }
 
     [IntegrationTest]
@@ -69,6 +70,7 @@ public class IssuesLabelsClientTests : IDisposable
 
         Assert.Equal(1, issueLabelsInfo.Count);
         Assert.Equal(newLabel.Color, issueLabelsInfo[0].Color);
+        Assert.Equal(newLabel.Description, issueLabelsInfo[0].Description);
     }
 
     [IntegrationTest]
@@ -792,6 +794,7 @@ public class IssuesLabelsClientTests : IDisposable
 
         Assert.Equal(label.Name, issueLabelLookupByName.Name);
         Assert.Equal(label.Color, issueLabelLookupByName.Color);
+        Assert.Equal(label.Description, issueLabelLookupByName.Description);
     }
 
     [IntegrationTest]
@@ -807,6 +810,51 @@ public class IssuesLabelsClientTests : IDisposable
         Assert.Equal(label.Color, issueLabelLookupByName.Color);
     }
 
+    [IntegrationTest]
+    public async Task CanCreateIssueLabel()
+    {
+        var newLabel = new NewLabel("test label", "FFFFFF");
+        var label = await _issuesLabelsClient.Create(_context.RepositoryOwner, _context.RepositoryName, newLabel);
+        Assert.NotNull(label);
+
+        var issueLabelLookupByName = await _issuesLabelsClient.Get(_context.RepositoryOwner, _context.RepositoryName, label.Name);
+
+        Assert.Equal(label.Name, issueLabelLookupByName.Name);
+        Assert.Equal(label.Color, issueLabelLookupByName.Color);
+    }
+
+    [IntegrationTest]
+    public async Task CanCreateIssueLabelWithDescription()
+    {
+        var newLabel = new NewLabel("test label", "FFFFFF") { Description = "Test label description." };
+        var label = await _issuesLabelsClient.Create(_context.RepositoryOwner, _context.RepositoryName, newLabel);
+        Assert.NotNull(label);
+
+        var issueLabelLookupByName = await _issuesLabelsClient.Get(_context.RepositoryOwner, _context.RepositoryName, label.Name);
+
+        Assert.Equal(label.Name, issueLabelLookupByName.Name);
+        Assert.Equal(label.Color, issueLabelLookupByName.Color);
+        Assert.Equal(label.Description, issueLabelLookupByName.Description);
+    }
+
+    [IntegrationTest]
+    public async Task CanUpdateIssueLabel()
+    {
+        var newLabel = new NewLabel("test label", "FFFFFF") { Description = "Test label description." };
+        var label = await _issuesLabelsClient.Create(_context.RepositoryOwner, _context.RepositoryName, newLabel);
+        Assert.NotNull(label);
+
+        var labelUpdate = new LabelUpdate("test label", "000000") { Description = "Updated label description." };
+        label = await _issuesLabelsClient.Update(_context.RepositoryOwner, _context.RepositoryName, labelUpdate.Name, labelUpdate);
+        Assert.NotNull(label);
+
+        var issueLabelLookupByName = await _issuesLabelsClient.Get(_context.RepositoryOwner, _context.RepositoryName, label.Name);
+
+        Assert.Equal(labelUpdate.Name, issueLabelLookupByName.Name);
+        Assert.Equal(labelUpdate.Color, issueLabelLookupByName.Color);
+        Assert.Equal(labelUpdate.Description, issueLabelLookupByName.Description);
+    }
+
     [IntegrationTest]
     public async Task CanDeleteIssueLabelByName()
     {
diff --git a/Octokit.Tests.Integration/Clients/SearchClientTests.cs b/Octokit.Tests.Integration/Clients/SearchClientTests.cs
index 7f27b4d6..303fdfe0 100644
--- a/Octokit.Tests.Integration/Clients/SearchClientTests.cs
+++ b/Octokit.Tests.Integration/Clients/SearchClientTests.cs
@@ -616,4 +616,14 @@ public class SearchClientTests
         // Ensure no items from the first search are in the results for the second
         Assert.DoesNotContain(issues.Items, x1 => otherIssues.Items.Any(x2 => x2.Id == x1.Id));
     }
+
+    [IntegrationTest]
+    public async Task SearchForAllLabelsUsingTermAndRepositoryId()
+    {
+        var request = new SearchLabelsRequest("category", 7528679);
+        
+        var labels = await _gitHubClient.Search.SearchLabels(request);
+
+        Assert.NotEmpty(labels.Items);
+    }
 }
diff --git a/Octokit.Tests/Clients/IssuesLabelsClientTests.cs b/Octokit.Tests/Clients/IssuesLabelsClientTests.cs
index 786cf120..dfe82b79 100644
--- a/Octokit.Tests/Clients/IssuesLabelsClientTests.cs
+++ b/Octokit.Tests/Clients/IssuesLabelsClientTests.cs
@@ -28,7 +28,7 @@ namespace Octokit.Tests.Clients
 
                 await client.GetAllForIssue("fake", "repo", 42);
 
-                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels"), Args.ApiOptions);
+                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels"), null, "application/vnd.github.symmetra-preview+json", Args.ApiOptions);
             }
 
             [Fact]
@@ -39,7 +39,7 @@ namespace Octokit.Tests.Clients
 
                 await client.GetAllForIssue(1, 42);
 
-                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels"), Args.ApiOptions);
+                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels"), null, "application/vnd.github.symmetra-preview+json", Args.ApiOptions);
             }
 
             [Fact]
@@ -57,7 +57,7 @@ namespace Octokit.Tests.Clients
 
                 await client.GetAllForIssue("fake", "repo", 42, options);
 
-                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels"), options);
+                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels"), null, "application/vnd.github.symmetra-preview+json", options);
             }
 
             [Fact]
@@ -75,7 +75,7 @@ namespace Octokit.Tests.Clients
 
                 await client.GetAllForIssue(1, 42, options);
 
-                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels"), options);
+                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels"), null, "application/vnd.github.symmetra-preview+json", options);
             }
 
             [Fact]
@@ -108,7 +108,7 @@ namespace Octokit.Tests.Clients
 
                 await client.GetAllForRepository("fake", "repo");
 
-                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels"), Args.ApiOptions);
+                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels"), null, "application/vnd.github.symmetra-preview+json", Args.ApiOptions);
             }
 
             [Fact]
@@ -119,7 +119,7 @@ namespace Octokit.Tests.Clients
 
                 await client.GetAllForRepository(1);
 
-                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels"), Args.ApiOptions);
+                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels"), null, "application/vnd.github.symmetra-preview+json", Args.ApiOptions);
             }
 
             [Fact]
@@ -137,7 +137,7 @@ namespace Octokit.Tests.Clients
 
                 await client.GetAllForRepository("fake", "repo", options);
 
-                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels"), options);
+                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels"), null, "application/vnd.github.symmetra-preview+json", options);
             }
 
             [Fact]
@@ -155,7 +155,7 @@ namespace Octokit.Tests.Clients
 
                 await client.GetAllForRepository(1, options);
 
-                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels"), options);
+                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels"), null, "application/vnd.github.symmetra-preview+json", options);
             }
 
             [Fact]
@@ -188,7 +188,7 @@ namespace Octokit.Tests.Clients
 
                 await client.GetAllForMilestone("fake", "repo", 42);
 
-                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/milestones/42/labels"), Args.ApiOptions);
+                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/milestones/42/labels"), null, "application/vnd.github.symmetra-preview+json", Args.ApiOptions);
             }
 
             [Fact]
@@ -199,7 +199,7 @@ namespace Octokit.Tests.Clients
 
                 await client.GetAllForMilestone(1, 42);
 
-                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/milestones/42/labels"), Args.ApiOptions);
+                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/milestones/42/labels"), null, "application/vnd.github.symmetra-preview+json", Args.ApiOptions);
             }
 
             [Fact]
@@ -217,7 +217,7 @@ namespace Octokit.Tests.Clients
 
                 await client.GetAllForMilestone("fake", "repo", 42, options);
 
-                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/milestones/42/labels"), options);
+                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/milestones/42/labels"), null, "application/vnd.github.symmetra-preview+json", options);
             }
 
             [Fact]
@@ -235,7 +235,7 @@ namespace Octokit.Tests.Clients
 
                 await client.GetAllForMilestone(1, 42, options);
 
-                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/milestones/42/labels"), options);
+                connection.Received().GetAll<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/milestones/42/labels"), null, "application/vnd.github.symmetra-preview+json", options);
             }
 
             [Fact]
@@ -268,7 +268,7 @@ namespace Octokit.Tests.Clients
 
                 await client.Get("fake", "repo", "label");
 
-                connection.Received().Get<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels/label"));
+                connection.Received().Get<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels/label"), null, "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -279,7 +279,7 @@ namespace Octokit.Tests.Clients
 
                 await client.Get(1, "label");
 
-                connection.Received().Get<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels/label"));
+                connection.Received().Get<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels/label"), null, "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -313,7 +313,7 @@ namespace Octokit.Tests.Clients
 
                 client.AddToIssue("fake", "repo", 42, labels);
 
-                connection.Received().Post<IReadOnlyList<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels"), Arg.Any<string[]>());
+                connection.Received().Post<IReadOnlyList<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels"), Arg.Any<string[]>(), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -324,7 +324,7 @@ namespace Octokit.Tests.Clients
 
                 client.AddToIssue(1, 42, labels);
 
-                connection.Received().Post<IReadOnlyList<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels"), Arg.Any<string[]>());
+                connection.Received().Post<IReadOnlyList<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels"), Arg.Any<string[]>(), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -353,7 +353,7 @@ namespace Octokit.Tests.Clients
 
                 client.RemoveFromIssue("fake", "repo", 42, "label");
 
-                connection.Received().Delete(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels/label"));
+                connection.Received().Delete<IReadOnlyList<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels/label"), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -364,7 +364,7 @@ namespace Octokit.Tests.Clients
 
                 client.RemoveFromIssue(1, 42, "label");
 
-                connection.Received().Delete(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels/label"));
+                connection.Received().Delete<IReadOnlyList<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels/label"), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -398,7 +398,7 @@ namespace Octokit.Tests.Clients
 
                 client.ReplaceAllForIssue("fake", "repo", 42, labels);
 
-                connection.Received().Put<IReadOnlyList<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels"), Arg.Any<string[]>());
+                connection.Received().Put<IReadOnlyList<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels"), Arg.Any<string[]>(), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -409,7 +409,7 @@ namespace Octokit.Tests.Clients
 
                 client.ReplaceAllForIssue(1, 42, labels);
 
-                connection.Received().Put<IReadOnlyList<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels"), Arg.Any<string[]>());
+                connection.Received().Put<IReadOnlyList<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels"), Arg.Any<string[]>(), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -520,7 +520,7 @@ namespace Octokit.Tests.Clients
 
                 client.Create("fake", "repo", newLabel);
 
-                connection.Received().Post<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels"), newLabel);
+                connection.Received().Post<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels"), newLabel, "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -533,7 +533,7 @@ namespace Octokit.Tests.Clients
 
                 client.Create(1, newLabel);
 
-                connection.Received().Post<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels"), newLabel);
+                connection.Received().Post<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels"), newLabel, "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -565,7 +565,7 @@ namespace Octokit.Tests.Clients
 
                 client.Update("fake", "repo", "labelName", labelUpdate);
 
-                connection.Received().Post<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels/labelName"), labelUpdate);
+                connection.Received().Post<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels/labelName"), labelUpdate, "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -578,7 +578,7 @@ namespace Octokit.Tests.Clients
 
                 client.Update(1, "labelName", labelUpdate);
 
-                connection.Received().Post<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels/labelName"), labelUpdate);
+                connection.Received().Post<Label>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels/labelName"), labelUpdate, "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
diff --git a/Octokit.Tests/Clients/SearchClientTests.cs b/Octokit.Tests/Clients/SearchClientTests.cs
index a4eba60b..d90f0e3e 100644
--- a/Octokit.Tests/Clients/SearchClientTests.cs
+++ b/Octokit.Tests/Clients/SearchClientTests.cs
@@ -1675,5 +1675,111 @@ namespace Octokit.Tests.Clients
                     async () => await client.SearchCode(request));
             }
         }
+
+        public class TheSearchLabelsMethod
+        {
+            [Fact]
+            public void RequestsTheCorrectUrl()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new SearchClient(connection);
+                client.SearchLabels(new SearchLabelsRequest("something", 1));
+                connection.Received().Get<SearchLabelsResult>(
+                    Arg.Is<Uri>(u => u.ToString() == "search/labels"),
+                    Arg.Any<Dictionary<string, string>>(),
+                    "application/vnd.github.symmetra-preview+json");
+            }
+
+            [Fact]
+            public async Task EnsuresNonNullArguments()
+            {
+                var client = new SearchClient(Substitute.For<IApiConnection>());
+                await Assert.ThrowsAsync<ArgumentNullException>(() => client.SearchLabels(null));
+            }
+
+            [Fact]
+            public void TestingTheTermParameter()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new SearchClient(connection);
+                var request = new SearchLabelsRequest("something", 1);
+
+                client.SearchLabels(request);
+
+                connection.Received().Get<SearchLabelsResult>(
+                    Arg.Is<Uri>(u => u.ToString() == "search/labels"),
+                    Arg.Is<Dictionary<string, string>>(d => 
+                        d["q"] == "something" &&
+                        d["repository_id"] == "1"),
+                    "application/vnd.github.symmetra-preview+json");
+            }
+
+            [Fact]
+            public void TestingTheSortParameter()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new SearchClient(connection);
+                var request = new SearchLabelsRequest("something", 1);
+                request.SortField = LabelSearchSort.Created;
+
+                client.SearchLabels(request);
+
+                connection.Received().Get<SearchLabelsResult>(
+                    Arg.Is<Uri>(u => u.ToString() == "search/labels"),
+                    Arg.Is<Dictionary<string, string>>(d => d["sort"] == "created"),
+                    "application/vnd.github.symmetra-preview+json");
+            }
+
+            [Fact]
+            public void TestingTheOrderParameter()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new SearchClient(connection);
+                var request = new SearchLabelsRequest("something", 1);
+                request.SortField = LabelSearchSort.Created;
+                request.Order = SortDirection.Ascending;
+
+                client.SearchLabels(request);
+
+                connection.Received().Get<SearchLabelsResult>(
+                    Arg.Is<Uri>(u => u.ToString() == "search/labels"),
+                    Arg.Is<Dictionary<string, string>>(d =>
+                        d["sort"] == "created" &&
+                        d["order"] == "asc"),
+                    "application/vnd.github.symmetra-preview+json");
+            }
+
+            [Fact]
+            public void TestingTheDefaultOrderParameter()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new SearchClient(connection);
+                var request = new SearchLabelsRequest("something", 1);
+
+                client.SearchLabels(request);
+
+                connection.Received().Get<SearchLabelsResult>(
+                    Arg.Is<Uri>(u => u.ToString() == "search/labels"),
+                    Arg.Is<Dictionary<string, string>>(d => d["order"] == "desc"),
+                    "application/vnd.github.symmetra-preview+json");
+            }
+
+            [Fact]
+            public void TestingTheRepositoryIdParameter()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new SearchClient(connection);
+                var request = new SearchLabelsRequest("something", 1);
+
+                client.SearchLabels(request);
+
+                connection.Received().Get<SearchLabelsResult>(
+                    Arg.Is<Uri>(u => u.ToString() == "search/labels"),
+                    Arg.Is<Dictionary<string, string>>(d =>
+                        d["q"] == "something" && 
+                        d["repository_id"] == "1"),
+                    "application/vnd.github.symmetra-preview+json");
+            }
+        }
     }
 }
diff --git a/Octokit.Tests/Reactive/ObservableIssuesLabelsClientTests.cs b/Octokit.Tests/Reactive/ObservableIssuesLabelsClientTests.cs
index fe63561c..57b03054 100644
--- a/Octokit.Tests/Reactive/ObservableIssuesLabelsClientTests.cs
+++ b/Octokit.Tests/Reactive/ObservableIssuesLabelsClientTests.cs
@@ -30,7 +30,7 @@ namespace Octokit.Tests.Reactive
 
                 client.GetAllForIssue("fake", "repo", 42);
 
-                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels"), Args.EmptyDictionary, null);
+                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels"), Args.EmptyDictionary, "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -42,7 +42,7 @@ namespace Octokit.Tests.Reactive
 
                 client.GetAllForIssue(1, 42);
 
-                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels"), Args.EmptyDictionary, null);
+                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels"), Args.EmptyDictionary, "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -61,7 +61,7 @@ namespace Octokit.Tests.Reactive
 
                 client.GetAllForIssue("fake", "repo", 42, options);
 
-                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels"), Arg.Is<Dictionary<string, string>>(d => d.Count == 2), null);
+                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels"), Arg.Is<Dictionary<string, string>>(d => d.Count == 2), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -80,7 +80,7 @@ namespace Octokit.Tests.Reactive
 
                 client.GetAllForIssue(1, 42, options);
 
-                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels"), Arg.Is<Dictionary<string, string>>(d => d.Count == 2), null);
+                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels"), Arg.Is<Dictionary<string, string>>(d => d.Count == 2), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -114,7 +114,7 @@ namespace Octokit.Tests.Reactive
 
                 client.GetAllForRepository("fake", "repo");
 
-                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels"), Args.EmptyDictionary, null);
+                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels"), Args.EmptyDictionary, "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -126,7 +126,7 @@ namespace Octokit.Tests.Reactive
 
                 client.GetAllForRepository(1);
 
-                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels"), Args.EmptyDictionary, null);
+                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels"), Args.EmptyDictionary, "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -145,7 +145,7 @@ namespace Octokit.Tests.Reactive
 
                 client.GetAllForRepository("fake", "repo", options);
 
-                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels"), Arg.Is<Dictionary<string, string>>(d => d.Count == 2), null);
+                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels"), Arg.Is<Dictionary<string, string>>(d => d.Count == 2), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -164,7 +164,7 @@ namespace Octokit.Tests.Reactive
 
                 client.GetAllForRepository(1, options);
 
-                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels"), Arg.Is<Dictionary<string, string>>(d => d.Count == 2), null);
+                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/labels"), Arg.Is<Dictionary<string, string>>(d => d.Count == 2), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -198,7 +198,7 @@ namespace Octokit.Tests.Reactive
 
                 client.GetAllForMilestone("fake", "repo", 42);
 
-                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/milestones/42/labels"), Args.EmptyDictionary, null);
+                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/milestones/42/labels"), Args.EmptyDictionary, "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -210,7 +210,7 @@ namespace Octokit.Tests.Reactive
 
                 client.GetAllForMilestone(1, 42);
 
-                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/milestones/42/labels"), Args.EmptyDictionary, null);
+                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/milestones/42/labels"), Args.EmptyDictionary, "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -229,7 +229,7 @@ namespace Octokit.Tests.Reactive
 
                 client.GetAllForMilestone("fake", "repo", 42, options);
 
-                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/milestones/42/labels"), Arg.Is<Dictionary<string, string>>(d => d.Count == 2), null);
+                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/milestones/42/labels"), Arg.Is<Dictionary<string, string>>(d => d.Count == 2), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -248,7 +248,7 @@ namespace Octokit.Tests.Reactive
 
                 client.GetAllForMilestone(1, 42, options);
 
-                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/milestones/42/labels"), Arg.Is<Dictionary<string, string>>(d => d.Count == 2), null);
+                connection.Received().Get<List<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/milestones/42/labels"), Arg.Is<Dictionary<string, string>>(d => d.Count == 2), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -367,7 +367,7 @@ namespace Octokit.Tests.Reactive
 
                 client.RemoveFromIssue("fake", "repo", 42, "label");
 
-                connection.Received().Delete(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels/label"));
+                connection.Received().Delete<IReadOnlyList<Label>>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42/labels/label"), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
@@ -379,7 +379,7 @@ namespace Octokit.Tests.Reactive
 
                 client.RemoveFromIssue(1, 42, "label");
 
-                connection.Received().Delete(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels/label"));
+                connection.Received().Delete<IReadOnlyList<Label>>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/issues/42/labels/label"), "application/vnd.github.symmetra-preview+json");
             }
 
             [Fact]
diff --git a/Octokit/Clients/IIssuesLabelsClient.cs b/Octokit/Clients/IIssuesLabelsClient.cs
index e34d8304..2c535ebe 100644
--- a/Octokit/Clients/IIssuesLabelsClient.cs
+++ b/Octokit/Clients/IIssuesLabelsClient.cs
@@ -263,7 +263,7 @@ namespace Octokit
         /// <param name="name">The name of the repository</param>
         /// <param name="number">The number of the issue</param>
         /// <param name="labelName">The name of the label to remove</param>
-        Task RemoveFromIssue(string owner, string name, int number, string labelName);
+        Task<IReadOnlyList<Label>> RemoveFromIssue(string owner, string name, int number, string labelName);
 
         /// <summary>
         /// Removes a label from an issue
@@ -274,7 +274,7 @@ namespace Octokit
         /// <param name="repositoryId">The Id of the repository</param>
         /// <param name="number">The number of the issue</param>
         /// <param name="labelName">The name of the label to remove</param>
-        Task RemoveFromIssue(long repositoryId, int number, string labelName);
+        Task<IReadOnlyList<Label>> RemoveFromIssue(long repositoryId, int number, string labelName);
 
         /// <summary>
         /// Replaces all labels on the specified issues with the provided labels
diff --git a/Octokit/Clients/ISearchClient.cs b/Octokit/Clients/ISearchClient.cs
index ed8b9f3a..2246b53e 100644
--- a/Octokit/Clients/ISearchClient.cs
+++ b/Octokit/Clients/ISearchClient.cs
@@ -41,5 +41,13 @@ namespace Octokit
         /// <param name="search"></param>
         /// <returns>List of files</returns>
         Task<SearchCodeResult> SearchCode(SearchCodeRequest search);
+
+        /// <summary>
+        /// search labels
+        /// https://developer.github.com/v3/search/#search-labels
+        /// </summary>
+        /// <param name="search"></param>
+        /// <returns>List of labels</returns>
+        Task<SearchLabelsResult> SearchLabels(SearchLabelsRequest search);
     }
 }
\ No newline at end of file
diff --git a/Octokit/Clients/IssuesLabelsClient.cs b/Octokit/Clients/IssuesLabelsClient.cs
index 964d5675..15a51be6 100644
--- a/Octokit/Clients/IssuesLabelsClient.cs
+++ b/Octokit/Clients/IssuesLabelsClient.cs
@@ -62,7 +62,7 @@ namespace Octokit
             Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
             Ensure.ArgumentNotNull(options, nameof(options));
 
-            return ApiConnection.GetAll<Label>(ApiUrls.IssueLabels(owner, name, number), options);
+            return ApiConnection.GetAll<Label>(ApiUrls.IssueLabels(owner, name, number), null, AcceptHeaders.LabelsApiPreview, options);
         }
 
         /// <summary>
@@ -78,7 +78,7 @@ namespace Octokit
         {
             Ensure.ArgumentNotNull(options, nameof(options));
 
-            return ApiConnection.GetAll<Label>(ApiUrls.IssueLabels(repositoryId, number), options);
+            return ApiConnection.GetAll<Label>(ApiUrls.IssueLabels(repositoryId, number), null, AcceptHeaders.LabelsApiPreview, options);
         }
 
         /// <summary>
@@ -124,7 +124,7 @@ namespace Octokit
             Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
             Ensure.ArgumentNotNull(options, nameof(options));
 
-            return ApiConnection.GetAll<Label>(ApiUrls.Labels(owner, name), options);
+            return ApiConnection.GetAll<Label>(ApiUrls.Labels(owner, name), null, AcceptHeaders.LabelsApiPreview, options);
         }
 
         /// <summary>
@@ -139,7 +139,7 @@ namespace Octokit
         {
             Ensure.ArgumentNotNull(options, nameof(options));
 
-            return ApiConnection.GetAll<Label>(ApiUrls.Labels(repositoryId), options);
+            return ApiConnection.GetAll<Label>(ApiUrls.Labels(repositoryId), null, AcceptHeaders.LabelsApiPreview, options);
         }
 
         /// <summary>
@@ -188,7 +188,7 @@ namespace Octokit
             Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
             Ensure.ArgumentNotNull(options, nameof(options));
 
-            return ApiConnection.GetAll<Label>(ApiUrls.MilestoneLabels(owner, name, number), options);
+            return ApiConnection.GetAll<Label>(ApiUrls.MilestoneLabels(owner, name, number), null, AcceptHeaders.LabelsApiPreview, options);
         }
 
         /// <summary>
@@ -204,7 +204,7 @@ namespace Octokit
         {
             Ensure.ArgumentNotNull(options, nameof(options));
 
-            return ApiConnection.GetAll<Label>(ApiUrls.MilestoneLabels(repositoryId, number), options);
+            return ApiConnection.GetAll<Label>(ApiUrls.MilestoneLabels(repositoryId, number), null, AcceptHeaders.LabelsApiPreview, options);
         }
 
         /// <summary>
@@ -222,7 +222,7 @@ namespace Octokit
             Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
             Ensure.ArgumentNotNullOrEmptyString(labelName, nameof(labelName));
 
-            return ApiConnection.Get<Label>(ApiUrls.Label(owner, name, labelName));
+            return ApiConnection.Get<Label>(ApiUrls.Label(owner, name, labelName), null, AcceptHeaders.LabelsApiPreview);
         }
 
         /// <summary>
@@ -237,7 +237,7 @@ namespace Octokit
         {
             Ensure.ArgumentNotNullOrEmptyString(labelName, nameof(labelName));
 
-            return ApiConnection.Get<Label>(ApiUrls.Label(repositoryId, labelName));
+            return ApiConnection.Get<Label>(ApiUrls.Label(repositoryId, labelName), null, AcceptHeaders.LabelsApiPreview);
         }
 
         /// <summary>
@@ -288,7 +288,7 @@ namespace Octokit
             Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
             Ensure.ArgumentNotNull(newLabel, nameof(newLabel));
 
-            return ApiConnection.Post<Label>(ApiUrls.Labels(owner, name), newLabel);
+            return ApiConnection.Post<Label>(ApiUrls.Labels(owner, name), newLabel, AcceptHeaders.LabelsApiPreview);
         }
 
         /// <summary>
@@ -303,7 +303,7 @@ namespace Octokit
         {
             Ensure.ArgumentNotNull(newLabel, nameof(newLabel));
 
-            return ApiConnection.Post<Label>(ApiUrls.Labels(repositoryId), newLabel);
+            return ApiConnection.Post<Label>(ApiUrls.Labels(repositoryId), newLabel, AcceptHeaders.LabelsApiPreview);
         }
 
         /// <summary>
@@ -323,7 +323,7 @@ namespace Octokit
             Ensure.ArgumentNotNullOrEmptyString(labelName, nameof(labelName));
             Ensure.ArgumentNotNull(labelUpdate, nameof(labelUpdate));
 
-            return ApiConnection.Post<Label>(ApiUrls.Label(owner, name, labelName), labelUpdate);
+            return ApiConnection.Post<Label>(ApiUrls.Label(owner, name, labelName), labelUpdate, AcceptHeaders.LabelsApiPreview);
         }
 
         /// <summary>
@@ -340,7 +340,7 @@ namespace Octokit
             Ensure.ArgumentNotNullOrEmptyString(labelName, nameof(labelName));
             Ensure.ArgumentNotNull(labelUpdate, nameof(labelUpdate));
 
-            return ApiConnection.Post<Label>(ApiUrls.Label(repositoryId, labelName), labelUpdate);
+            return ApiConnection.Post<Label>(ApiUrls.Label(repositoryId, labelName), labelUpdate, AcceptHeaders.LabelsApiPreview);
         }
 
         /// <summary>
@@ -359,7 +359,7 @@ namespace Octokit
             Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
             Ensure.ArgumentNotNull(labels, nameof(labels));
 
-            return ApiConnection.Post<IReadOnlyList<Label>>(ApiUrls.IssueLabels(owner, name, number), labels);
+            return ApiConnection.Post<IReadOnlyList<Label>>(ApiUrls.IssueLabels(owner, name, number), labels, AcceptHeaders.LabelsApiPreview);
         }
 
         /// <summary>
@@ -375,7 +375,7 @@ namespace Octokit
         {
             Ensure.ArgumentNotNull(labels, nameof(labels));
 
-            return ApiConnection.Post<IReadOnlyList<Label>>(ApiUrls.IssueLabels(repositoryId, number), labels);
+            return ApiConnection.Post<IReadOnlyList<Label>>(ApiUrls.IssueLabels(repositoryId, number), labels, AcceptHeaders.LabelsApiPreview);
         }
 
         /// <summary>
@@ -388,13 +388,13 @@ namespace Octokit
         /// <param name="name">The name of the repository</param>
         /// <param name="number">The number of the issue</param>
         /// <param name="labelName">The name of the label to remove</param>
-        public Task RemoveFromIssue(string owner, string name, int number, string labelName)
+        public Task<IReadOnlyList<Label>> RemoveFromIssue(string owner, string name, int number, string labelName)
         {
             Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
             Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
             Ensure.ArgumentNotNullOrEmptyString(labelName, nameof(labelName));
 
-            return ApiConnection.Delete(ApiUrls.IssueLabel(owner, name, number, labelName));
+            return ApiConnection.Delete<IReadOnlyList<Label>>(ApiUrls.IssueLabel(owner, name, number, labelName), AcceptHeaders.LabelsApiPreview);
         }
 
         /// <summary>
@@ -406,11 +406,11 @@ namespace Octokit
         /// <param name="repositoryId">The Id of the repository</param>
         /// <param name="number">The number of the issue</param>
         /// <param name="labelName">The name of the label to remove</param>
-        public Task RemoveFromIssue(long repositoryId, int number, string labelName)
+        public Task<IReadOnlyList<Label>> RemoveFromIssue(long repositoryId, int number, string labelName)
         {
             Ensure.ArgumentNotNullOrEmptyString(labelName, nameof(labelName));
 
-            return ApiConnection.Delete(ApiUrls.IssueLabel(repositoryId, number, labelName));
+            return ApiConnection.Delete<IReadOnlyList<Label>>(ApiUrls.IssueLabel(repositoryId, number, labelName), AcceptHeaders.LabelsApiPreview);
         }
 
         /// <summary>
@@ -429,7 +429,7 @@ namespace Octokit
             Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
             Ensure.ArgumentNotNull(labels, nameof(labels));
 
-            return ApiConnection.Put<IReadOnlyList<Label>>(ApiUrls.IssueLabels(owner, name, number), labels);
+            return ApiConnection.Put<IReadOnlyList<Label>>(ApiUrls.IssueLabels(owner, name, number), labels, AcceptHeaders.LabelsApiPreview);
         }
 
         /// <summary>
@@ -445,7 +445,7 @@ namespace Octokit
         {
             Ensure.ArgumentNotNull(labels, nameof(labels));
 
-            return ApiConnection.Put<IReadOnlyList<Label>>(ApiUrls.IssueLabels(repositoryId, number), labels);
+            return ApiConnection.Put<IReadOnlyList<Label>>(ApiUrls.IssueLabels(repositoryId, number), labels, AcceptHeaders.LabelsApiPreview);
         }
 
         /// <summary>
diff --git a/Octokit/Clients/SearchClient.cs b/Octokit/Clients/SearchClient.cs
index aa6c8024..57731cc1 100644
--- a/Octokit/Clients/SearchClient.cs
+++ b/Octokit/Clients/SearchClient.cs
@@ -66,5 +66,17 @@ namespace Octokit
             Ensure.ArgumentNotNull(search, nameof(search));
             return ApiConnection.Get<SearchCodeResult>(ApiUrls.SearchCode(), search.Parameters);
         }
+
+        /// <summary>
+        /// search labels
+        /// https://developer.github.com/v3/search/#search-labels
+        /// </summary>
+        /// <param name="search"></param>
+        /// <returns>List of labels</returns>
+        public Task<SearchLabelsResult> SearchLabels(SearchLabelsRequest search)
+        {
+            Ensure.ArgumentNotNull(search, nameof(search));
+            return ApiConnection.Get<SearchLabelsResult>(ApiUrls.SearchLabels(), search.Parameters, AcceptHeaders.LabelsApiPreview);
+        }
     }
 }
\ No newline at end of file
diff --git a/Octokit/Helpers/AcceptHeaders.cs b/Octokit/Helpers/AcceptHeaders.cs
index b3701aca..c096074e 100644
--- a/Octokit/Helpers/AcceptHeaders.cs
+++ b/Octokit/Helpers/AcceptHeaders.cs
@@ -59,6 +59,8 @@ namespace Octokit
 
         public const string PreReceiveEnvironmentsPreview = "application/vnd.github.eye-scream-preview+json";
 
+        public const string LabelsApiPreview = "application/vnd.github.symmetra-preview+json";
+
         /// <summary>
         /// Combines multiple preview headers. GitHub API supports Accept header with multiple
         /// values separated by comma.
diff --git a/Octokit/Helpers/ApiUrls.cs b/Octokit/Helpers/ApiUrls.cs
index 53198747..cd978d59 100644
--- a/Octokit/Helpers/ApiUrls.cs
+++ b/Octokit/Helpers/ApiUrls.cs
@@ -1781,6 +1781,15 @@ namespace Octokit
             return "search/code".FormatUri();
         }
 
+        /// <summary>
+        /// Creates the relative <see cref="Uri"/> for searching labels
+        /// </summary>
+        /// <returns></returns>
+        public static Uri SearchLabels()
+        {
+            return "search/labels".FormatUri();
+        }
+
         /// <summary>
         /// Returns the <see cref="Uri"/> for repository contributors.
         /// </summary>
diff --git a/Octokit/Models/Request/BaseSearchRequest.cs b/Octokit/Models/Request/BaseSearchRequest.cs
index 48ccf258..ce98a0d7 100644
--- a/Octokit/Models/Request/BaseSearchRequest.cs
+++ b/Octokit/Models/Request/BaseSearchRequest.cs
@@ -75,7 +75,10 @@ namespace Octokit
         /// <summary>
         /// All qualifiers that are used for this search
         /// </summary>
-        public abstract IReadOnlyList<string> MergedQualifiers();
+        public virtual IReadOnlyList<string> MergedQualifiers()
+        {
+            return new List<string>();
+        }
 
         /// <summary>
         /// Add qualifiers onto the search term
@@ -96,6 +99,14 @@ namespace Octokit
             }
         }
 
+        /// <summary>
+        /// Any additional parameters required by the derived class
+        /// </summary>
+        public virtual IDictionary<string, string> AdditionalParameters()
+        {
+            return new Dictionary<string, string>();
+        }
+
         /// <summary>
         /// Get the query parameters that will be appending onto the search
         /// </summary>
@@ -114,6 +125,10 @@ namespace Octokit
                 {
                     d.Add("sort", Sort);
                 }
+                foreach (var parameter in AdditionalParameters())
+                {
+                    d.Add(parameter.Key, parameter.Value);
+                }
                 return d;
             }
         }
diff --git a/Octokit/Models/Request/LabelUpdate.cs b/Octokit/Models/Request/LabelUpdate.cs
index bcfbbfe1..db576c18 100644
--- a/Octokit/Models/Request/LabelUpdate.cs
+++ b/Octokit/Models/Request/LabelUpdate.cs
@@ -49,6 +49,11 @@ namespace Octokit
             }
         }
 
+        /// <summary>
+        /// A short description of the label (optional).
+        /// </summary>
+        public string Description { get; set; }
+
         internal string DebuggerDisplay
         {
             get
diff --git a/Octokit/Models/Request/NewLabel.cs b/Octokit/Models/Request/NewLabel.cs
index 2f6e596e..30fee490 100644
--- a/Octokit/Models/Request/NewLabel.cs
+++ b/Octokit/Models/Request/NewLabel.cs
@@ -30,11 +30,18 @@ namespace Octokit
         /// <summary>
         /// Name of the label (required).
         /// </summary>
+        /// <remarks>
+        /// Emoji can be added to label names, using either native emoji or colon-style markup. For example,
+        /// typing :strawberry: will render the emoji for strawberry. For a full list of available emoji and codes, see http://emoji-cheat-sheet.com/.
+        /// </remarks>
         public string Name { get; set; }
 
         /// <summary>
         /// Color of the label (required).
         /// </summary>
+        /// <remarks>
+        /// The hexadecimal color code for the label, without the leading #.
+        /// </remarks>
         public string Color
         {
             get { return _color; }
@@ -49,6 +56,11 @@ namespace Octokit
             }
         }
 
+        /// <summary>
+        /// A short description of the label (optional).
+        /// </summary>
+        public string Description { get; set; }
+
         internal string DebuggerDisplay
         {
             get
diff --git a/Octokit/Models/Request/SearchLabelsRequest.cs b/Octokit/Models/Request/SearchLabelsRequest.cs
new file mode 100644
index 00000000..dc067c9a
--- /dev/null
+++ b/Octokit/Models/Request/SearchLabelsRequest.cs
@@ -0,0 +1,82 @@
+using System.Collections.Generic;
+using System.Collections.ObjectModel;
+using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
+using System.Globalization;
+using System.Linq;
+using Octokit.Internal;
+
+namespace Octokit
+{
+    /// <summary>
+    /// Search labels
+    /// https://developer.github.com/v3/search/#search-labels
+    /// </summary>
+    [DebuggerDisplay("{DebuggerDisplay,nq}")]
+    public class SearchLabelsRequest : BaseSearchRequest
+    {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="SearchLabelsRequest"/> class.
+        /// </summary>
+        public SearchLabelsRequest() : base()
+        {
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="SearchLabelsRequest"/> class.
+        /// </summary>
+        /// <param name="term">The search term.</param>
+        /// <param name="repositoryId">The repository to search in</param>
+        public SearchLabelsRequest(string term, long repositoryId) : base(term)
+        {
+            RepositoryId = repositoryId;
+        }
+
+        /// <summary>
+        /// Optional Sort field. One of created or updated.
+        /// If not provided, results are sorted by best match.
+        /// </summary>
+        public LabelSearchSort? SortField { get; set; }
+
+        public override string Sort
+        {
+            get { return SortField.ToParameter(); }
+        }
+
+        /// <summary>
+        /// The repository to search in
+        /// </summary>
+        public long RepositoryId { get; set; }
+
+        public override IDictionary<string, string> AdditionalParameters()
+        {
+            return new Dictionary<string, string>
+            {
+                { "repository_id", RepositoryId.ToString() }
+            };
+        }
+
+        internal string DebuggerDisplay
+        {
+            get
+            {
+                return string.Format(CultureInfo.InvariantCulture, "Term: {0} Sort: {1} RepositoryId: {2}", Term, Sort, RepositoryId);
+            }
+        }
+    }
+
+    public enum LabelSearchSort
+    {
+        /// <summary>
+        /// search by created
+        /// </summary>
+        [Parameter(Value = "created")]
+        Created,
+        
+        /// <summary>
+        /// search by last updated
+        /// </summary>
+        [Parameter(Value = "updated")]
+        Updated
+    }
+}
diff --git a/Octokit/Models/Response/Label.cs b/Octokit/Models/Response/Label.cs
index f962aefd..e387963c 100644
--- a/Octokit/Models/Response/Label.cs
+++ b/Octokit/Models/Response/Label.cs
@@ -8,11 +8,13 @@ namespace Octokit
     {
         public Label() { }
 
-        public Label(string url, string name, string color)
+        public Label(string url, string name, string color, string description, bool @default)
         {
             Url = url;
             Name = name;
             Color = color;
+            Description = description;
+            Default = @default;
         }
 
         /// <summary>
@@ -30,6 +32,16 @@ namespace Octokit
         /// </summary>
         public string Color { get; protected set; }
 
+        /// <summary>
+        /// Description of the label
+        /// </summary>
+        public string Description { get; protected set; }
+
+        /// <summary>
+        /// Is default label
+        /// </summary>
+        public bool Default { get; protected set; }
+
         internal string DebuggerDisplay
         {
             get { return string.Format(CultureInfo.InvariantCulture, "Name: {0} Color: {1}", Name, Color); }
diff --git a/Octokit/Models/Response/SearchLabelsResult.cs b/Octokit/Models/Response/SearchLabelsResult.cs
new file mode 100644
index 00000000..aee442c5
--- /dev/null
+++ b/Octokit/Models/Response/SearchLabelsResult.cs
@@ -0,0 +1,17 @@
+using System.Collections.Generic;
+using System.Diagnostics;
+using Octokit.Internal;
+
+namespace Octokit
+{
+    [DebuggerDisplay("{DebuggerDisplay,nq}")]
+    public class SearchLabelsResult : SearchResult<Label>
+    {
+        public SearchLabelsResult() { }
+
+        public SearchLabelsResult(int totalCount, bool incompleteResults, IReadOnlyList<Label> items)
+            : base(totalCount, incompleteResults, items)
+        {
+        }
+    }
+}
\ No newline at end of file