diff --git a/Octokit.Tests.Integration/Clients/PullRequestsClientTests.cs b/Octokit.Tests.Integration/Clients/PullRequestsClientTests.cs index 96e947c6..80afe81b 100644 --- a/Octokit.Tests.Integration/Clients/PullRequestsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/PullRequestsClientTests.cs @@ -59,6 +59,7 @@ public class PullRequestsClientTests : IDisposable Assert.Equal(1, pullRequests.Count); Assert.Equal(result.Title, pullRequests[0].Title); + Assert.True(pullRequests[0].Id > 0); } [IntegrationTest] diff --git a/Octokit/Models/Response/Issue.cs b/Octokit/Models/Response/Issue.cs index bc7da88b..7bcb8df2 100644 --- a/Octokit/Models/Response/Issue.cs +++ b/Octokit/Models/Response/Issue.cs @@ -38,7 +38,7 @@ namespace Octokit } /// - /// The Id for this issue + /// The internal Id for this issue (not the issue number) /// public int Id { get; protected set; } diff --git a/Octokit/Models/Response/PullRequest.cs b/Octokit/Models/Response/PullRequest.cs index e5fdc3ba..5644a0b3 100644 --- a/Octokit/Models/Response/PullRequest.cs +++ b/Octokit/Models/Response/PullRequest.cs @@ -15,8 +15,9 @@ namespace Octokit Number = number; } - public PullRequest(Uri url, Uri htmlUrl, Uri diffUrl, Uri patchUrl, Uri issueUrl, Uri statusesUrl, int number, ItemState state, string title, string body, DateTimeOffset createdAt, DateTimeOffset updatedAt, DateTimeOffset? closedAt, DateTimeOffset? mergedAt, GitReference head, GitReference @base, User user, User assignee, IReadOnlyList assignees, bool? mergeable, User mergedBy, int comments, int commits, int additions, int deletions, int changedFiles, Milestone milestone, bool locked) + public PullRequest(long id, Uri url, Uri htmlUrl, Uri diffUrl, Uri patchUrl, Uri issueUrl, Uri statusesUrl, int number, ItemState state, string title, string body, DateTimeOffset createdAt, DateTimeOffset updatedAt, DateTimeOffset? closedAt, DateTimeOffset? mergedAt, GitReference head, GitReference @base, User user, User assignee, IReadOnlyList assignees, bool? mergeable, User mergedBy, int comments, int commits, int additions, int deletions, int changedFiles, Milestone milestone, bool locked) { + Id = id; Url = url; HtmlUrl = htmlUrl; DiffUrl = diffUrl; @@ -47,6 +48,11 @@ namespace Octokit Locked = locked; } + /// + /// The internal Id for this pull request (not the pull request number) + /// + public long Id { get; protected set; } + /// /// The URL for this pull request. ///