From fd6e1fc3c03b1935fee3fa62ba153ba1974aff4c Mon Sep 17 00:00:00 2001 From: Perry Taylor Date: Mon, 4 Nov 2013 17:40:51 -0500 Subject: [PATCH] Remove lists from observable issues comments client --- .../Clients/IObservableIssueCommentsClient.cs | 9 +++------ .../Clients/ObservableIssueCommentsClient.cs | 12 +++++++----- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs b/Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs index ce8483fa..2d8d0a7c 100644 --- a/Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs +++ b/Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs @@ -1,7 +1,4 @@ - - -using System; -using System.Collections.Generic; +using System; using System.Diagnostics.CodeAnalysis; namespace Octokit.Reactive @@ -27,7 +24,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// - IObservable> GetForRepository(string owner, string name); + IObservable GetForRepository(string owner, string name); /// /// Gets Issue Comments for a specified Issue. @@ -37,7 +34,7 @@ namespace Octokit.Reactive /// The name of the repository /// The issue number /// - IObservable> GetForIssue(string owner, string name, int number); + IObservable GetForIssue(string owner, string name, int number); /// /// Creates a new Issue Comment for a specified Issue. diff --git a/Octokit.Reactive/Clients/ObservableIssueCommentsClient.cs b/Octokit.Reactive/Clients/ObservableIssueCommentsClient.cs index a99a1312..34042f1f 100644 --- a/Octokit.Reactive/Clients/ObservableIssueCommentsClient.cs +++ b/Octokit.Reactive/Clients/ObservableIssueCommentsClient.cs @@ -1,18 +1,20 @@ using System; -using System.Collections.Generic; using System.Reactive.Threading.Tasks; +using Octokit.Reactive.Internal; namespace Octokit.Reactive { public class ObservableIssueCommentsClient : IObservableIssueCommentsClient { readonly IIssueCommentsClient _client; + readonly IConnection _connection; public ObservableIssueCommentsClient(IGitHubClient client) { Ensure.ArgumentNotNull(client, "client"); _client = client.Issue.Comment; + _connection = client.Connection; } /// @@ -42,12 +44,12 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The list of s for the specified Repository. - public IObservable> GetForRepository(string owner, string name) + public IObservable GetForRepository(string owner, string name) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); - return _client.GetForRepository(owner, name).ToObservable(); + return _connection.GetAndFlattenAllPages(ApiUrls.IssueComments(owner, name)); } /// @@ -60,12 +62,12 @@ namespace Octokit.Reactive /// The name of the repository /// The issue number /// The list of s for the specified Issue. - public IObservable> GetForIssue(string owner, string name, int number) + public IObservable GetForIssue(string owner, string name, int number) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); - return _client.GetForIssue(owner, name, number).ToObservable(); + return _connection.GetAndFlattenAllPages(ApiUrls.IssueComments(owner, name, number)); } ///