From ff7c3125e2f535248ebdcc829a1d567fcadbebf7 Mon Sep 17 00:00:00 2001 From: pltaylor Date: Tue, 5 Nov 2013 11:54:59 -0500 Subject: [PATCH] Change name to ActivityEvents --- ....cs => IObservableActivityEventsClient.cs} | 2 +- ...t.cs => ObservableActivityEventsClient.cs} | 4 +-- Octokit.Reactive/Octokit.Reactive.csproj | 4 +-- ...tTests.cs => ActivityEventsClientTests.cs} | 36 +++++++++---------- Octokit.Tests/Octokit.Tests.csproj | 4 +-- ...=> ObservableActivityEventsClientTests.cs} | 36 +++++++++---------- ...itiesClient.cs => ActivityEventsClient.cs} | 4 +-- ...tiesClient.cs => IActivityEventsClient.cs} | 2 +- Octokit/GitHubClient.cs | 4 +-- Octokit/IGitHubClient.cs | 2 +- Octokit/Octokit.csproj | 4 +-- 11 files changed, 51 insertions(+), 51 deletions(-) rename Octokit.Reactive/Clients/{IObservableActivitiesClient.cs => IObservableActivityEventsClient.cs} (98%) rename Octokit.Reactive/Clients/{ObservableActivitiesClient.cs => ObservableActivityEventsClient.cs} (97%) rename Octokit.Tests/Clients/{ActivitiesClientTests.cs => ActivityEventsClientTests.cs} (86%) rename Octokit.Tests/Reactive/{ObservableActivitiesClientTests.cs => ObservableActivityEventsClientTests.cs} (85%) rename Octokit/Clients/{ActivitiesClient.cs => ActivityEventsClient.cs} (97%) rename Octokit/Clients/{IActivitiesClient.cs => IActivityEventsClient.cs} (99%) diff --git a/Octokit.Reactive/Clients/IObservableActivitiesClient.cs b/Octokit.Reactive/Clients/IObservableActivityEventsClient.cs similarity index 98% rename from Octokit.Reactive/Clients/IObservableActivitiesClient.cs rename to Octokit.Reactive/Clients/IObservableActivityEventsClient.cs index 5bcfad79..fd9251fd 100644 --- a/Octokit.Reactive/Clients/IObservableActivitiesClient.cs +++ b/Octokit.Reactive/Clients/IObservableActivityEventsClient.cs @@ -2,7 +2,7 @@ namespace Octokit.Reactive { - public interface IObservableActivitiesClient + public interface IObservableActivityEventsClient { /// /// Gets all the public events diff --git a/Octokit.Reactive/Clients/ObservableActivitiesClient.cs b/Octokit.Reactive/Clients/ObservableActivityEventsClient.cs similarity index 97% rename from Octokit.Reactive/Clients/ObservableActivitiesClient.cs rename to Octokit.Reactive/Clients/ObservableActivityEventsClient.cs index 520432fd..a56c885a 100644 --- a/Octokit.Reactive/Clients/ObservableActivitiesClient.cs +++ b/Octokit.Reactive/Clients/ObservableActivityEventsClient.cs @@ -3,11 +3,11 @@ using Octokit.Reactive.Internal; namespace Octokit.Reactive { - public class ObservableActivitiesClient : IObservableActivitiesClient + public class ObservableActivityEventsClient : IObservableActivityEventsClient { IConnection _connection; - public ObservableActivitiesClient(IGitHubClient client) + public ObservableActivityEventsClient(IGitHubClient client) { Ensure.ArgumentNotNull(client, "client"); diff --git a/Octokit.Reactive/Octokit.Reactive.csproj b/Octokit.Reactive/Octokit.Reactive.csproj index 302c99ac..909f6dd6 100644 --- a/Octokit.Reactive/Octokit.Reactive.csproj +++ b/Octokit.Reactive/Octokit.Reactive.csproj @@ -73,8 +73,8 @@ Properties\SolutionInfo.cs - - + + diff --git a/Octokit.Tests/Clients/ActivitiesClientTests.cs b/Octokit.Tests/Clients/ActivityEventsClientTests.cs similarity index 86% rename from Octokit.Tests/Clients/ActivitiesClientTests.cs rename to Octokit.Tests/Clients/ActivityEventsClientTests.cs index d16b74a5..eb722cb0 100644 --- a/Octokit.Tests/Clients/ActivitiesClientTests.cs +++ b/Octokit.Tests/Clients/ActivityEventsClientTests.cs @@ -6,7 +6,7 @@ using Xunit; namespace Octokit.Tests.Clients { - public class ActivitiesClientTests + public class ActivityEventsClientTests { public class TheGetAllMethod { @@ -14,7 +14,7 @@ namespace Octokit.Tests.Clients public void RequestsCorrectUrl() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); client.GetAll(); @@ -28,7 +28,7 @@ namespace Octokit.Tests.Clients public void RequestsCorrectUrl() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); client.GetAllForRepository("fake", "repo"); @@ -39,7 +39,7 @@ namespace Octokit.Tests.Clients public async Task EnsuresArgumentsNotNull() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); await AssertEx.Throws(async () => await client.GetAllForRepository(null, "name")); await AssertEx.Throws(async () => await client.GetAllForRepository("", "name")); @@ -54,7 +54,7 @@ namespace Octokit.Tests.Clients public void RequestsCorrectUrl() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); client.GetAllForRepositoryNetwork("fake", "repo"); @@ -65,7 +65,7 @@ namespace Octokit.Tests.Clients public async Task EnsuresArgumentsNotNull() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); await AssertEx.Throws(async () => await client.GetAllForRepositoryNetwork(null, "name")); await AssertEx.Throws(async () => await client.GetAllForRepositoryNetwork("", "name")); @@ -80,7 +80,7 @@ namespace Octokit.Tests.Clients public void RequestsCorrectUrl() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); client.GetAllForOrganization("fake"); @@ -91,7 +91,7 @@ namespace Octokit.Tests.Clients public async Task EnsuresArgumentsNotNull() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); await AssertEx.Throws(async () => await client.GetAllForOrganization(null)); await AssertEx.Throws(async () => await client.GetAllForOrganization("")); @@ -104,7 +104,7 @@ namespace Octokit.Tests.Clients public void RequestsCorrectUrl() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); client.GetUserReceived("fake"); @@ -115,7 +115,7 @@ namespace Octokit.Tests.Clients public async Task EnsuresArgumentsNotNull() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); await AssertEx.Throws(async () => await client.GetUserReceived(null)); await AssertEx.Throws(async () => await client.GetUserReceived("")); @@ -128,7 +128,7 @@ namespace Octokit.Tests.Clients public void RequestsCorrectUrl() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); client.GetUserReceivedPublic("fake"); @@ -139,7 +139,7 @@ namespace Octokit.Tests.Clients public async Task EnsuresArgumentsNotNull() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); await AssertEx.Throws(async () => await client.GetUserReceivedPublic(null)); await AssertEx.Throws(async () => await client.GetUserReceivedPublic("")); @@ -152,7 +152,7 @@ namespace Octokit.Tests.Clients public void RequestsCorrectUrl() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); client.GetUserPerformed("fake"); @@ -163,7 +163,7 @@ namespace Octokit.Tests.Clients public async Task EnsuresArgumentsNotNull() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); await AssertEx.Throws(async () => await client.GetUserPerformed(null)); await AssertEx.Throws(async () => await client.GetUserPerformed("")); @@ -176,7 +176,7 @@ namespace Octokit.Tests.Clients public void RequestsCorrectUrl() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); client.GetUserPerformedPublic("fake"); @@ -187,7 +187,7 @@ namespace Octokit.Tests.Clients public async Task EnsuresArgumentsNotNull() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); await AssertEx.Throws(async () => await client.GetUserPerformedPublic(null)); await AssertEx.Throws(async () => await client.GetUserPerformedPublic("")); @@ -200,7 +200,7 @@ namespace Octokit.Tests.Clients public void RequestsCorrectUrl() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); client.GetForAnOrganization("fake", "org"); @@ -211,7 +211,7 @@ namespace Octokit.Tests.Clients public async Task EnsuresArgumentsNotNull() { var connection = Substitute.For(); - var client = new ActivitiesClient(connection); + var client = new ActivityEventsClient(connection); await AssertEx.Throws(async () => await client.GetForAnOrganization(null, "org")); await AssertEx.Throws(async () => await client.GetForAnOrganization("", "org")); diff --git a/Octokit.Tests/Octokit.Tests.csproj b/Octokit.Tests/Octokit.Tests.csproj index 9619bc49..42f8895a 100644 --- a/Octokit.Tests/Octokit.Tests.csproj +++ b/Octokit.Tests/Octokit.Tests.csproj @@ -62,7 +62,7 @@ - + @@ -111,7 +111,7 @@ - + diff --git a/Octokit.Tests/Reactive/ObservableActivitiesClientTests.cs b/Octokit.Tests/Reactive/ObservableActivityEventsClientTests.cs similarity index 85% rename from Octokit.Tests/Reactive/ObservableActivitiesClientTests.cs rename to Octokit.Tests/Reactive/ObservableActivityEventsClientTests.cs index dcfb2d68..beddfebb 100644 --- a/Octokit.Tests/Reactive/ObservableActivitiesClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableActivityEventsClientTests.cs @@ -9,7 +9,7 @@ using Xunit; namespace Octokit.Tests.Reactive { - public class ObservableActivitiesClientTests + public class ObservableActivityEventsClientTests { public class TheGetAllMethod { @@ -17,7 +17,7 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrl() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); client.GetAll(); @@ -31,7 +31,7 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrl() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); client.GetAllForRepository("fake", "repo"); @@ -42,7 +42,7 @@ namespace Octokit.Tests.Reactive public async Task EnsuresArgumentsNotNull() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); await AssertEx.Throws(async () => await client.GetAllForRepository(null, "name")); await AssertEx.Throws(async () => await client.GetAllForRepository("", "name")); @@ -57,7 +57,7 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrl() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); client.GetAllForRepositoryNetwork("fake", "repo"); @@ -68,7 +68,7 @@ namespace Octokit.Tests.Reactive public async Task EnsuresArgumentsNotNull() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); await AssertEx.Throws(async () => await client.GetAllForRepositoryNetwork(null, "name")); await AssertEx.Throws(async () => await client.GetAllForRepositoryNetwork("", "name")); @@ -83,7 +83,7 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrl() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); client.GetAllForOrganization("fake"); @@ -94,7 +94,7 @@ namespace Octokit.Tests.Reactive public async Task EnsuresArgumentsNotNull() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); await AssertEx.Throws(async () => await client.GetAllForOrganization(null)); await AssertEx.Throws(async () => await client.GetAllForOrganization("")); @@ -107,7 +107,7 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrl() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); client.GetUserReceived("fake"); @@ -118,7 +118,7 @@ namespace Octokit.Tests.Reactive public async Task EnsuresArgumentsNotNull() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); await AssertEx.Throws(async () => await client.GetUserReceived(null)); await AssertEx.Throws(async () => await client.GetUserReceived("")); @@ -131,7 +131,7 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrl() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); client.GetUserReceivedPublic("fake"); @@ -142,7 +142,7 @@ namespace Octokit.Tests.Reactive public async Task EnsuresArgumentsNotNull() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); await AssertEx.Throws(async () => await client.GetUserReceivedPublic(null)); await AssertEx.Throws(async () => await client.GetUserReceivedPublic("")); @@ -155,7 +155,7 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrl() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); client.GetUserPerformed("fake"); @@ -166,7 +166,7 @@ namespace Octokit.Tests.Reactive public async Task EnsuresArgumentsNotNull() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); await AssertEx.Throws(async () => await client.GetUserPerformed(null)); await AssertEx.Throws(async () => await client.GetUserPerformed("")); @@ -179,7 +179,7 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrl() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); client.GetUserPerformedPublic("fake"); @@ -190,7 +190,7 @@ namespace Octokit.Tests.Reactive public async Task EnsuresArgumentsNotNull() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); await AssertEx.Throws(async () => await client.GetUserPerformedPublic(null)); await AssertEx.Throws(async () => await client.GetUserPerformedPublic("")); @@ -203,7 +203,7 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrl() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); client.GetForAnOrganization("fake", "org"); @@ -214,7 +214,7 @@ namespace Octokit.Tests.Reactive public async Task EnsuresArgumentsNotNull() { var gitHubClient = Substitute.For(); - var client = new ObservableActivitiesClient(gitHubClient); + var client = new ObservableActivityEventsClient(gitHubClient); await AssertEx.Throws(async () => await client.GetForAnOrganization(null, "org")); await AssertEx.Throws(async () => await client.GetForAnOrganization("", "org")); diff --git a/Octokit/Clients/ActivitiesClient.cs b/Octokit/Clients/ActivityEventsClient.cs similarity index 97% rename from Octokit/Clients/ActivitiesClient.cs rename to Octokit/Clients/ActivityEventsClient.cs index 56a999f4..0c3020e0 100644 --- a/Octokit/Clients/ActivitiesClient.cs +++ b/Octokit/Clients/ActivityEventsClient.cs @@ -3,9 +3,9 @@ using System.Threading.Tasks; namespace Octokit { - public class ActivitiesClient : ApiClient, IActivitiesClient + public class ActivityEventsClient : ApiClient, IActivityEventsClient { - public ActivitiesClient(IApiConnection apiConnection) + public ActivityEventsClient(IApiConnection apiConnection) : base(apiConnection) { } diff --git a/Octokit/Clients/IActivitiesClient.cs b/Octokit/Clients/IActivityEventsClient.cs similarity index 99% rename from Octokit/Clients/IActivitiesClient.cs rename to Octokit/Clients/IActivityEventsClient.cs index 38cdf676..6a1e903e 100644 --- a/Octokit/Clients/IActivitiesClient.cs +++ b/Octokit/Clients/IActivityEventsClient.cs @@ -3,7 +3,7 @@ using System.Threading.Tasks; namespace Octokit { - public interface IActivitiesClient + public interface IActivityEventsClient { /// /// Gets all the public events diff --git a/Octokit/GitHubClient.cs b/Octokit/GitHubClient.cs index bd91ff80..970e7771 100644 --- a/Octokit/GitHubClient.cs +++ b/Octokit/GitHubClient.cs @@ -80,7 +80,7 @@ namespace Octokit Connection = connection; var apiConnection = new ApiConnection(connection); Authorization = new AuthorizationsClient(apiConnection); - Event = new ActivitiesClient(apiConnection); + Event = new ActivityEventsClient(apiConnection); Issue = new IssuesClient(apiConnection); Miscellaneous = new MiscellaneousClient(connection); Notification = new NotificationsClient(apiConnection); @@ -127,7 +127,7 @@ namespace Octokit public IConnection Connection { get; private set; } public IAuthorizationsClient Authorization { get; private set; } - public IActivitiesClient Event { get; set; } + public IActivityEventsClient Event { get; set; } public IIssuesClient Issue { get; private set; } public IMiscellaneousClient Miscellaneous { get; private set; } public IOrganizationsClient Organization { get; private set; } diff --git a/Octokit/IGitHubClient.cs b/Octokit/IGitHubClient.cs index 73dcb7c4..3a87d78c 100644 --- a/Octokit/IGitHubClient.cs +++ b/Octokit/IGitHubClient.cs @@ -7,7 +7,7 @@ namespace Octokit IConnection Connection { get; } IAuthorizationsClient Authorization { get; } - IActivitiesClient Event { get; } + IActivityEventsClient Event { get; } IIssuesClient Issue { get; } IMiscellaneousClient Miscellaneous { get; } IOrganizationsClient Organization { get; } diff --git a/Octokit/Octokit.csproj b/Octokit/Octokit.csproj index 501f3472..fd2499f7 100644 --- a/Octokit/Octokit.csproj +++ b/Octokit/Octokit.csproj @@ -52,12 +52,12 @@ Properties\SolutionInfo.cs - + - +