80719c0033
aaaand format the code
2015-11-04 13:38:51 -08:00
bfb0559351
tidy up some xml-docs while i'm in here
2015-11-03 09:34:19 -08:00
aa44aa0da5
Fixed the spacing
...
Fixed the spacing of comma and aligned the arguments.
2015-10-21 10:06:06 -04:00
1886629e6f
Fixes for Downloading ReleaseAsset zip File #854
...
This commit addressed the `BuildResponse` wasn't handling
response `content-type` `application/octet-stream` for binary items.
2015-10-16 14:29:43 -04:00
afc8c2e450
green: implemented ReadOnlyPagedCollectionTests.TheConstructor.AcceptsAResponseWithANullBody
2015-09-17 13:56:38 +02:00
87d24f5fa7
fixed impacted tests
2015-09-10 15:38:00 +09:30
23735d61e2
bugfix: setter removed
2015-09-10 14:17:45 +09:30
9198f80e5d
Merge pull request #860 from octokit/haacked/code-cleanup
...
Tidying up some code
2015-09-10 11:41:48 +09:00
82a3e7655c
Merge pull request #862 from octokit/haacked/836-handle-empty-content
...
Handle empty content better
2015-09-10 11:34:09 +09:00
07d6a8ad60
Minor changes based on feedback
2015-08-28 15:25:32 +01:00
1d695f1097
Merge remote-tracking branch 'upstream/master'
2015-08-16 21:44:12 +01:00
b2c7e1c2a7
Chnage LastApiInfo to GetLastApiInfo with cloned version
2015-08-16 21:27:26 +01:00
890f852c90
🎨 Refactor GetQueuedOperation to reduce duplication
...
Most calls to `GetQueuedOperation` are used to queue up an operation
that'll return a collection in a subsequent call. In the case that the
API returns No Content, we want to return an empty collection. This
refactoring embeds that last bit of logic into `GetQueuedOperation`
rather than making every caller have to do it.
2015-08-07 16:20:45 -07:00
0e74097dde
Handle NoContent response for queued operations
...
We didn't handle the 204 response properly for the `StatisticsClient`.
Now we do.
Fixes #836
2015-08-07 10:41:02 -07:00
0b13411ef5
🎨 Remove unnecessary assignment
2015-08-04 21:20:13 -07:00
2316a14a67
Do not pass null into base class
...
The base class ctor does not allow nulls.
2015-08-04 21:15:02 -07:00
6c694b5128
🎨 Remove empty statement
2015-08-04 21:14:41 -07:00
eb5d14cfdc
Organize usings and remove unused
2015-08-04 21:12:37 -07:00
15ae4257fa
🎨 Remove redundant type name prefix
...
The namespace portion of the type name is declared in a using statement.
2015-08-04 21:00:25 -07:00
0811d4cfd3
🎨 Replace tail recursive call with loop
2015-08-04 20:43:07 -07:00
ba365249a7
Added locking for thread saftey to LastApiInfo
2015-08-02 16:55:39 +01:00
40f1e59a97
Fixed merge conflicts
2015-08-02 16:40:10 +01:00
b4d71c8fe9
refactoring ApiConnection.EmptyBody to RequestBody.Empty to break the inverse dependency from Connection to ApiConnection
2015-08-01 00:16:51 -05:00
3f1bd13bb5
replacing null with an empty object hung off ApiConnection as suggested by @haacked
2015-07-31 23:47:37 -05:00
bc5a14a8af
Fixed failing tests
2015-07-31 12:23:13 +02:00
1acdd54704
Removed IApiInfoProvider from IHttpClient
2015-07-31 12:12:46 +02:00
a6a6fdf13f
Renamed IApiInfo -> IApiInfoProvider
2015-07-31 12:08:16 +02:00
f8ee4f94a1
WIP checkin for getting last ApiInfo object
2015-07-31 10:35:51 +01:00
4d9cc4ff09
Additional changes following review
2015-07-27 14:07:15 +01:00
d5d264d05b
Added changes to handle NETFX_CORE properly (I hope)
2015-07-26 22:43:04 +01:00
e092a109ea
Additional changes to support rate_limit API call
2015-07-26 22:03:19 +01:00
8e77f00d00
🎨 Minor formatting changes
2015-07-17 10:24:17 -07:00
0acdb8cc60
Merge branch 'master' into redirect-requests
...
Conflicts:
Octokit/Octokit-Mono.csproj
Octokit/Octokit-MonoAndroid.csproj
Octokit/Octokit-Monotouch.csproj
Octokit/Octokit-Portable.csproj
Octokit/Octokit-netcore45.csproj
2015-06-15 16:33:42 +09:30
982dca5f3d
specify the timeout interval when downloading the archive
2015-06-15 14:17:48 +09:30
8aa5a247d8
rename misleading responseIsArray variable to responseIsObject
2015-06-11 18:34:16 +02:00
442bbb43cd
throw an error if the redirect count has been exceeded
2015-06-05 16:11:46 +09:30
51947adc6d
added another exclusion for detecting binary content
2015-06-01 07:49:24 +09:30
3acdd10be4
deprecate the optional AllowAutoRedirect parameter
2015-05-31 22:44:41 +09:30
3859ff3627
the test, it passes
2015-05-31 22:12:22 +09:30
74ac314e34
review and cleanup suppressions
2015-05-31 20:42:15 +09:30
d7d7efd2c7
renaming things is hard
2015-05-31 20:34:29 +09:30
3c32814de7
💄
2015-05-31 19:34:43 +09:30
d551eb296e
internalize this for now
2015-05-31 19:30:13 +09:30
549ff92461
a bit more cleanup
2015-05-31 19:27:47 +09:30
e5e4b4c8b0
extracting all the cross-platform setup of HttpMessageHandler into
...
a less awful class
2015-05-31 19:23:39 +09:30
5d0c8d6679
get the portable tests back running by muting all these methods that don't exist
2015-05-31 18:58:00 +09:30
ea9f3a4761
Fixed issues with RedirectHandler and added tests
2015-05-31 18:08:37 +09:30
eb7e14bd8c
test hacks for great good
2015-05-22 20:45:59 +09:30
894609e7d9
missed a supresssion
2015-05-22 17:11:21 +09:30
f0011ccce7
missed an overload
2015-05-22 17:09:07 +09:30
Brendan Forster