Commit Graph

11 Commits

Author SHA1 Message Date
Christian Robles b797ed75a5 Asapferg/user email visibility (#1757)
* Added visibility field to EmailAddress response model

* quote private in comment to indicate string value

* Create EmailVisibility enum; change visibility to be StringEnum<EmailVisibility>

* Change EmailVisibility to be nullable, remove null option from enum

* Fixed closing tag on Visibility property summary

* unskip email integration test as it seems to work now
2018-02-18 13:56:37 +10:00
Ryan Gribble 3c818934b8 Release v0.24 - A Sight For Sore Eyes (#1539)
* Add release notes and bump version to 0.24

* run "build FormatCode" to fix up whitespace/formatting issues

* Fix failing Ssh key tests due to "validation exception".  This key must be in use on github (under another user, most likely from these tests failing).  Changed to a new SSH key and tweaked tests to reduce chance of a key being created and not destroyed

* Assignee and Assignees cant both be specified on NewIssue.  We missed this one in the PR.  Marked Assignee as [Obsolete] and fixed tests to use Assignees

* Fix a couple of Reactions tests that were calling the wrong client methods

* Fix timeline tests - looks like the response class has changed shape a bit, it now has an Issue object in the payload and Id field isnt present (leaving Id field there in case other timeline events do use it)

* Fix some following tests that require the test user to follow more than 1 other user

* Unskip these Event tests now because apparently they work!

* add breaking changes notes

* Update ApiErrorMessageSafe to return null for empty and whitespace strings (#1540)

* return null if ApiError.Message is empty or whitespace

* Uncomment test, which now passes

* update release notes to include PR1540

* Add "Bot" AccountType, was causing a deserialization exception when running the integration test "SearchForExcludedLanguage" (#1541)

* Update to include PR1541

* add bullets to make release notes easier to read

* markup additional code mentions in notes

* Fix grammar

fields => field
2017-01-17 18:56:55 +10:00
aedampir@gmail.com 632dd6218b Some tests have been rewritten according to @shiftkey remarks. 2016-03-16 13:07:22 +07:00
aedampir@gmail.com e2cb829f26 Unused commented code has been removed.
Minor changes.
2016-03-16 12:24:30 +07:00
aedampir@gmail.com f16b20d28d Some new integration tests were added in order to test Pagination Support on IUserEmailsClient and IObservableUserEmailsClient. 2016-03-15 19:32:42 +07:00
aedampir@gmail.com b920bcdfce A bunch of unit and integration tests for overloaded version of needed methods for IUserEmailsClient interface were added and impelemented.
Base methods:
Task<IReadOnlyList<EmailAddress>> GetAll()

Overload methods:
Task<IReadOnlyList<EmailAddress>> GetAll(ApiOptions options);
2016-03-15 17:17:33 +07:00
Brendan Forster 80719c0033 aaaand format the code 2015-11-04 13:38:51 -08:00
Brendan Forster 28e8372922 extract helper method for setting up GitHubClient 2015-01-04 10:03:45 +09:30
Brendan Forster e454bef609 mute this test, moving on with my life 2014-10-04 10:24:37 -03:00
Brendan Forster 2cd53f061d wireup delete API 2014-07-08 10:25:44 +09:30
Peter MacNaughton 871a6f59aa Re-added integration test for getting email 2014-02-01 16:54:24 -07:00