9 Commits

Author SHA1 Message Date
tasadar2
3345f76fc9 Adding a convention test to detect whether a model has a constructor exposing all properties (#1798)
* Added a convention test to detect a model constructor exposing all properties

* add ctors to classes where they are missing

* rename ctor parameters that dont match properties

* add missing parameters to existing ctors

* add specific PunchCard ctor to allow mocking, and update test to resolve call ambiguity

* Added base class properties to the convention test

Added member exclusion attribute

* Updated newly offending classes

2 excludes and 2 ctors

* rename exclusion attribute to be a bit shorter
2018-04-25 21:03:13 +10:00
aedampir@gmail.com
72d6e80884 Misspelling Retriev -> Retrieve was fixed. 2016-03-23 22:31:16 +07:00
Brendan Forster
80719c0033 aaaand format the code 2015-11-04 13:38:51 -08:00
Brendan Forster
5ac49efca1 fixed broken convention test 2015-01-29 13:07:17 +09:30
Brendan Forster
b8bb2a8277 Merge branch 'master' into new-authorization-api
Conflicts:
	Octokit.Tests/Clients/AuthorizationsClientTests.cs
	Octokit.Tests/Reactive/AuthorizationExtensionsTests.cs
	Octokit/Http/Connection.cs
	Octokit/Models/Response/Authorization.cs
	Octokit/Octokit-Mono.csproj
	Octokit/Octokit-MonoAndroid.csproj
	Octokit/Octokit-Monotouch.csproj
	Octokit/Octokit-Portable.csproj
	Octokit/Octokit-netcore45.csproj
2015-01-28 09:16:16 +09:30
Brendan Forster
d613cef196 introduce ApplicationAuthorization which contains raw token result 2015-01-04 14:38:59 +09:30
Haacked
9f675924b7 Make response models readonly
It's bothered me that our response models are mutable. They really
shouldn't be. I made the properties have a protected setter instead of
private to provide flexibility for others who might be deriving from
these classes or testing them.

Fixes #650
2015-01-03 20:21:36 -08:00
Haacked
a1887837be Implement 403 exception handling
This implements exception handling for the various 403 cases based off
of the Octokit.rb implementation.
https://github.com/octokit/octokit.rb/blob/master/lib/octokit/error.rb

Fixes #85
2013-10-17 22:22:56 -07:00
Haacked
a3d4238f91 Add unit test for reactive auth method 2013-10-10 14:52:05 -07:00