26 Commits

Author SHA1 Message Date
Chris Simpson
176bf386a0 maint: Tidying up DefineConstants (#2538) 2022-08-12 12:19:26 -05:00
Chris Simpson
651d9818c7 ci(build): Fixes a number of warnings for a cleaner build (#2529)
* Fixing a number of warnings for a cleaner build

* Removing extra Summary slashes
2022-08-08 10:20:37 -05:00
Diogo Rolo
4f4ef5ba73 Fix null reference access when ContentType is null (#2501) 2022-07-21 16:36:02 -05:00
Jose de Jesus Medina
5eb9f06b24 Fix typos in comments (#2040) 2019-10-30 13:51:20 -03:00
Itai Bar-Haim
4e804f61a6 Prefer using nameof(x) over literal "x" (#1781)
* updated XML docs and added some missing bits.

* prefer nameof(x) over literal "x"
2018-03-07 20:43:10 +10:00
Mickaël Derriey
13d5dab516 Port to .NET Core (#1503)
Port to .NET Core
2017-01-21 14:42:02 +10:00
Ryan Gribble
3c818934b8 Release v0.24 - A Sight For Sore Eyes (#1539)
* Add release notes and bump version to 0.24

* run "build FormatCode" to fix up whitespace/formatting issues

* Fix failing Ssh key tests due to "validation exception".  This key must be in use on github (under another user, most likely from these tests failing).  Changed to a new SSH key and tweaked tests to reduce chance of a key being created and not destroyed

* Assignee and Assignees cant both be specified on NewIssue.  We missed this one in the PR.  Marked Assignee as [Obsolete] and fixed tests to use Assignees

* Fix a couple of Reactions tests that were calling the wrong client methods

* Fix timeline tests - looks like the response class has changed shape a bit, it now has an Issue object in the payload and Id field isnt present (leaving Id field there in case other timeline events do use it)

* Fix some following tests that require the test user to follow more than 1 other user

* Unskip these Event tests now because apparently they work!

* add breaking changes notes

* Update ApiErrorMessageSafe to return null for empty and whitespace strings (#1540)

* return null if ApiError.Message is empty or whitespace

* Uncomment test, which now passes

* update release notes to include PR1540

* Add "Bot" AccountType, was causing a deserialization exception when running the integration test "SearchForExcludedLanguage" (#1541)

* Update to include PR1541

* add bullets to make release notes easier to read

* markup additional code mentions in notes

* Fix grammar

fields => field
2017-01-17 18:56:55 +10:00
Sean Killeen
01a2d97212 Update ApiErrorMessageSafe to return null for empty and whitespace strings (#1540)
* return null if ApiError.Message is empty or whitespace

* Uncomment test, which now passes
2017-01-16 23:13:00 +10:00
Mordechai Zuber
4be25ba8bd Add missing SecurityCritical attribute
Fixes #1471
2016-10-13 15:54:27 +03:00
Alexander Efremov
d7d03fafa3 Redundant parentheses were removed. (#1275) 2016-04-21 16:15:26 +10:00
Brendan Forster
6bedf1ee9b just a bit of code cleanup 2016-02-02 10:01:16 +10:30
Mordechai Zuber
44304ca70b use string per recommended style 2015-12-16 21:23:36 +02:00
Anton Sizikov
cde2518b86 String comparison specified for content type 2015-12-10 08:53:12 +01:00
Anton Sizikov
a7e06c7cd0 Removed custom message format and just print raw body 2015-12-08 10:10:59 +01:00
Anton Sizikov
5ef499686e Overrided ToString methods for ApiException and ApiError 2015-12-06 19:34:32 +01:00
Haacked
93dd16f829 Add more info to TwoFactorChallengeFailedException
I was running into an issue where i wanted more information from the
TwoFactorChallengeFailedException. It turns out, the exception could
easily provide both the TwoFactorType AND the authentication code
provided. So 💥!
2015-04-19 19:42:13 -07:00
Haacked
d8f50292e3 Stop manufacturing Response objects just to create an exception 2015-01-04 19:15:38 -08:00
Haacked
53a6516de2 Change IResponse.Body to object
This removes the awkward Body and BodyAsObject property combo we used to
have.
2015-01-04 19:06:50 -08:00
Haacked
4c8bab20eb IApiResponse no longer inherits IResponse 2015-01-04 18:58:53 -08:00
Haacked
9f675924b7 Make response models readonly
It's bothered me that our response models are mutable. They really
shouldn't be. I made the properties have a protected setter instead of
private to provide flexibility for others who might be deriving from
these classes or testing them.

Fixes #650
2015-01-03 20:21:36 -08:00
Brendan Forster
3be89e7c01 document a bunch of the Exceptions namespace 2015-01-03 09:30:05 -08:00
Haacked
dae6cb2ca6 Implement RepositoryExistsException
This exception is thrown when we try to create a repository but it
already exists on the server.
2014-02-18 21:03:29 -08:00
Haacked
f9089784f9 Fixing up the defaults a bit 2013-10-18 11:33:21 -07:00
Haacked
c87944c884 Add default messages for custom exceptions
Right now, our exception messages come from the API response in most
cases. But if for any reason there isn't one, we supply a default. I
realized these messages might make it to people's logs so it might be
nice to spend time later making them even more useful.
2013-10-18 11:08:56 -07:00
Haacked
a1887837be Implement 403 exception handling
This implements exception handling for the various 403 cases based off
of the Octokit.rb implementation.
https://github.com/octokit/octokit.rb/blob/master/lib/octokit/error.rb

Fixes #85
2013-10-17 22:22:56 -07:00
Haacked
a39a80cc88 Add exception handling for non-OK status codes 2013-10-02 16:17:36 -07:00