Commit Graph

2 Commits

Author SHA1 Message Date
Mickaël Derriey 4869fd5423 Fix broken JSON deserialization in .NET 4.5 (#1647)
* Cross target Octokit.Tests against netcoreapp1.0 and net452

* Add net45-specific references

This fixes a build error after adding the net452 target:
error CS0656: Missing compiler required member 'Microsoft.CSharp.RuntimeBinder.CSharpArgumentInfo.Create'

* Add SimpleJson conditional compilation symbols for net45

* Disable AppDomain when running tests

Thanks to Dominick and Patrik: https://twitter.com/leastprivilege/status/893376624233762816

* Use nameof operator instead of magic strings

* Remove conditional compilation symbols as they are not used in the conventions tests project

* Enable cross targetting in the conventions tests project

* Run tests against netcoreapp1.0 only when not on Windows

* Going too fast bites you
2017-08-07 10:21:58 +10:00
Ryan Gribble ffdf688e19 Final tidyups for dotnetcore (#1600)
* Dont hardcode linksources for linux builds

* split ConventionTests into their own build task, since this is how it was in FAKE previously

* update contributing doc after change to CAKE

* minor doc updates

* fix bash linksources argument

* remove all these old packages files

* use forward slashes when referring to bash script

* use Target parameter name for the PowerShell build script

* be consistent when referring to PowerShell build script

* Be even moar consistent
2017-05-04 20:32:22 +10:00