Commit Graph

8 Commits

Author SHA1 Message Date
Itai Bar-Haim 4e804f61a6 Prefer using nameof(x) over literal "x" (#1781)
* updated XML docs and added some missing bits.

* prefer nameof(x) over literal "x"
2018-03-07 20:43:10 +10:00
Ryan Gribble 3c818934b8 Release v0.24 - A Sight For Sore Eyes (#1539)
* Add release notes and bump version to 0.24

* run "build FormatCode" to fix up whitespace/formatting issues

* Fix failing Ssh key tests due to "validation exception".  This key must be in use on github (under another user, most likely from these tests failing).  Changed to a new SSH key and tweaked tests to reduce chance of a key being created and not destroyed

* Assignee and Assignees cant both be specified on NewIssue.  We missed this one in the PR.  Marked Assignee as [Obsolete] and fixed tests to use Assignees

* Fix a couple of Reactions tests that were calling the wrong client methods

* Fix timeline tests - looks like the response class has changed shape a bit, it now has an Issue object in the payload and Id field isnt present (leaving Id field there in case other timeline events do use it)

* Fix some following tests that require the test user to follow more than 1 other user

* Unskip these Event tests now because apparently they work!

* add breaking changes notes

* Update ApiErrorMessageSafe to return null for empty and whitespace strings (#1540)

* return null if ApiError.Message is empty or whitespace

* Uncomment test, which now passes

* update release notes to include PR1540

* Add "Bot" AccountType, was causing a deserialization exception when running the integration test "SearchForExcludedLanguage" (#1541)

* Update to include PR1541

* add bullets to make release notes easier to read

* markup additional code mentions in notes

* Fix grammar

fields => field
2017-01-17 18:56:55 +10:00
Elhamer d149b34214 Add ApiOption overloads to methods on IGistCommentsClient (#1260)
* Add GetAllForGist with apiOption overload to IGistCommentsClient + implementation

* Add GetAllForGist overload + implementation

* Add RequestsCorrectUrlWithApiOptions unit test

* One more test to the GistCommentsClient

* Ensure argument is not null or empty

* Clean up GistCommentsClientTests class

* Implement Integration test for the GetAllForGist method

* Clean up
2016-04-10 14:51:55 -04:00
Henrik Andersson 2427ab6922 Update observable clients 2015-03-24 00:12:41 +10:00
Dillon Buchanan 93745f1c58 Changed Gist Comment Client Id param from int to string 2015-01-20 18:38:21 -05:00
Peter MacNaughton 04d6e9b386 Generate documentation comments for the
`Reactive` project
2014-02-26 22:22:59 -07:00
Kristian Hellang ae23a2ae7a Fixed minor namespace and whitespace issues 2013-12-01 23:42:04 +01:00
Kristian Hellang c4f6c6d19d Added observable clients for gist and gist comments 2013-12-01 23:18:40 +01:00