Commit Graph

17 Commits

Author SHA1 Message Date
Itai Bar-Haim
4e804f61a6 Prefer using nameof(x) over literal "x" (#1781)
* updated XML docs and added some missing bits.

* prefer nameof(x) over literal "x"
2018-03-07 20:43:10 +10:00
Martin Scholz
b4fad9bfab Add multiple assignees to issues (#1339)
* [WIP]

* add new method to add assignees for an issue

* added new overloads

* added unit tests

* fixed missed overload calls

* fixed inconsistency in tests

* added integration tests

* fixed errors in tests

* fixed all remarks

* added new overloads

* added unit tests

* added integration tests

* fixed incorrect variable names

* added new overloads

* added unit tests

* added itegration tests

* fixed integration tests

* removed extra empty lines

* fixed errors in unit tests

* added overloads on IObservableReleasesClient and IReleasesClient

* added new unit tests

* added integration tests

* added Task as return value of unit tests

* added Task as return parameter

* added return value ReleasesClientTests

* another try to get tests work

* another one try

* undo prev commit

* fixed errors in tests

* removed extra ThrowsAsync checks

* added new overloads

* added unit tests

* added integration tests

* added integration tests

* Add ApiOptions overloads to IWatchedClient + tests.

* Add ApiOptions overloads to IObservableWatchedClient + tests.

* More tests.

* fixed error in ObservableWatchedClient

* added unit tests

* added integration tests

* added new overloads

* added unit tests

* added integration tests

* renamed "Ensures" methods to deliver more consistency in code

* fixed failed tests

* Add ApiOptions overloads to methods on I(Observable)IssuesLabelsClient (#1329)

* correcting a couple of tests (#1331)

* Add ApiOption overloads to methods on I(Observable)OrganizationsClient (#1324)

* Add ApiOptions overloads to methods on I(Observable)OrganizationMembersClient (#1332)

* fix description

* add new response for IssueAssignees

* add constructor for IssueAssignees

* add debugger display for NewAssignees

* add methods for observable assignees client; new unit tests

* add observable unit tests for add method

* place AddAssignees under IssueClient

* fix description

* [WIP] add generic delete method

* revert add assignees

* add assignees key under issue client

* remove IssueAssignees dependencies

* fix type IssueAssignees

* add remove method for issue assignees; finish generic delete method

* unit tests for remove assignees

* Add Assignees property to NewIssue and UpdateIssue requets
Add Asignees property to Issue response
Removed [SerializeNull] attribute from UpdateIssue.Assignee as this was causing it to remove assignee when none was specified
Add a couple of integration tests to prove Assignees are being deserialised

* rename NewAssignees to AssignessUpdate

* change Assignees key description

* check null Issue.ToUpdate method

* add accept header for IssuesClientTests

* Fix some more unit tests

* add integration test

Check if an assignee was added to an issue

* fix merge conflicts

* resolve conflicts

* implement some hints from @ryangribble

* resolve merge fixes

* clean up

* some more changes

* create new repo

Create a new repo for integrationtest
'CanRetrieveIssuesWithMultipleAssignees()'

* fix merge

* fix conflicts

* fix xml

* change test

* change delete overloads

* Fix tests

* fix xml

* Add helper function RemoveLabel

* Add helper function RemoveAssignee

* Format last commit

* Add integration tests to exercise new Assignees field on IssueUpdate

* GitHub API doesnt allow Assignee and Assignees properties to both be specified - API docs say that Assignee is deprecated so mark it [Obsolete] and dont populate it in Issue.ToUpdate()

* Add Assignees field to PullRequest response object, and integration tests to verify it is populated.
This field is not listed in the API docs but probing the API revealed it is included in payloads

* add a couple of extra tests to verify the IssueUpdate.Labels is working correctly

* Include assignees in ctor for consistency

* fix IssueUpdate test for new Assignees field
2017-01-11 22:53:41 +10:00
Andreia Gaita
9e958bf998 Make Repository Id a long, it's going to grow... 2016-09-15 02:15:11 +02:00
aedampir@gmail.com
44b0f4039d ID -> Id 2016-07-17 16:29:32 +07:00
aedampir@gmail.com
3c1a2fe86e removed <returns> tags here 2016-06-29 01:51:48 +07:00
Alexander Efremov
a09dd85fee cleared <returns> tags 2016-06-17 05:37:58 +07:00
Alexander Efremov
763ee76378 modified XML docs 2016-06-12 12:53:52 +07:00
Alexander Efremov
931ba5ac9b added new overloads 2016-06-12 12:21:17 +07:00
Alexander Efremov
0aca4f8863 modified xml docs 2016-06-12 12:16:21 +07:00
aedampir@gmail.com
a7c427dc4e Some ArgumentNotNullOrEmptyString were added in ObservableAssigneesClient. 2016-03-29 13:58:28 +07:00
aedampir@gmail.com
1a5658d31f Add some new tests for overloaded methods. 2016-03-21 23:25:54 +07:00
Devesh Khandelwal
abc4eb9269 Oops. Forgot to actually call the overload I added. 2016-03-15 15:27:19 +05:30
Devesh Khandelwal
829ba2c560 Add reactive overloads for ApiOptions in Assignees API. 2016-03-14 11:25:29 +05:30
Haacked
eb5d14cfdc Organize usings and remove unused 2015-08-04 21:12:37 -07:00
Henrik Andersson
2427ab6922 Update observable clients 2015-03-24 00:12:41 +10:00
Keith Dahlby
0ca21d2b2f Flatten observable of list 2013-10-30 22:27:16 -05:00
Keith Dahlby
3fb3e8966c Implement IObservableAssigneesClient 2013-10-30 22:14:05 -05:00