Commit Graph

45 Commits

Author SHA1 Message Date
Brendan Forster
8cf4d5840e upgrade project tooling to .NET Core 3.1 (#2089) 2020-02-09 12:34:34 -04:00
dependabot-preview[bot]
45621c0c79 Bump Microsoft.NET.Test.Sdk from 16.4.0 to 16.5.0 (#2083)
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.4.0...v16.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-06 09:48:13 -04:00
Brendan Forster
e065c86118 strip CoreOnly usages from codebase as they are no longer needed (#2072) 2020-01-28 08:46:10 -04:00
Brendan Forster
8605b8cf76 add .NETFX reference assemblies so that builds can be created without needing Mono for non-Windows platforms (#2064) 2020-01-27 10:57:42 -04:00
dependabot-preview[bot]
6719e870ce Bump Microsoft.NET.Test.Sdk from 16.2.0 to 16.4.0 (#2042) 2020-01-19 21:00:59 -04:00
Brendan Forster
89423fd69a no need to build and run tests against net46 (#2005) 2019-09-20 09:23:36 -03:00
Brendan Forster
60e60ca384 generated a net46-compatible binary alongside net45 (#2001) 2019-09-17 09:04:02 -03:00
dependabot-preview[bot]
539a609a40 Bump xunit.runner.visualstudio from 2.3.0-beta4-build3742 to 2.4.1 (#1999)
Bumps [xunit.runner.visualstudio](https://github.com/xunit/xunit) from 2.3.0-beta4-build3742 to 2.4.1.
- [Release notes](https://github.com/xunit/xunit/releases)
- [Commits](https://github.com/xunit/xunit/commits/2.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-17 08:33:49 -03:00
dependabot-preview[bot]
52080085a8 Bump Microsoft.NET.Test.Sdk from 15.0.0 to 16.2.0 (#2000)
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 15.0.0 to 16.2.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v15.0.0...v16.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-17 08:25:07 -03:00
dependabot-preview[bot]
ef7fe2680e Bump xunit from 2.2.0 to 2.4.1 (#1995)
Bumps [xunit](https://github.com/xunit/xunit) from 2.2.0 to 2.4.1.
- [Release notes](https://github.com/xunit/xunit/releases)
- [Commits](https://github.com/xunit/xunit/compare/2.2...2.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-16 10:06:20 -03:00
Clemens Lieb
5e751a6c38 Enable building on linux without project file changes (#1930)
* Introduce 'NoFramework' switch

This enables building via cake on linux without requiring adjustments on
other platforms, fixes #1745

* Revert hardcoding NoFramework in build.sh

* Skip GitVersion query for NoFramework build

This implies that NoFramework is intended for local use only
Accordingly a warning message has been set up in the Lifetime of the Build

* Rename NoFramework switch to CoreOnly

* Skip tool installation and formatting step for CoreOnly builds

* Default CoreOnly to false on windows and true otherwise

* Add CoreOnly switch to build variable output

* Fix 'native' msbuild on windows for both platforms

'native' msbuild invocations do not automatically set CoreOnly according to the platform
they are running on. As such we set CoreOnly to False on Windows, unless CoreOnly has been
specified already.
2019-01-31 15:36:30 +10:00
Ryan Gribble
73c36b7a49 update test apps and cake.frosting build to netcoreapp2.0 but keep libraries targeting netstandard1.1 (#1784) 2018-04-16 22:30:26 +10:00
Itai Bar-Haim
5ffc96995f Adding initial support for GitHub Apps. (#1738)
* Added authentication using bearer token.

* Added Installation and AccessToken clients.

* Added new clients to Reactive project

* added support for DateTime serialized as FileTime

* added support for StatusEventPayload

* added support for StatusEventPayload

* Added test for StatusEventPayload and fixed serializer to return that event payload type.

* WIP - added ApplicationClient and related Api Urls.

* Continued implementing Installations support.

* Fixing build (WIP)

* fixed build

* added Account property to Installation. prefer nameof(x) over literal "x".

* fixed according to code review.

* fixed build.

* switched Installation ID from int to long.

* added Permissions and Events properties to Installation.

* added documentation to Application and Installation properties in IGitHubClient.

* wip - added tests to new clients

* wip - fix build

* wip - fixed build.

* added InstallationsClient tests.

* added integration test for InstallationsClient.

* changes requested in code review.

* add Get method for App

* Create GitHubApp response model instead of re-using existing Application response model

* add Get method to observable client

* fixed build (both locally and failed test).

* Fixed documentation and added some missing XML docs.

* added DebuggerDisplay to StatusEventPayload

* updated XML docs and added some missing bits. prefer nameof(x) over literal "x".

* Add xml comments to AccessToken response model and use DateTimeOffset rather than DateTime

* Tidy up XmlComments and make consistent across client and observable client and interfaces

* fixup unit tests to independently verify preview header

* Implement GetInstallation method

* revert commits unrelated to GitHubApps - these can be done on a separate PR if required

* this extra authenticator class doesnt appear to be used anywhere

* undo project file change as it doesnt appear to be necessary

* Revert "Merge remote-tracking branch 'remote/GitHubApps' into GitHubApps"

This reverts commit c53cc110b8d807f62fdfeaa7df19e1532d050007, reversing
changes made to 0c9e413d420a4725738644ea5b13af6ec102d456.

* Revert "Revert "Merge remote-tracking branch 'remote/GitHubApps' into GitHubApps""

This reverts commit 02d52b8adf814b6945c60cb59a907a8cd34b1ce7.

* add XmlDoc comments to response models and flesh out installation permissions

* name AcceptHeaders member consistently

* accidentally lost changes to Credentials.cs

* Enhance Intergation test framework to handle GitHubApp settings and discoer tests appropriately
Get code ready for GitHubJWT nuget package but for now just hardcode a JWT in ENV VAR
Add 1 integration test for each method and ensure they are working!

* fixed compiler warnings.

* Added support for Installation=>Id field that arrives in a Pull Request Event payload.

(See the last field in the sample JSON of https://developer.github.com/v3/activity/events/types/#pullrequestevent)

* Change integration test project to netcoreapp2.0 so we can use GitHubJwt nuget package in integration tests

* First cut at some GitHubApp doco

* update mkdocs config

* Moved the Installation property to ActivityPayload, so it's available in all payloads.

This feature is not undocumented, unfortunately, but valid:
https://platform.github.community/t/determining-which-installation-an-event-came-from/539/11

* Split Installation to Installation and InstallationId, and added a comfort method for gaining its AccessToken.

* fixed InstallationId CreateAccessToken to receive IGitHubAppsClient. added (and fixed) docs.

* reverted object-oriented style comfort method and it's docs.

* update all test projects to netcoreapp2.0

* tweak build configs to use 2.0.3 SDK

* also need to update cake frosting build to netcoreapp2.0

* tweak docs some more

* fix convention test failures

* test projects still had some old runtime parts in them!

* travis osx image needs to be at least 10.12 for .NET Core 2.0

* shell script might need the same argument tweak for cake

* more doc tweaks

* Make sure compiler warning output isnt somehow causing Linux and OSX builds to fail

* moar logging for linux/OSX builds

* stop sourcelink on linux/OSX builds to see if that is the problem

* set verbosity to detailed for the dotnet build step

* try new sourcelink and list out remotes

* is travis being weird with git clone?

* SourceLink may be defaulting to true on CI server so explicitly set it as false rather than omitting it

* detailed is a bit too verbose for travis, try normal

* turn sourcelink back on for Linux/OSX

* fix compiler warning

* Try SourceLink.Create.CommandLine instead of SourceLink.Create.GitHub

* CliToolReferences did not update to latest versions

* remove debug origin info

* turn off msbuild output

* go back to SourceLink.Create.GitHub!

* time diff between dev PC and API causes issues if specifying a full 600 second token

* handle extra date format that Installation end point now returns

* field needs to be protected in order to be deserialized

* provide even more buffer for client vs server clock drift

* Update to latest GitHubJwt reference

* go back to SDK 1 since SDK 2 is having sporadic travisCI faliures in TestSourceLink build step

* get appveyor working

* update sourcelink back to latest, and use SDK 1.04 (runtime 1.0.5)
2018-04-16 20:42:23 +10:00
Ryan Gribble
c223f5ae9a Tidy up compiler warnings (#1779)
Fix XmlDoc parameter warnings (and tidy up other build output/warnings)
2018-03-07 00:17:52 +10:00
Ryan Gribble
7114bcb41e General updates (#1653)
* Update README and shipping-releases as they are a bit out of date

* Update year/copyright info

* Update cake.frosting to latest for newest dotnet tooling support, and adjust builds for new configuration parameters

* update xunit packages so codelens works for nested test classes (VS2017 15.3 update is also required)

* Fixup VS version and remove win debugging tools
2017-08-16 21:33:03 +10:00
Mickaël Derriey
4869fd5423 Fix broken JSON deserialization in .NET 4.5 (#1647)
* Cross target Octokit.Tests against netcoreapp1.0 and net452

* Add net45-specific references

This fixes a build error after adding the net452 target:
error CS0656: Missing compiler required member 'Microsoft.CSharp.RuntimeBinder.CSharpArgumentInfo.Create'

* Add SimpleJson conditional compilation symbols for net45

* Disable AppDomain when running tests

Thanks to Dominick and Patrik: https://twitter.com/leastprivilege/status/893376624233762816

* Use nameof operator instead of magic strings

* Remove conditional compilation symbols as they are not used in the conventions tests project

* Enable cross targetting in the conventions tests project

* Run tests against netcoreapp1.0 only when not on Windows

* Going too fast bites you
2017-08-07 10:21:58 +10:00
Ryan Gribble
ac49d2ad09 Migrate dotnetcore to vs2017 tooling (#1567)
* convert to VS2017

* rework cake.frosting build to latest cake vs2017 "template" example

* fix clean task and version suffix

* add arg to DotNetCorePack so it uses the correct version

* fix appveyor

* is there an easier way to test appveyor?

* ok travis, let's do this

* after reading the travis repo, this seems to be the version we want for vs201/csproj tool support

* msbuild complaining about arguments - we can use defaults anyhow so remove $@ from build.sh script

* add workaround for msbuild/travis, as mentioned on aspnet Mvc repo

* cmon travis

* perhaps tee isnt needed afterall

* travis permission denied when trying to install tools in build script... i feel dirty but need to see if sudo will fix it!

* could it be folder permissions of /build ?

* Try 777 for NuGet.exe permissions rather than 644

* remove windows platform restriction on GitVersion call

* Add a wrapper script for GitVersion on non windows

* fix wrapper script name

* add debug

* let's see if we are running the script at all!

* run mono gitversion direclty from travis.yml, for science

* see if we can run bin/sh and prepend an argument to our shell script

* remove echos from wrapper script

* Ensure full git repo include more than 50 commits and all tags are fetched, as GitVersion was failing on TravisCI

* only build netstandard framework on non windows

* revert overriding the target framework when building the solution

* Unix being case-sensitive, adjust app.config file name in csproj files

* set FrameworkPathOverride to point to different folders on macOS and Linux

* Remove NuGet.exe from the repo.

On Windows, it will be installed by the Frosting bootstrapper script.
On Unix/macOS, cake has smarts to look for mono- and Linux-specific executables

* tidy up GitVersion logic into a GitVersionRunner class

* apply workaround for osx dotnet restore "too many open files" errors

* update test project references to latest official versions

* doesnt seem to be a reason for overriding the implicit reference

* remove extra whitespace and unused namespace
2017-03-30 15:37:49 +10:00
Mickaël Derriey
13d5dab516 Port to .NET Core (#1503)
Port to .NET Core
2017-01-21 14:42:02 +10:00
Ryan Gribble
e3fa865381 add convention test to ensure all response models have a public parameterless ctor
2 model classes were missing one - technically not needed for these 2 classes due to their api calls being basic data types that then get populated into these objects, but it's easiest to just add them to these 2 classes so the test can pass on all response models
2016-07-05 23:32:40 +10:00
aedampir@gmail.com
36c08248fa New convention test was added. Now each "TheCtor" class must have "EnsuresNonNullArguments" method were throwing of ArgumentNullException from client constructor class should be tested.
All unused "using" directives were removed.
2016-04-18 12:51:35 +07:00
aedampir@gmail.com
6140bc678b Some renaming 2016-04-18 12:46:19 +07:00
aedampir@gmail.com
dfb636c393 Convention test was renamed 2016-04-18 12:46:16 +07:00
aedampir@gmail.com
3f8f782273 Additional convention test were added. 2016-04-18 12:46:09 +07:00
Brendan Forster
f9f72106be implemented a test to verify that overloads are implemented for GetAll usages 2016-02-14 16:21:23 +11:00
Brendan Forster
0521eeed0b updated xunit packages 2015-12-20 14:09:24 +10:30
Kristian Hellang
7162ce6e72 Clarify why convention tests are failing 2015-09-22 10:54:02 +02:00
Kristian Hellang
fcca5c2344 Second take on LangVersion 2015-07-22 21:41:08 +02:00
Kristian Hellang
4d2c8406da Stop teasing me with those new and shiny C# 6 features, Visual Studio 2015-06-16 22:03:20 +02:00
Henrik Andersson
b0ab485ed1 Add a convention test 2015-03-22 19:09:08 +10:00
Brendan Forster
0c4b3d86c2 upgrade test projects to xUnit 2.0 RTM 2015-03-17 17:21:55 +09:30
Kristian Hellang
1fabaf4cc5 Implemented test to check for readonly properties 2015-01-05 23:41:11 +01:00
Brendan Forster
ab706bc50c added VS test runner package for great justice 2014-12-18 12:07:40 +09:30
Brendan Forster
8f48f68fab upgrade to latest beta 2014-12-14 21:13:17 +09:30
Brendan Forster
74728283b6 remove xunit.extensions 2014-12-14 21:10:58 +09:30
Haacked
91811330d9 Upgrade Octokit's dependencies 2014-09-05 18:24:18 -07:00
Brendan Forster
f206478611 string formatting because lolwindows 2014-03-08 17:30:30 +11:00
Brendan Forster
5c662cdc80 throw a wobbly when you're doing overloads wrong 2014-03-08 17:18:04 +11:00
Brendan Forster
71a7f0c370 added better message for when parameters are different 2014-03-08 16:40:01 +11:00
Brendan Forster
0ec9953cb8 added better message for parameter mismatch count 2014-03-08 16:39:59 +11:00
Brendan Forster
235ac7d4f3 added exception for return value mismatch 2014-03-08 16:39:59 +11:00
Brendan Forster
87638fc41d throw more detailed exceptions for type not found and interface mismatches 2014-03-08 16:39:58 +11:00
Haacked
bbdb61b348 Revert "Update Rx to v2.2.2"
This reverts commit a12531ae43.
2014-02-19 20:59:13 -08:00
Paul Betts
a12531ae43 Update Rx to v2.2.2 2014-02-10 10:57:15 -08:00
lbargaoanu
d2aff11d5c check for DebuggerDisplay on models 2014-02-07 10:50:36 +02:00
lbargaoanu
9a46355085 new conventions tests project 2014-01-28 14:44:24 +02:00