* Introduce 'NoFramework' switch
This enables building via cake on linux without requiring adjustments on
other platforms, fixes#1745
* Revert hardcoding NoFramework in build.sh
* Skip GitVersion query for NoFramework build
This implies that NoFramework is intended for local use only
Accordingly a warning message has been set up in the Lifetime of the Build
* Rename NoFramework switch to CoreOnly
* Skip tool installation and formatting step for CoreOnly builds
* Default CoreOnly to false on windows and true otherwise
* Add CoreOnly switch to build variable output
* Fix 'native' msbuild on windows for both platforms
'native' msbuild invocations do not automatically set CoreOnly according to the platform
they are running on. As such we set CoreOnly to False on Windows, unless CoreOnly has been
specified already.
* Added authentication using bearer token.
* Added Installation and AccessToken clients.
* Added new clients to Reactive project
* added support for DateTime serialized as FileTime
* added support for StatusEventPayload
* added support for StatusEventPayload
* Added test for StatusEventPayload and fixed serializer to return that event payload type.
* WIP - added ApplicationClient and related Api Urls.
* Continued implementing Installations support.
* Fixing build (WIP)
* fixed build
* added Account property to Installation. prefer nameof(x) over literal "x".
* fixed according to code review.
* fixed build.
* switched Installation ID from int to long.
* added Permissions and Events properties to Installation.
* added documentation to Application and Installation properties in IGitHubClient.
* wip - added tests to new clients
* wip - fix build
* wip - fixed build.
* added InstallationsClient tests.
* added integration test for InstallationsClient.
* changes requested in code review.
* add Get method for App
* Create GitHubApp response model instead of re-using existing Application response model
* add Get method to observable client
* fixed build (both locally and failed test).
* Fixed documentation and added some missing XML docs.
* added DebuggerDisplay to StatusEventPayload
* updated XML docs and added some missing bits. prefer nameof(x) over literal "x".
* Add xml comments to AccessToken response model and use DateTimeOffset rather than DateTime
* Tidy up XmlComments and make consistent across client and observable client and interfaces
* fixup unit tests to independently verify preview header
* Implement GetInstallation method
* revert commits unrelated to GitHubApps - these can be done on a separate PR if required
* this extra authenticator class doesnt appear to be used anywhere
* undo project file change as it doesnt appear to be necessary
* Revert "Merge remote-tracking branch 'remote/GitHubApps' into GitHubApps"
This reverts commit c53cc110b8d807f62fdfeaa7df19e1532d050007, reversing
changes made to 0c9e413d420a4725738644ea5b13af6ec102d456.
* Revert "Revert "Merge remote-tracking branch 'remote/GitHubApps' into GitHubApps""
This reverts commit 02d52b8adf814b6945c60cb59a907a8cd34b1ce7.
* add XmlDoc comments to response models and flesh out installation permissions
* name AcceptHeaders member consistently
* accidentally lost changes to Credentials.cs
* Enhance Intergation test framework to handle GitHubApp settings and discoer tests appropriately
Get code ready for GitHubJWT nuget package but for now just hardcode a JWT in ENV VAR
Add 1 integration test for each method and ensure they are working!
* fixed compiler warnings.
* Added support for Installation=>Id field that arrives in a Pull Request Event payload.
(See the last field in the sample JSON of https://developer.github.com/v3/activity/events/types/#pullrequestevent)
* Change integration test project to netcoreapp2.0 so we can use GitHubJwt nuget package in integration tests
* First cut at some GitHubApp doco
* update mkdocs config
* Moved the Installation property to ActivityPayload, so it's available in all payloads.
This feature is not undocumented, unfortunately, but valid:
https://platform.github.community/t/determining-which-installation-an-event-came-from/539/11
* Split Installation to Installation and InstallationId, and added a comfort method for gaining its AccessToken.
* fixed InstallationId CreateAccessToken to receive IGitHubAppsClient. added (and fixed) docs.
* reverted object-oriented style comfort method and it's docs.
* update all test projects to netcoreapp2.0
* tweak build configs to use 2.0.3 SDK
* also need to update cake frosting build to netcoreapp2.0
* tweak docs some more
* fix convention test failures
* test projects still had some old runtime parts in them!
* travis osx image needs to be at least 10.12 for .NET Core 2.0
* shell script might need the same argument tweak for cake
* more doc tweaks
* Make sure compiler warning output isnt somehow causing Linux and OSX builds to fail
* moar logging for linux/OSX builds
* stop sourcelink on linux/OSX builds to see if that is the problem
* set verbosity to detailed for the dotnet build step
* try new sourcelink and list out remotes
* is travis being weird with git clone?
* SourceLink may be defaulting to true on CI server so explicitly set it as false rather than omitting it
* detailed is a bit too verbose for travis, try normal
* turn sourcelink back on for Linux/OSX
* fix compiler warning
* Try SourceLink.Create.CommandLine instead of SourceLink.Create.GitHub
* CliToolReferences did not update to latest versions
* remove debug origin info
* turn off msbuild output
* go back to SourceLink.Create.GitHub!
* time diff between dev PC and API causes issues if specifying a full 600 second token
* handle extra date format that Installation end point now returns
* field needs to be protected in order to be deserialized
* provide even more buffer for client vs server clock drift
* Update to latest GitHubJwt reference
* go back to SDK 1 since SDK 2 is having sporadic travisCI faliures in TestSourceLink build step
* get appveyor working
* update sourcelink back to latest, and use SDK 1.04 (runtime 1.0.5)
* Add Tls1.2 to allowed protocols, for earlier target frameworks where this wasnt already the default.
ServicePointManager class used to do this, is only available in the full framework, so a preprocessor constant needs to be used
* intergration tests net452 target wasn't setup
* Use OR Assignment operator, just for Haacked
* force the implicit netstandard package version to 1.6.0 to avoid automated update to 1.6.1 which prevents strict netcoreapp1.0 support (required in aws lambda)
* tidy up project files
* Use assembly version instead of hard-coded ones
Builds happening on AppVeyor specify the assembly version with `dotnet build /p:Version=<gitversion>`
* Set default version for dev time
This is to avoid that the default 1.0.0 version be assigned to the assemblies
* Move various package/assembly properties from AssemblyInfo into csproj files so dotnet build can set them all
* Get rid of SolutionInfo and move assembly version function into Connection class
* Rework FormatUserAgent to use InformationalVersion and guard against exceptions determining platform OS/arch (fixes#1617)
* Update assembly descriptions
* Reword dotnetcore to .NET Core
* Attempted workaround for package version dependency issue by specifying version on dotnet restore
see https://github.com/NuGet/Home/issues/4337
* Cross target Octokit.Tests against netcoreapp1.0 and net452
* Add net45-specific references
This fixes a build error after adding the net452 target:
error CS0656: Missing compiler required member 'Microsoft.CSharp.RuntimeBinder.CSharpArgumentInfo.Create'
* Add SimpleJson conditional compilation symbols for net45
* Disable AppDomain when running tests
Thanks to Dominick and Patrik: https://twitter.com/leastprivilege/status/893376624233762816
* Use nameof operator instead of magic strings
* Remove conditional compilation symbols as they are not used in the conventions tests project
* Enable cross targetting in the conventions tests project
* Run tests against netcoreapp1.0 only when not on Windows
* Going too fast bites you
* add sourcelink support
* Update sourcelink (2.0.2 -> 2.1.0)
* Add parameter to enable source linking
* tidy up the arguments with an extension method allowing an argument to be conditionally appended
* Add an explicit "test sourcelink" build task and remove the MSBuild one, so we can get some build script output without needing the whole build to be in verbose logging
* run sourcelink test against the NuGet packages
* convert to VS2017
* rework cake.frosting build to latest cake vs2017 "template" example
* fix clean task and version suffix
* add arg to DotNetCorePack so it uses the correct version
* fix appveyor
* is there an easier way to test appveyor?
* ok travis, let's do this
* after reading the travis repo, this seems to be the version we want for vs201/csproj tool support
* msbuild complaining about arguments - we can use defaults anyhow so remove $@ from build.sh script
* add workaround for msbuild/travis, as mentioned on aspnet Mvc repo
* cmon travis
* perhaps tee isnt needed afterall
* travis permission denied when trying to install tools in build script... i feel dirty but need to see if sudo will fix it!
* could it be folder permissions of /build ?
* Try 777 for NuGet.exe permissions rather than 644
* remove windows platform restriction on GitVersion call
* Add a wrapper script for GitVersion on non windows
* fix wrapper script name
* add debug
* let's see if we are running the script at all!
* run mono gitversion direclty from travis.yml, for science
* see if we can run bin/sh and prepend an argument to our shell script
* remove echos from wrapper script
* Ensure full git repo include more than 50 commits and all tags are fetched, as GitVersion was failing on TravisCI
* only build netstandard framework on non windows
* revert overriding the target framework when building the solution
* Unix being case-sensitive, adjust app.config file name in csproj files
* set FrameworkPathOverride to point to different folders on macOS and Linux
* Remove NuGet.exe from the repo.
On Windows, it will be installed by the Frosting bootstrapper script.
On Unix/macOS, cake has smarts to look for mono- and Linux-specific executables
* tidy up GitVersion logic into a GitVersionRunner class
* apply workaround for osx dotnet restore "too many open files" errors
* update test project references to latest official versions
* doesnt seem to be a reason for overriding the implicit reference
* remove extra whitespace and unused namespace
* Add some tests to be completed
* Actually fail the tests
* Create AbuseException class
Copied from ForbiddenException and then gone over to inherit from it.
* Actually add AbuseException to csproj
* Update test file
* Ran .\build FixProjects
* Test updates
* Default message update for AbuseException
* Separate the exception creation logic
* Remove message assertion -- doesn't matter here
* Additional test for abuse message
* Remove unnecessary variable assignment
* Failing test for unsafe request
* Attempt to fix test
Still broken -- I don't think empty strings count to trigger the default
message
* Remove test that will always fail due to another issue
Opened #1529 to explore this.
* New tests (some failing)
* Passing tests are, like, better than failing tests.
* Last passing test
* Cleanup
* Add test for zero value and fix code
Lol boundary cases.
* cleanup
* Mark ParseRetryAfterSeconds as static
* Add GetObjectData override to AbuseException
To include data for RetryAfterSeconds variable, and satisfy the build
check.
* Add back failing test & skip it
* Change to nullable int with null default
* Fix tests around nullable default
* whitespace fixes
* Compact the logic; tests still pass
* Invert the if statements for compactness / clarity
* Test subclasses & reformatting
* Test name changes
* Whitespace fix
* Remove redundant line
* [WIP]
* add new method to add assignees for an issue
* added new overloads
* added unit tests
* fixed missed overload calls
* fixed inconsistency in tests
* added integration tests
* fixed errors in tests
* fixed all remarks
* added new overloads
* added unit tests
* added integration tests
* fixed incorrect variable names
* added new overloads
* added unit tests
* added itegration tests
* fixed integration tests
* removed extra empty lines
* fixed errors in unit tests
* added overloads on IObservableReleasesClient and IReleasesClient
* added new unit tests
* added integration tests
* added Task as return value of unit tests
* added Task as return parameter
* added return value ReleasesClientTests
* another try to get tests work
* another one try
* undo prev commit
* fixed errors in tests
* removed extra ThrowsAsync checks
* added new overloads
* added unit tests
* added integration tests
* added integration tests
* Add ApiOptions overloads to IWatchedClient + tests.
* Add ApiOptions overloads to IObservableWatchedClient + tests.
* More tests.
* fixed error in ObservableWatchedClient
* added unit tests
* added integration tests
* added new overloads
* added unit tests
* added integration tests
* renamed "Ensures" methods to deliver more consistency in code
* fixed failed tests
* Add ApiOptions overloads to methods on I(Observable)IssuesLabelsClient (#1329)
* correcting a couple of tests (#1331)
* Add ApiOption overloads to methods on I(Observable)OrganizationsClient (#1324)
* Add ApiOptions overloads to methods on I(Observable)OrganizationMembersClient (#1332)
* fix description
* add new response for IssueAssignees
* add constructor for IssueAssignees
* add debugger display for NewAssignees
* add methods for observable assignees client; new unit tests
* add observable unit tests for add method
* place AddAssignees under IssueClient
* fix description
* [WIP] add generic delete method
* revert add assignees
* add assignees key under issue client
* remove IssueAssignees dependencies
* fix type IssueAssignees
* add remove method for issue assignees; finish generic delete method
* unit tests for remove assignees
* Add Assignees property to NewIssue and UpdateIssue requets
Add Asignees property to Issue response
Removed [SerializeNull] attribute from UpdateIssue.Assignee as this was causing it to remove assignee when none was specified
Add a couple of integration tests to prove Assignees are being deserialised
* rename NewAssignees to AssignessUpdate
* change Assignees key description
* check null Issue.ToUpdate method
* add accept header for IssuesClientTests
* Fix some more unit tests
* add integration test
Check if an assignee was added to an issue
* fix merge conflicts
* resolve conflicts
* implement some hints from @ryangribble
* resolve merge fixes
* clean up
* some more changes
* create new repo
Create a new repo for integrationtest
'CanRetrieveIssuesWithMultipleAssignees()'
* fix merge
* fix conflicts
* fix xml
* change test
* change delete overloads
* Fix tests
* fix xml
* Add helper function RemoveLabel
* Add helper function RemoveAssignee
* Format last commit
* Add integration tests to exercise new Assignees field on IssueUpdate
* GitHub API doesnt allow Assignee and Assignees properties to both be specified - API docs say that Assignee is deprecated so mark it [Obsolete] and dont populate it in Issue.ToUpdate()
* Add Assignees field to PullRequest response object, and integration tests to verify it is populated.
This field is not listed in the API docs but probing the API revealed it is included in payloads
* add a couple of extra tests to verify the IssueUpdate.Labels is working correctly
* Include assignees in ctor for consistency
* fix IssueUpdate test for new Assignees field
* Update IOrganizationsClient.cs
* Added the Uri for the organizations
Renamed the existing organizations uri to userOrganizations and created a new organizations uri.
* Implementation of the GetAllOrganizations
* Interface modification for the GetAllOrganizations
* Implementation of the GetAllOrganizations
* Created the tests for the two new methods
* remove new line
* Reverted the changes i did to the ApiUrls class to be backward compatible.
Created new client method and marked the old one [Obsolete] to be removed in a futur release.
Created a new request class to support the since attribute.
Updated the Unit Tests
Updated all the csproj to have the proper references.
* Renamed test
* Deprecated the Organizations method to be replaced by the new UserOrganizations method.
* Created 2 new test for the getAll method.
Renamed the existing one to make it clear they test the user organization.
* tweaks to integration tests
* Add response models
* Supress message
* correct spelling Timestamp
* implement traffic client
* add reactive client
* [WIP] unit tests
* add argument check
* finish unit tests
* add integration tests
* Change repositoryId from int to long
Remove GetAll naming of endpoints and add to PaginationTest exclusions
Rename View and Clone classes to be more specific
Add handling of TimeStamp fields being UtcUnix time
Add integration tests for repositoryId methods
* Code to test URL for an enterprise instance.
Based on code we use in GitHub Desktop for Windows.
* Add an example of the enterprise probe
* Add helpful constructor to EnterpriseProbe
* Suppress code analysis warning
Add xml comments to ctors and make consistent with GitHubClient/Connection etc
* Update getting started to use the new EnterpriseProbe ctor
* Add get method for required status checks
* Add api urls for required status checks
* change name of apir url for required status checks
* fix xml comment
* add update method for required status checks
* add delete method for required status checks
* fix api url
* fix xml comment
* add api url for required status cehcks contexts
* add get method for required status checks contexts
* add replace method for required status checks contexts
* add add method for required status checks contexts
* add new overload for delete method
* add delete method for required status checks contexts; fix overloads for delete
* add api url for restrictions
* add get method for restrictions
* add delete method for restrictions
* add api url for teams restrictions
* add get method for team restrictions; fix delete method restrictions
* fix overhead for get team restrictions
* fix httpmethod for update required status checks
* add set method for team restrictions
* add add method for team restrictions
* add delete method for team restrictions
* add api url for user restrictions
* add get method for user restrictions
* add set method for user restrictions
* add add method for user restrictions
* add delete method for user restrictions
* Add unit test; fix api urls
* Add ExcludeFromTest class
* add exclude attribute to methods
* Add attribute usage
* Add parameter to interface
* add observable unit tests
* rename excludefromtest
exclude all the tests for the new api endpoints because they broke the
pagination and syncobsverable tests.
* rename excludefromattribute
* refactor observable methods
* [WIP] Add integration tests
* finish integration test
* fix renamed branch protection restrictions
* add team and user collections
* rename set to update
* rename test methods
* optimize integration tests
* made some tidy ups
- fixup comment wording Edit => Replace
- remove spurious characters from description
- remove un-needed exclude attributes
* remove ForOrgRepo tests
* remove unused org contexts
* dispose contexts
* remove obsolete GetRedirect
* add clarifying comment to restriction methods
* Tidy up location of existing EditBranch tests
* Create RepositoryBranchesClient and move the GetBranch GetAllBranches and EditBranch methods to it, obsoleting the old ones
* Add tests for the new RepositoryBranchesClient (keeping old tests for RepositoriesClient around for now)
* Disable obsolete warning on reactive client temporarily
* Create observable repository branches client and move GetBranch, GetAllBranches, EditBranch methods to it, obsoleting the old ones
* Add tests for observable repository branches client, leave old tests in place for now
* Fix projects...
* Fix whitespace
* Implement Issue Timeline preview API
* Add DebuggerDisplay to response models
* Rename method
* Add Observable Issue Timeline client
* Add that missing property thing
* Add teh comments
* Added unit tests
* Fix method names
* Add missing event type enum and API preview accept header
* Add integration tests for async client
* Pass in API preview header
* Add observable integration tests
* Unbreak the broken tests...
* Remove unnecessary usings
* Add missing events
* Fix API URLs
* Add overloads for using repository Id instead of owner/repo and paging
* Add tests for repository id overloads
* Add paging tests
* I'm clearly a bit rusty about this test thing here...
* Missed a check for null argument
* Added missing XMLDocs
