Commit Graph

14 Commits

Author SHA1 Message Date
Mickaël Derriey
9c80b00e6f Merge master into dotnetcore (#1599)
* bugfix - PUT should have a payload for Mark as Read (#1579)

* bugfix - PUT should have a payload for Mark as Read

* also fix the Observable client test

* add integration tests for MarkRead methods

* Fixup MarkReadForRepository methods to specify a body in the PUT request

* Fix unit tests for regular and observable client

* helps if the new files are included in the test project :)

* Cloning ApiInfo object should work when some fields are null (#1580)

* Adjust ApiInfo.Clone() to work even if some elements (eg ETag) are null

* Remove c# 6 language feature and do it the old school way

* Add a test for cloning ApiInfo when some fields are null

* The 3 lists can never be null anyway so remove some un-needed statements

* Add test for null RateLimit

* Remove Rx-Main dependency from samples
This resolves #1592 - LINQPad doesn't understand how to restore this unlisted package and it's not actually needed in the samples.

* Adding RemovedFromProject and other missing EventInfoState types. (#1591)

* Adding missing review types to event info.

* Fixing whitespace.

* Reword `BaseRefChanged` comment

* Adding missing event types.

* Change response models 'Url' properties from `Uri` to `string` (#1585)

* Add convention test to ensure 'Url' properties are of type string

Closes #1582

* Change 'Url' properties from Uri to string

Global Find/Replace FTW!

* fix compilation errors in the integration tests project

* Extend 'Url' properties type check to request models

* Stick to convention tests naming convention

* Remove unused using directives in models

Changing from `Uri` to `string` means the `using System;`
directive was not needed anymore in some files

* Update exception message wording

* empty commit to trigger a new build - hopefully Travis passes

* add convention test to ensure request models have Uri 'Url' properties

* make request models 'Url' properties Uri

fix typo in convention test name

* revert some request models 'Url' properties as `string`

see https://github.com/octokit/octokit.net/pull/1585#issuecomment-297186728

* Change test so that all model types must have 'Url' properties of type string

 - Filter test input to only get types which have 'Url' properties
 - Merge response and request model types tests into one
 - Unparameterize the exception since we only check for the string type now

* Fix string.Format tokens

If this PR doesn't get rebased, it'll be my wall of shame FOREVER!

* and then it's even more embarrassing when the commit message says rebased but you really meant squashed

* Remove exclusion of `Release` from request models
2017-05-02 21:55:30 +10:00
Mickaël Derriey
13d5dab516 Port to .NET Core (#1503)
Port to .NET Core
2017-01-21 14:42:02 +10:00
Ryan Gribble
e3fa865381 add convention test to ensure all response models have a public parameterless ctor
2 model classes were missing one - technically not needed for these 2 classes due to their api calls being basic data types that then get populated into these objects, but it's easiest to just add them to these 2 classes so the test can pass on all response models
2016-07-05 23:32:40 +10:00
Alexander Efremov
494bbfda42 Method of assembly determination was changed in order to use types of top level (#1273) 2016-04-19 21:02:36 +10:00
Brendan Forster
740b70f3c7 moved test to new home 2016-02-14 16:56:34 +11:00
Kristian Hellang
7162ce6e72 Clarify why convention tests are failing 2015-09-22 10:54:02 +02:00
Haacked
4e09d71a73 Omit the IStatisticsClient from these convention tests
It doesn't follow the pattern of most of our other clients.
2015-08-07 16:37:54 -07:00
Henrik Andersson
b0ab485ed1 Add a convention test 2015-03-22 19:09:08 +10:00
Kristian Hellang
273ad8acdc Added test for readonly collections 2015-03-18 11:43:47 +01:00
Kristian Hellang
f497fa9f34 Renamed tests 2015-01-06 09:45:06 +01:00
Kristian Hellang
b088b3f544 Added asserts for DebuggerDisplay value and property 2015-01-06 08:52:09 +01:00
Kristian Hellang
574202a9ea Remember to unwrap generic types 2015-01-06 01:24:07 +01:00
Kristian Hellang
8cdf53d878 Walk the type dependency tree to find child models 2015-01-06 00:51:08 +01:00
Kristian Hellang
1fabaf4cc5 Implemented test to check for readonly properties 2015-01-05 23:41:11 +01:00