Commit Graph

8 Commits

Author SHA1 Message Date
Mickaël Derriey
9c80b00e6f Merge master into dotnetcore (#1599)
* bugfix - PUT should have a payload for Mark as Read (#1579)

* bugfix - PUT should have a payload for Mark as Read

* also fix the Observable client test

* add integration tests for MarkRead methods

* Fixup MarkReadForRepository methods to specify a body in the PUT request

* Fix unit tests for regular and observable client

* helps if the new files are included in the test project :)

* Cloning ApiInfo object should work when some fields are null (#1580)

* Adjust ApiInfo.Clone() to work even if some elements (eg ETag) are null

* Remove c# 6 language feature and do it the old school way

* Add a test for cloning ApiInfo when some fields are null

* The 3 lists can never be null anyway so remove some un-needed statements

* Add test for null RateLimit

* Remove Rx-Main dependency from samples
This resolves #1592 - LINQPad doesn't understand how to restore this unlisted package and it's not actually needed in the samples.

* Adding RemovedFromProject and other missing EventInfoState types. (#1591)

* Adding missing review types to event info.

* Fixing whitespace.

* Reword `BaseRefChanged` comment

* Adding missing event types.

* Change response models 'Url' properties from `Uri` to `string` (#1585)

* Add convention test to ensure 'Url' properties are of type string

Closes #1582

* Change 'Url' properties from Uri to string

Global Find/Replace FTW!

* fix compilation errors in the integration tests project

* Extend 'Url' properties type check to request models

* Stick to convention tests naming convention

* Remove unused using directives in models

Changing from `Uri` to `string` means the `using System;`
directive was not needed anymore in some files

* Update exception message wording

* empty commit to trigger a new build - hopefully Travis passes

* add convention test to ensure request models have Uri 'Url' properties

* make request models 'Url' properties Uri

fix typo in convention test name

* revert some request models 'Url' properties as `string`

see https://github.com/octokit/octokit.net/pull/1585#issuecomment-297186728

* Change test so that all model types must have 'Url' properties of type string

 - Filter test input to only get types which have 'Url' properties
 - Merge response and request model types tests into one
 - Unparameterize the exception since we only check for the string type now

* Fix string.Format tokens

If this PR doesn't get rebased, it'll be my wall of shame FOREVER!

* and then it's even more embarrassing when the commit message says rebased but you really meant squashed

* Remove exclusion of `Release` from request models
2017-05-02 21:55:30 +10:00
aedampir@gmail.com
7872493dad fixed unit test errors 2016-06-16 15:10:20 +07:00
aedampir@gmail.com
3446dd7abf added new unit tests 2016-06-16 14:57:57 +07:00
Alexander Efremov
029cefe76a Add ApiOptions overloads to methods on I(Observable)NotificationsClient (#1330) 2016-06-02 11:19:39 +02:00
aedampir@gmail.com
d0c8e82453 Red Tests were fixed
Unused 'using' directive were removed.
2016-04-18 12:46:13 +07:00
Dillon Buchanan
f45fc8e3ff Implementing the rest of the Notifications API 2014-10-14 10:40:26 -02:00
Haacked
1d64210ac5 Fix endpoint URLs for Enterprise support
Since Enterprise base URLs end with /api/v3 we need to make sure
the endpoints are relative and not absolute.
2013-10-29 16:02:00 -07:00
Haacked
a98b53a246 Add reactive notifications client 2013-10-19 17:10:00 -07:00