Commit Graph

17 Commits

Author SHA1 Message Date
Mickaël Derriey
9c80b00e6f Merge master into dotnetcore (#1599)
* bugfix - PUT should have a payload for Mark as Read (#1579)

* bugfix - PUT should have a payload for Mark as Read

* also fix the Observable client test

* add integration tests for MarkRead methods

* Fixup MarkReadForRepository methods to specify a body in the PUT request

* Fix unit tests for regular and observable client

* helps if the new files are included in the test project :)

* Cloning ApiInfo object should work when some fields are null (#1580)

* Adjust ApiInfo.Clone() to work even if some elements (eg ETag) are null

* Remove c# 6 language feature and do it the old school way

* Add a test for cloning ApiInfo when some fields are null

* The 3 lists can never be null anyway so remove some un-needed statements

* Add test for null RateLimit

* Remove Rx-Main dependency from samples
This resolves #1592 - LINQPad doesn't understand how to restore this unlisted package and it's not actually needed in the samples.

* Adding RemovedFromProject and other missing EventInfoState types. (#1591)

* Adding missing review types to event info.

* Fixing whitespace.

* Reword `BaseRefChanged` comment

* Adding missing event types.

* Change response models 'Url' properties from `Uri` to `string` (#1585)

* Add convention test to ensure 'Url' properties are of type string

Closes #1582

* Change 'Url' properties from Uri to string

Global Find/Replace FTW!

* fix compilation errors in the integration tests project

* Extend 'Url' properties type check to request models

* Stick to convention tests naming convention

* Remove unused using directives in models

Changing from `Uri` to `string` means the `using System;`
directive was not needed anymore in some files

* Update exception message wording

* empty commit to trigger a new build - hopefully Travis passes

* add convention test to ensure request models have Uri 'Url' properties

* make request models 'Url' properties Uri

fix typo in convention test name

* revert some request models 'Url' properties as `string`

see https://github.com/octokit/octokit.net/pull/1585#issuecomment-297186728

* Change test so that all model types must have 'Url' properties of type string

 - Filter test input to only get types which have 'Url' properties
 - Merge response and request model types tests into one
 - Unparameterize the exception since we only check for the string type now

* Fix string.Format tokens

If this PR doesn't get rebased, it'll be my wall of shame FOREVER!

* and then it's even more embarrassing when the commit message says rebased but you really meant squashed

* Remove exclusion of `Release` from request models
2017-05-02 21:55:30 +10:00
Andreia Gaita
9e958bf998 Make Repository Id a long, it's going to grow... 2016-09-15 02:15:11 +02:00
aedampir@gmail.com
44b0f4039d ID -> Id 2016-07-17 16:29:32 +07:00
aedampir@gmail.com
52b534a41c removed <returns> tags 2016-06-28 04:32:48 +07:00
Alexander Efremov
f43e202c0c cleared <returns> tags 2016-06-17 05:56:50 +07:00
aedampir@gmail.com
537c18e043 added new overloads 2016-06-16 14:35:00 +07:00
Alexander Efremov
029cefe76a Add ApiOptions overloads to methods on I(Observable)NotificationsClient (#1330) 2016-06-02 11:19:39 +02:00
Dillon Buchanan
f45fc8e3ff Implementing the rest of the Notifications API 2014-10-14 10:40:26 -02:00
Brendan Forster
7dc70a2192 💄 using statements, incorrect docs, deprecated Octokit.Response namespace 2014-03-08 16:33:46 +11:00
Haacked
c96b00650e Add comments to concrete types
We now have a build task that copies comments from interface to
implementation.
2013-12-11 14:22:39 -08:00
Peter MacNaughton
f46eabe69a Instatiate is not a word! Fixed typo
Also expanded the IGitDatabaseClient summary
2013-12-04 00:19:16 -07:00
Peter MacNaughton
3b7488c4da API client constructors documented 2013-12-02 22:09:04 -07:00
Brendan Forster
451eddc647 dropped a bunch of async/await usages
There's also some differences here between using IReadOnlyCollection and
IReadOnlyList. We should decide on one and be consistent
2013-10-31 10:35:24 +11:00
Haacked
f89c25a03b More integration tests for Issues and Milestones 2013-10-23 15:35:50 -07:00
Haacked
ad210cecc7 Implement IssuesClient and interface
This required updating our serialization strategy so we handle enums
better.
2013-10-23 14:46:19 -07:00
Haacked
a98b53a246 Add reactive notifications client 2013-10-19 17:10:00 -07:00
Paul Betts
f4e50c071a Initial hack at supporting Notifications API 2013-10-19 16:49:18 -07:00