Commit Graph

20 Commits

Author SHA1 Message Date
Mickaël Derriey
9c80b00e6f Merge master into dotnetcore (#1599)
* bugfix - PUT should have a payload for Mark as Read (#1579)

* bugfix - PUT should have a payload for Mark as Read

* also fix the Observable client test

* add integration tests for MarkRead methods

* Fixup MarkReadForRepository methods to specify a body in the PUT request

* Fix unit tests for regular and observable client

* helps if the new files are included in the test project :)

* Cloning ApiInfo object should work when some fields are null (#1580)

* Adjust ApiInfo.Clone() to work even if some elements (eg ETag) are null

* Remove c# 6 language feature and do it the old school way

* Add a test for cloning ApiInfo when some fields are null

* The 3 lists can never be null anyway so remove some un-needed statements

* Add test for null RateLimit

* Remove Rx-Main dependency from samples
This resolves #1592 - LINQPad doesn't understand how to restore this unlisted package and it's not actually needed in the samples.

* Adding RemovedFromProject and other missing EventInfoState types. (#1591)

* Adding missing review types to event info.

* Fixing whitespace.

* Reword `BaseRefChanged` comment

* Adding missing event types.

* Change response models 'Url' properties from `Uri` to `string` (#1585)

* Add convention test to ensure 'Url' properties are of type string

Closes #1582

* Change 'Url' properties from Uri to string

Global Find/Replace FTW!

* fix compilation errors in the integration tests project

* Extend 'Url' properties type check to request models

* Stick to convention tests naming convention

* Remove unused using directives in models

Changing from `Uri` to `string` means the `using System;`
directive was not needed anymore in some files

* Update exception message wording

* empty commit to trigger a new build - hopefully Travis passes

* add convention test to ensure request models have Uri 'Url' properties

* make request models 'Url' properties Uri

fix typo in convention test name

* revert some request models 'Url' properties as `string`

see https://github.com/octokit/octokit.net/pull/1585#issuecomment-297186728

* Change test so that all model types must have 'Url' properties of type string

 - Filter test input to only get types which have 'Url' properties
 - Merge response and request model types tests into one
 - Unparameterize the exception since we only check for the string type now

* Fix string.Format tokens

If this PR doesn't get rebased, it'll be my wall of shame FOREVER!

* and then it's even more embarrassing when the commit message says rebased but you really meant squashed

* Remove exclusion of `Release` from request models
2017-05-02 21:55:30 +10:00
Ryan Gribble
a936184cff response enums can be camelcase as underscores are removed in the deserializer 2017-03-16 06:42:54 +10:00
Ryan Gribble
31bfc5c730 Found another new event type! 2017-03-11 11:57:59 +10:00
Ryan Gribble
3a1e4b806f Fix failing tests by adding 2 new (undocumented) EventInfoState values 2017-03-11 11:32:54 +10:00
Linda Naughton
eeb98c7fcd Add Missing Event Types (#1536)
* Adding missing review types to event info.

* Fixing whitespace.

* Reword `BaseRefChanged` comment
2017-01-13 17:58:00 +10:00
Henrik Andersson
23d9310133 Implement Issue Timeline preview API (#1435)
* Implement Issue Timeline preview API

* Add DebuggerDisplay to response models

* Rename method

* Add Observable Issue Timeline client

* Add that missing property thing

* Add teh comments

* Added unit tests

* Fix method names

* Add missing event type enum and API preview accept header

* Add integration tests for async client

* Pass in API preview header

* Add observable integration tests

* Unbreak the broken tests...

* Remove unnecessary usings

* Add missing events

* Fix API URLs

* Add overloads for using repository Id instead of owner/repo and paging

* Add tests for repository id overloads

* Add paging tests

* I'm clearly a bit rusty about this test thing here...

* Missed a check for null argument

* Added missing XMLDocs
2016-08-08 07:51:07 +10:00
Mordechai Zuber
44304ca70b use string per recommended style 2015-12-16 21:23:36 +02:00
Haacked
694e09970b Remove extraneous commas 2015-08-04 21:20:09 -07:00
Haacked
eb5d14cfdc Organize usings and remove unused 2015-08-04 21:12:37 -07:00
Darren Camp
c6812d1c41 Fix for issue #738
Added Unsubscribed value to the EventInfoState enumeration
2015-03-12 08:37:44 +08:00
Jan Ove Skogheim
015ecb97de Revert 4d2bc143b3. The parameter attribute only works for serialization, not deserialization. 2015-02-25 20:32:26 +01:00
Jan Ove Skogheim
4d2bc143b3 Support the correct spelling (https://developer.github.com/v3/issues/events/) of event types. 2015-02-19 22:57:33 +01:00
Micah
c3a67ae777 Creates constructors for all Models.Response.
Resolves https://github.com/octokit/octokit.net/issues/677.

Removes obscolete properties (gravatar).
Makes Models.Response properties all be protected (most were already).
2015-01-24 16:07:03 -08:00
Kristian Hellang
21ca33817d Fixed failing tests 2015-01-06 00:27:16 +01:00
Dillon Buchanan
690bb77129 IssueEvent & EventInfo Field/Enum Updates
Fixes #642
2014-12-22 17:33:40 -05:00
Amy Palamountain
fa9c618302 Debugger display ++ 2014-02-19 21:43:35 +13:00
Kyle Nunery
f29901b695 Using existing User class instead of Actor class 2013-11-03 00:50:45 -05:00
Kyle Nunery
ea25d99676 Add missing xml comments 2013-11-03 00:50:44 -05:00
Kyle Nunery
4868b0e4f2 add event id to EventInfo model 2013-11-03 00:45:53 -05:00
Kyle Nunery
769be5bcbc Added Issue Events client interface and corresponding types 2013-11-03 00:45:52 -05:00