Commit Graph

11 Commits

Author SHA1 Message Date
Mickaël Derriey
9c80b00e6f Merge master into dotnetcore (#1599)
* bugfix - PUT should have a payload for Mark as Read (#1579)

* bugfix - PUT should have a payload for Mark as Read

* also fix the Observable client test

* add integration tests for MarkRead methods

* Fixup MarkReadForRepository methods to specify a body in the PUT request

* Fix unit tests for regular and observable client

* helps if the new files are included in the test project :)

* Cloning ApiInfo object should work when some fields are null (#1580)

* Adjust ApiInfo.Clone() to work even if some elements (eg ETag) are null

* Remove c# 6 language feature and do it the old school way

* Add a test for cloning ApiInfo when some fields are null

* The 3 lists can never be null anyway so remove some un-needed statements

* Add test for null RateLimit

* Remove Rx-Main dependency from samples
This resolves #1592 - LINQPad doesn't understand how to restore this unlisted package and it's not actually needed in the samples.

* Adding RemovedFromProject and other missing EventInfoState types. (#1591)

* Adding missing review types to event info.

* Fixing whitespace.

* Reword `BaseRefChanged` comment

* Adding missing event types.

* Change response models 'Url' properties from `Uri` to `string` (#1585)

* Add convention test to ensure 'Url' properties are of type string

Closes #1582

* Change 'Url' properties from Uri to string

Global Find/Replace FTW!

* fix compilation errors in the integration tests project

* Extend 'Url' properties type check to request models

* Stick to convention tests naming convention

* Remove unused using directives in models

Changing from `Uri` to `string` means the `using System;`
directive was not needed anymore in some files

* Update exception message wording

* empty commit to trigger a new build - hopefully Travis passes

* add convention test to ensure request models have Uri 'Url' properties

* make request models 'Url' properties Uri

fix typo in convention test name

* revert some request models 'Url' properties as `string`

see https://github.com/octokit/octokit.net/pull/1585#issuecomment-297186728

* Change test so that all model types must have 'Url' properties of type string

 - Filter test input to only get types which have 'Url' properties
 - Merge response and request model types tests into one
 - Unparameterize the exception since we only check for the string type now

* Fix string.Format tokens

If this PR doesn't get rebased, it'll be my wall of shame FOREVER!

* and then it's even more embarrassing when the commit message says rebased but you really meant squashed

* Remove exclusion of `Release` from request models
2017-05-02 21:55:30 +10:00
aedampir@gmail.com
695cf8e75b Unused "using" directives were removed in whole solution. 2016-03-25 13:38:07 +07:00
Ryan Gribble
6a0ef92a84 Rename LdapDn to LdapDistinguishedName and use [Parameter(Key = "ldap_dn")] to set the API field name 2016-02-17 22:55:11 +10:00
Ryan Gribble
e4eb1166b7 Due to api serialisation, must use LdapDn rather than LdapDN (the latter turns into ldap_d_n instead of ldap_dn)
Get rid of LdapTeam and LdapUser, the regular Team and User objects contain ldap_dn field if LDAP sync is enabled
2016-02-12 09:37:33 +10:00
Mordechai Zuber
44304ca70b use string per recommended style 2015-12-16 21:23:36 +02:00
Micah
c3a67ae777 Creates constructors for all Models.Response.
Resolves https://github.com/octokit/octokit.net/issues/677.

Removes obscolete properties (gravatar).
Makes Models.Response properties all be protected (most were already).
2015-01-24 16:07:03 -08:00
Kristian Hellang
21ca33817d Fixed failing tests 2015-01-06 00:27:16 +01:00
Amy Palamountain
cd5627c824 Bam! 2014-02-19 22:00:56 +13:00
Haroon
0e34b454c8 org not user 2013-11-08 17:10:55 +00:00
Haroon
53393054fc added more props 2013-11-07 10:08:29 +00:00
haroon
c44b18e947 prepping teams api client 2013-11-05 11:15:11 +00:00