* reworks all number parameter names to represent what they actually are. Refactors some types to be the appropriate types based on OpenAPI and docs.
* updates interfaces and implementations for id naming
* updates reactive to match sync SDKs
* add active lock reason to PR
* update docs
* refactor: extract lock and unlock from IIssuesClient
create ILockUnlockClient so both IIssuesClient and IPullRequestClient can
access lock and unlock methods.
* refactor LockUnlock for reactive clients
* Update doc to include lock unlock sample code
* Use Assert.Null to check null value in test
Co-authored-by: notauserx <notauserx@users.noreply.github.com>
* First Iteration Need to finish tests and docs
* Mostly Complete
* Fixing tests and adding review comments
* Added tests for reactive client
* Moved Reviews inside fo the Pull request client for better organization and began initial intigration testing
* Fixing bad recursive function breaking tests
* test fixes
* Add paging support to review comments call
* Fixing recursive function
* Addressing comments from PR
* fixing CI break
* Typo build break
* Fixing Convention Tests
* Adding correct nameof() usage in Ensure
* Small consitancy changes
* Trigger build
* Address PR Comments
* Fixup test naming
* Fix sub client ordering and incorrect URL
* Tidy up comments and remove StringEnum wrapper from Request models as it is only for Response models
* Rename GetReview to Get
* tweak debugger display
* Rework integration tests - implement the easy Get/GetAll ones first...
* Implement integration tests for Create method.
Move helpers to create PR/review into SetupHelper class
Fixed up review status enum to contain correct values
Tests for Approve/RequestChanges currently failing as a user cant approve/request changes on their own PR
* Implement secondary account settings for integration tests and a new [DualAccountTest] attribute for discovery when configured
Change integration test to create PR from the 2nd account, so the main test account is able to perform review actions on the PR
* Add integration tests for Delete, Dismiss and Submit methods
Fixed up API client implementation for delete (was looking for incorrect 201 http status)
Removed unnecessary await/async calls from client implementations that dont need to do anything with the result
* Attempting to add comments as part of a review revealed that we cant use the existing PullRequestReviewCommentCreate class as the API throws a validation error due to the CommitId field
These newer review APIs need a DraftPullRequestReviewComment (that doesnt have a commitId) instead
* add second test account user/password to configure-integration-tests script
* Add Pull Request Review Request API.
* Add Reactive Pull Request Review Request API.
* Add PullRequestReviewRequestClient tests.
* Add ObservablePullRequestReviewRequestClient tests.
* Fix sub-client property naming.
* Remove redundant model and update PullRequest model.
* Add repositoryId based methods and missing Observable documentation.
* Add missing parameter to PullRequest ctor.
* Add integration tests for PullRequestReviewRequest.
* Upgrade PullRequestReviewRequest integration tests.
* Add integration tests for repositoryId methods and fix url bug.
* Add missing unit tests and fix PR issues.
* Add pagination support for PullRequestReviewRequst.GetAll and tests for it.
* Revert changes on `PullRequestReviewCommentsClientTests.cs`
* Small upgrades - remove unused using and compress property to expression body.
* Revert use of expression body in property.
* Add pagination tests for PullRequestReviewRequest.GetAll.
* Change pagination tests to use 2 users.
* Correct class/file name
* Reword the integration test names for consistency
Move the plumbing to create reviews into CreateTheWorld to clean up the actual tests
* Fix DebuggerDisplay of requested reviewers
* fix reviewRequestToCreate parameter to be consistent
* obsolete comment and add ReviewComment
* obsolete PullRequest.Comment and change to ReviewComment
* update ObservablePullRequestClient and interface to use ReviewComment
* fixed formatting issues
have Comment return new ReviewComment
