Commit Graph

41 Commits

Author SHA1 Message Date
Travis Harris
ff9521ce3d Implement Review API for Pull Requests (#1648)
* First Iteration Need to finish tests and docs

* Mostly Complete

* Fixing tests and adding review comments

* Added tests for reactive client

* Moved Reviews inside fo the Pull request client for better organization and began initial intigration testing

* Fixing bad recursive function breaking tests

* test fixes

* Add paging support to review comments call

* Fixing recursive function

* Addressing comments from PR

* fixing CI break

* Typo build break

* Fixing Convention Tests

* Adding correct nameof() usage in Ensure

* Small consitancy changes

* Trigger build

* Address PR Comments

* Fixup test naming

* Fix sub client ordering and incorrect URL

* Tidy up comments and remove StringEnum wrapper from Request models as it is only for Response models

* Rename GetReview to Get

* tweak debugger display

* Rework integration tests - implement the easy Get/GetAll ones first...

* Implement integration tests for Create method.
Move helpers to create PR/review into SetupHelper class
Fixed up review status enum to contain correct values
Tests for Approve/RequestChanges currently failing as a user cant approve/request changes on their own PR

* Implement secondary account settings for integration tests and a new [DualAccountTest] attribute for discovery when configured
Change integration test to create PR from the 2nd account, so the main test account is able to perform review actions on the PR

* Add integration tests for Delete, Dismiss and Submit methods
Fixed up API client implementation for delete (was looking for incorrect 201 http status)
Removed unnecessary await/async calls from client implementations that dont need to do anything with the result

* Attempting to add comments as part of a review revealed that we cant use the existing PullRequestReviewCommentCreate class as the API throws a validation error due to the CommitId field
These newer review APIs need a DraftPullRequestReviewComment (that doesnt have a commitId) instead

* add second test account user/password to configure-integration-tests script
2017-08-16 20:50:25 +10:00
Ryan Gribble
9d8e8ae8af Remove obsolete items - SshKey
- SshKeysClient
- SshKey
- SshKeyInfo
- SshKeyUpdate
2016-07-16 22:46:42 +10:00
Ryan Gribble
2cc2ccda62 Remove obsolete items - GitHubClient
- Release
- Notification
- GitDatabase
2016-07-16 22:46:41 +10:00
lrz-hal
831ff1cf31 Add observable reactions client 2016-05-29 14:07:37 +02:00
Devesh Khandelwal
73d321da93 Refactor: Pull out Migrations client from Enterprise.
Following the API sidebar structure, the migrations client is pulled out
and put into another Migration client.
2016-05-20 19:10:22 +05:30
Ryan Gribble
09ebe007b7 Add unit test for ObservableMiscellaneousClient
Fix observable's constructor (obsoleting old constructor) to make it consistent with the other API clients
2016-04-03 22:20:02 +10:00
Ryan Gribble
e7187cbb0d Merge remote-tracking branch 'upstream/master' into enterprise-adminstats 2016-01-16 14:01:48 +10:00
Robert Pethick
bfb0e1bc88 Accidentally didn't push one file... 2016-01-04 17:41:15 +00:00
Robert Pethick
29f31e34bc Update ObservableGitHubClient and ObservableRepositoriesClient to match 2016-01-04 17:37:09 +00:00
Ryan Gribble
a2c8771ff4 Reactive - dont forget to Init the Enterprise client in GitHubClient ctor! 2015-12-27 01:35:13 +10:00
Ryan Gribble
dc1a03bc3a Add Enterprise to Reactive GitHubClient 2015-12-27 01:29:53 +10:00
Robert Pethick
ffc0b35608 Switch GitDatabase->Git on IGitHubProvider 2015-12-24 17:01:37 +00:00
Brendan Forster
80719c0033 aaaand format the code 2015-11-04 13:38:51 -08:00
Mark Taylor
b2c7e1c2a7 Chnage LastApiInfo to GetLastApiInfo with cloned version 2015-08-16 21:27:26 +01:00
Mark Taylor
f8ee4f94a1 WIP checkin for getting last ApiInfo object 2015-07-31 10:35:51 +01:00
Gabriel Weyer
f23ddf81f9 Finalized integration testing for review comments 2014-05-04 10:46:35 +10:00
Haacked
9e0fb886ca Implement observable oauth client
Rx will never die
2014-04-22 08:39:30 -07:00
Brendan Forster
705f0948d3 updated properties on IObservableGitHubClient 2014-02-18 10:52:02 +11:00
Brendan Forster
c6b0ea7357 renamed IObservableBlobClient to IObservableBlobsClient 2014-02-18 10:44:36 +11:00
Kristian Hellang
ae23a2ae7a Fixed minor namespace and whitespace issues 2013-12-01 23:42:04 +01:00
Kristian Hellang
c4f6c6d19d Added observable clients for gist and gist comments 2013-12-01 23:18:40 +01:00
pltaylor
a91104c3e9 Merge Master
Again.
2013-11-14 19:43:07 -05:00
pltaylor
59441ed030 Implement Observable Tree client and refactor names 2013-11-11 08:45:48 -05:00
pltaylor
16e20c51ba Add blob client to ObservableGithubClient 2013-11-06 19:44:00 -05:00
pltaylor
f8dfd4a582 Add way to get to ObservableEventsClient 2013-11-05 19:05:58 -05:00
John Nye
ede12b9e27 Create GitDatabaseClient and ObservableGitDatabaseClient 2013-11-01 22:10:48 +00:00
Perry Taylor
46e9a57443 I was concentrating on different white spaces.
And it was right in front of me:)
2013-10-30 21:39:35 -04:00
Perry Taylor
eac14ae72e Fix whitespaces 2013-10-30 21:34:17 -04:00
Perry Taylor
ff71007bf6 Add Simple constructors 2013-10-30 21:26:56 -04:00
Haacked
a98b53a246 Add reactive notifications client 2013-10-19 17:10:00 -07:00
Haacked
ad4be39ea3 Clean up the Octokit.Reactive namespaces
Fixes #84
2013-10-18 22:26:36 -07:00
Haacked
abde37c576 Flatten the observables for authorizations 2013-10-16 18:54:11 -07:00
Haacked
c446c79094 Flatten the observables for releases 2013-10-16 18:54:11 -07:00
Haacked
8b2e3d1944 Flatten the observables for SSH keys 2013-10-16 18:54:08 -07:00
Haacked
05255d7236 Flatten the observables for organizations 2013-10-16 18:54:07 -07:00
Haacked
04958410ea Flatten the observables for repositories 2013-10-16 18:54:06 -07:00
half-ogre
6f3fa81789 move internal stuff to .Internal namespace 2013-10-08 15:14:06 -07:00
Haacked
8ff4e4c603 Add Connection property to IObservableGitHubClient
Sometimes we need to be able to make raw requests. This
makes that easier.
2013-10-07 15:54:47 -07:00
Haacked
4e445093f7 Implement Miscellaneous Client emoji and markdown 2013-10-06 22:45:15 -07:00
Haacked
9a33c68dbc Make client property names consistent
Also added ObservableReleasesClient
2013-10-05 16:30:00 -07:00
Haacked
997e955f38 Rename to Octokit to be consistent with other API libs
GitHub is naming all of the libraries Octokit for their respective
platforms
2013-01-29 14:00:27 -08:00