mirror of
https://github.com/zoriya/octokit.net.git
synced 2026-06-07 12:26:18 +00:00
Miguel Ventura
36829cba3a
PullRequestCommit Author and Committer fields were mistakenly typed with Committer when they should be of type User. Previously the types of properties were: * `PullRequestCommit.Author/Committer`: `Committer` * `Commit.Author/Committer`: `Committer` Correct types should be: * `PullRequestCommit.Author/Committer`: `User` * `Commit.Author/Committer`: `Committer` These fields always fail to deserialize in the API calls but produce no errors, only objects with default values.
103 lines
4.4 KiB
C#
103 lines
4.4 KiB
C#
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using Octokit;
|
|
using Octokit.Internal;
|
|
using Xunit;
|
|
|
|
public class PullRequestCommitTests {
|
|
// the following JSON is taken from the documentation available at https://developer.github.com/v3/pulls/#list-commits-on-a-pull-request
|
|
|
|
const string jsonPayload = @"
|
|
[
|
|
{
|
|
""url"": ""https://api.github.com/repos/octocat/Hello-World/commits/6dcb09b5b57875f334f61aebed695e2e4193db5e"",
|
|
""sha"": ""6dcb09b5b57875f334f61aebed695e2e4193db5e"",
|
|
""node_id"": ""MDY6Q29tbWl0NmRjYjA5YjViNTc4NzVmMzM0ZjYxYWViZWQ2OTVlMmU0MTkzZGI1ZQ=="",
|
|
""html_url"": ""https://github.com/octocat/Hello-World/commit/6dcb09b5b57875f334f61aebed695e2e4193db5e"",
|
|
""comments_url"": ""https://api.github.com/repos/octocat/Hello-World/commits/6dcb09b5b57875f334f61aebed695e2e4193db5e/comments"",
|
|
""commit"": {
|
|
""url"": ""https://api.github.com/repos/octocat/Hello-World/git/commits/6dcb09b5b57875f334f61aebed695e2e4193db5e"",
|
|
""author"": {
|
|
""name"": ""Monalisa Octocat"",
|
|
""email"": ""support@github.com"",
|
|
""date"": ""2011-04-14T16:00:49Z""
|
|
},
|
|
""committer"": {
|
|
""name"": ""Monalisa Octocat"",
|
|
""email"": ""support@github.com"",
|
|
""date"": ""2011-04-14T16:00:49Z""
|
|
},
|
|
""message"": ""Fix all the bugs"",
|
|
""tree"": {
|
|
""url"": ""https://api.github.com/repos/octocat/Hello-World/tree/6dcb09b5b57875f334f61aebed695e2e4193db5e"",
|
|
""sha"": ""6dcb09b5b57875f334f61aebed695e2e4193db5e""
|
|
},
|
|
""comment_count"": 0,
|
|
""verification"": {
|
|
""verified"": false,
|
|
""reason"": ""unsigned"",
|
|
""signature"": null,
|
|
""payload"": null
|
|
}
|
|
},
|
|
""author"": {
|
|
""login"": ""octocat"",
|
|
""id"": 1,
|
|
""node_id"": ""MDQ6VXNlcjE="",
|
|
""avatar_url"": ""https://github.com/images/error/octocat_happy.gif"",
|
|
""gravatar_id"": """",
|
|
""url"": ""https://api.github.com/users/octocat"",
|
|
""html_url"": ""https://github.com/octocat"",
|
|
""followers_url"": ""https://api.github.com/users/octocat/followers"",
|
|
""following_url"": ""https://api.github.com/users/octocat/following{/other_user}"",
|
|
""gists_url"": ""https://api.github.com/users/octocat/gists{/gist_id}"",
|
|
""starred_url"": ""https://api.github.com/users/octocat/starred{/owner}{/repo}"",
|
|
""subscriptions_url"": ""https://api.github.com/users/octocat/subscriptions"",
|
|
""organizations_url"": ""https://api.github.com/users/octocat/orgs"",
|
|
""repos_url"": ""https://api.github.com/users/octocat/repos"",
|
|
""events_url"": ""https://api.github.com/users/octocat/events{/privacy}"",
|
|
""received_events_url"": ""https://api.github.com/users/octocat/received_events"",
|
|
""type"": ""User"",
|
|
""site_admin"": false
|
|
},
|
|
""committer"": {
|
|
""login"": ""octocat"",
|
|
""id"": 1,
|
|
""node_id"": ""MDQ6VXNlcjE="",
|
|
""avatar_url"": ""https://github.com/images/error/octocat_happy.gif"",
|
|
""gravatar_id"": """",
|
|
""url"": ""https://api.github.com/users/octocat"",
|
|
""html_url"": ""https://github.com/octocat"",
|
|
""followers_url"": ""https://api.github.com/users/octocat/followers"",
|
|
""following_url"": ""https://api.github.com/users/octocat/following{/other_user}"",
|
|
""gists_url"": ""https://api.github.com/users/octocat/gists{/gist_id}"",
|
|
""starred_url"": ""https://api.github.com/users/octocat/starred{/owner}{/repo}"",
|
|
""subscriptions_url"": ""https://api.github.com/users/octocat/subscriptions"",
|
|
""organizations_url"": ""https://api.github.com/users/octocat/orgs"",
|
|
""repos_url"": ""https://api.github.com/users/octocat/repos"",
|
|
""events_url"": ""https://api.github.com/users/octocat/events{/privacy}"",
|
|
""received_events_url"": ""https://api.github.com/users/octocat/received_events"",
|
|
""type"": ""User"",
|
|
""site_admin"": false
|
|
},
|
|
""parents"": [
|
|
{
|
|
""url"": ""https://api.github.com/repos/octocat/Hello-World/commits/6dcb09b5b57875f334f61aebed695e2e4193db5e"",
|
|
""sha"": ""6dcb09b5b57875f334f61aebed695e2e4193db5e""
|
|
}
|
|
]
|
|
}
|
|
]
|
|
";
|
|
|
|
[Fact]
|
|
public void AuthorAndCommitterDeserializedCorrectly() {
|
|
var serializer = new SimpleJsonSerializer();
|
|
var commits = serializer.Deserialize<List<PullRequestCommit>>(jsonPayload);
|
|
|
|
Assert.Equal("octocat", commits.Single().Author.Login);
|
|
Assert.Equal("support@github.com", commits.Single().Commit.Author.Email);
|
|
}
|
|
|
|
}
|