mirror of
https://github.com/zoriya/octokit.net.git
synced 2025-12-05 23:06:10 +00:00
* Added StringEnum<TEnum> * Added tests * Make sure the serializer can work with StringEnum * Use StringEnum for EventInfo.Event * Add convention test to assert that all Response models use StringEnum<> to wrap enum properties * Add Stringnum<> to all response types failing convention test * Handle StringEnum to Enum conversion when Issue response model populates IssueUpdate request model * Fix unit test * Refactor SimpleJsonSerializer to expose the DeserializeEnum strategy so it can be used in StringEnum class * Need to expose/use SerializeEnum functionality too, so we use the correct string representation of enum values that have custom properties (eg ReactionType Plus1 to "+1") * fix unit tests, since the string is now the "correct" upstream api value * Add a couple of tests for the Enum serialize/deserialize when underscores, hyphens and custom property attributes are present * Compare parsed values for equality * add convention test to ensure enum members all have Parameter property set * update test to cover implicit conversions too * this test should work but fails at the moment due to magic hyphen removal in deserializer causing a one way trip from utf-8 to EncodingType.Utf8 with no way to get back * (unsuccesfully) expand event info test to try to catch more cases of unknown event types * fix broken integration test while im here * Fixed build errors after .NET Core merge * Value -> StringValue, ParsedValue -> Value * Don't allow StringValue to be null * Ignore enums not used in request/response models * Added ParameterAttribute to almost all enum values * Ignore Language enum * Fix failing tests * Fix milestone sort parameter and tests * whitespace * fix milestone unit tests * Fix StringEnum.Equals ... This could've been embarrassing! * Change SimpleJsonSerializer Enum handling to only use `[Parameter()]` attributes (no more magic removal of hyphen/underscores from strings) * Tidy up this integration test while im here * Only test request/response enums in convention test * Keep skipping Language * Remove unused method * Remove excluded enum types * Removed unnecessary ParameterAttributes * Remove unused enum * Add StringEnum test for string-comparison of two invalid values * Bring back IssueCommentSort and use it in IssueCommentRequest This reverts commit 38a4a291d1476ef8c992fe0f76956974b6f32a49. * Use assembly instead of namespace for Octokit check * Add failing test to reproduce the issue where only the first enum paramter/value was added to the cache * Fix deserializer enum cache to include all enum members rather than only the first member encountered * Use a static SimpleJsonSerializer in StringEnum * Remove serializer instance in StringEnum * Add some documentation on StringEnum<TEnum> * Fix parameter value to resolve failing integration test
200 lines
8.9 KiB
C#
200 lines
8.9 KiB
C#
using System;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using Octokit.Tests.Integration.Helpers;
|
|
using Xunit;
|
|
|
|
namespace Octokit.Tests.Integration.Clients
|
|
{
|
|
public class IssueTimelineClientTests : IDisposable
|
|
{
|
|
private readonly IIssueTimelineClient _issueTimelineClient;
|
|
private readonly IIssuesClient _issuesClient;
|
|
private readonly RepositoryContext _context;
|
|
|
|
public IssueTimelineClientTests()
|
|
{
|
|
var github = Helper.GetAuthenticatedClient();
|
|
|
|
_issueTimelineClient = github.Issue.Timeline;
|
|
_issuesClient = github.Issue;
|
|
|
|
var repoName = Helper.MakeNameWithTimestamp("public-repo");
|
|
|
|
_context = github.CreateRepositoryContext(new NewRepository(repoName)).Result;
|
|
}
|
|
|
|
[IntegrationTest]
|
|
public async Task CanRetrieveTimelineForIssue()
|
|
{
|
|
var timelineEventInfos = await _issueTimelineClient.GetAllForIssue("octokit", "octokit.net", 1503);
|
|
Assert.NotEmpty(timelineEventInfos);
|
|
Assert.NotEqual(0, timelineEventInfos.Count);
|
|
}
|
|
|
|
[IntegrationTest]
|
|
public async Task CanRetrieveTimelineForIssueWithApiOptions()
|
|
{
|
|
var timelineEventInfos = await _issueTimelineClient.GetAllForIssue("octokit", "octokit.net", 1503);
|
|
Assert.NotEmpty(timelineEventInfos);
|
|
Assert.NotEqual(1, timelineEventInfos.Count);
|
|
|
|
var pageOptions = new ApiOptions
|
|
{
|
|
PageSize = 1,
|
|
PageCount = 1,
|
|
StartPage = 1
|
|
};
|
|
|
|
timelineEventInfos = await _issueTimelineClient.GetAllForIssue("octokit", "octokit.net", 1503, pageOptions);
|
|
Assert.NotEmpty(timelineEventInfos);
|
|
Assert.Equal(1, timelineEventInfos.Count);
|
|
}
|
|
|
|
[IntegrationTest]
|
|
public async Task CanRetrieveTimelineForRecentIssues()
|
|
{
|
|
// Make sure we can deserialize the event timeline for recent closed PRs and open Issues in a heavy activity repository (microsoft/vscode)
|
|
|
|
// Search request
|
|
var github = Helper.GetAuthenticatedClient();
|
|
var search = new SearchIssuesRequest
|
|
{
|
|
PerPage = 20,
|
|
Page = 1
|
|
};
|
|
search.Repos.Add("dotnet", "roslyn");
|
|
|
|
// 20 most recent closed PRs
|
|
search.Type = IssueTypeQualifier.PullRequest;
|
|
search.State = ItemState.Closed;
|
|
var pullRequestResults = await github.Search.SearchIssues(search);
|
|
foreach (var pullRequest in pullRequestResults.Items)
|
|
{
|
|
var timelineEventInfos = await _issueTimelineClient.GetAllForIssue("microsoft", "vscode", pullRequest.Number);
|
|
|
|
// Ensure we dont have any errors parsing the Event enums
|
|
var enumValues = timelineEventInfos.Select(x => x.Event.Value).ToList();
|
|
}
|
|
|
|
// 20 most recent open PRs
|
|
search.Type = IssueTypeQualifier.PullRequest;
|
|
search.State = ItemState.Open;
|
|
var openPullRequestResults = await github.Search.SearchIssues(search);
|
|
foreach (var pullRequest in openPullRequestResults.Items)
|
|
{
|
|
var timelineEventInfos = await _issueTimelineClient.GetAllForIssue("microsoft", "vscode", pullRequest.Number);
|
|
|
|
// Ensure we dont have any errors parsing the Event enums
|
|
var enumValues = timelineEventInfos.Select(x => x.Event.Value).ToList();
|
|
}
|
|
|
|
// 20 most recent closed Issues
|
|
search.Type = IssueTypeQualifier.Issue;
|
|
search.State = ItemState.Closed;
|
|
var issueResults = await github.Search.SearchIssues(search);
|
|
foreach (var issue in issueResults.Items)
|
|
{
|
|
var timelineEventInfos = await _issueTimelineClient.GetAllForIssue("microsoft", "vscode", issue.Number);
|
|
|
|
// Ensure we dont have any errors parsing the Event enums
|
|
var enumValues = timelineEventInfos.Select(x => x.Event.Value).ToList();
|
|
}
|
|
|
|
// 20 most recent open Issues
|
|
search.Type = IssueTypeQualifier.Issue;
|
|
search.State = ItemState.Open;
|
|
var openIssueResults = await github.Search.SearchIssues(search);
|
|
foreach (var issue in issueResults.Items)
|
|
{
|
|
var timelineEventInfos = await _issueTimelineClient.GetAllForIssue("microsoft", "vscode", issue.Number);
|
|
|
|
// Ensure we dont have any errors parsing the Event enums
|
|
var enumValues = timelineEventInfos.Select(x => x.Event.Value).ToList();
|
|
}
|
|
}
|
|
|
|
[IntegrationTest]
|
|
public async Task CanDeserializeRenameEvent()
|
|
{
|
|
var newIssue = new NewIssue("a test issue") { Body = "A new unassigned issue" };
|
|
var issue = await _issuesClient.Create(_context.RepositoryOwner, _context.RepositoryName, newIssue);
|
|
|
|
var renamed = await _issuesClient.Update(_context.Repository.Id, issue.Number, new IssueUpdate { Title = "A test issue" });
|
|
Assert.NotNull(renamed);
|
|
Assert.Equal("A test issue", renamed.Title);
|
|
|
|
var timelineEventInfos = await _issueTimelineClient.GetAllForIssue(_context.RepositoryOwner, _context.RepositoryName, issue.Number);
|
|
Assert.Equal(1, timelineEventInfos.Count);
|
|
Assert.Equal("a test issue", timelineEventInfos[0].Rename.From);
|
|
Assert.Equal("A test issue", timelineEventInfos[0].Rename.To);
|
|
}
|
|
|
|
[IntegrationTest]
|
|
public async Task CanDeserializeCrossReferenceEvent()
|
|
{
|
|
var newIssue = new NewIssue("a test issue") { Body = "A new unassigned issue" };
|
|
var issue = await _issuesClient.Create(_context.RepositoryOwner, _context.RepositoryName, newIssue);
|
|
|
|
newIssue = new NewIssue("another test issue") { Body = "Another new unassigned issue referencing the first new issue in #" + issue.Number };
|
|
var anotherNewIssue = await _issuesClient.Create(_context.Repository.Id, newIssue);
|
|
|
|
var timelineEventInfos = await _issueTimelineClient.GetAllForIssue(_context.RepositoryOwner, _context.RepositoryName, issue.Number);
|
|
Assert.Equal(1, timelineEventInfos.Count);
|
|
Assert.Equal(anotherNewIssue.Id, timelineEventInfos[0].Source.Issue.Id);
|
|
}
|
|
|
|
[IntegrationTest]
|
|
public async Task CanRetrieveTimelineForIssueByRepositoryId()
|
|
{
|
|
var newIssue = new NewIssue("a test issue") { Body = "A new unassigned issue" };
|
|
var issue = await _issuesClient.Create(_context.Repository.Id, newIssue);
|
|
|
|
var timelineEventInfos = await _issueTimelineClient.GetAllForIssue(_context.Repository.Id, issue.Number);
|
|
Assert.Empty(timelineEventInfos);
|
|
|
|
var closed = await _issuesClient.Update(_context.Repository.Id, issue.Number, new IssueUpdate() { State = ItemState.Closed });
|
|
Assert.NotNull(closed);
|
|
|
|
timelineEventInfos = await _issueTimelineClient.GetAllForIssue(_context.Repository.Id, issue.Number);
|
|
Assert.Equal(1, timelineEventInfos.Count);
|
|
Assert.Equal(EventInfoState.Closed, timelineEventInfos[0].Event);
|
|
}
|
|
|
|
[IntegrationTest]
|
|
public async Task CanDeserializeRenameEventByRepositoryId()
|
|
{
|
|
var newIssue = new NewIssue("a test issue") { Body = "A new unassigned issue" };
|
|
var issue = await _issuesClient.Create(_context.Repository.Id, newIssue);
|
|
|
|
var renamed = await _issuesClient.Update(_context.Repository.Id, issue.Number, new IssueUpdate { Title = "A test issue" });
|
|
Assert.NotNull(renamed);
|
|
Assert.Equal("A test issue", renamed.Title);
|
|
|
|
var timelineEventInfos = await _issueTimelineClient.GetAllForIssue(_context.Repository.Id, issue.Number);
|
|
Assert.Equal(1, timelineEventInfos.Count);
|
|
Assert.Equal("a test issue", timelineEventInfos[0].Rename.From);
|
|
Assert.Equal("A test issue", timelineEventInfos[0].Rename.To);
|
|
}
|
|
|
|
[IntegrationTest]
|
|
public async Task CanDeserializeCrossReferenceEventByRepositoryId()
|
|
{
|
|
var newIssue = new NewIssue("a test issue") { Body = "A new unassigned issue" };
|
|
var issue = await _issuesClient.Create(_context.Repository.Id, newIssue);
|
|
|
|
newIssue = new NewIssue("another test issue") { Body = "Another new unassigned issue referencing the first new issue in #" + issue.Number };
|
|
var anotherNewIssue = await _issuesClient.Create(_context.Repository.Id, newIssue);
|
|
|
|
var timelineEventInfos = await _issueTimelineClient.GetAllForIssue(_context.Repository.Id, issue.Number);
|
|
Assert.Equal(1, timelineEventInfos.Count);
|
|
Assert.Equal(anotherNewIssue.Id, timelineEventInfos[0].Source.Issue.Id);
|
|
}
|
|
|
|
public void Dispose()
|
|
{
|
|
_context.Dispose();
|
|
}
|
|
}
|
|
}
|