Files
octokit.net/Octokit.Tests.Integration/Clients/MilestonesClientTests.cs
Kristian Hellang 5ee4d64046 Add StringEnum to handle unknown enum values returned from API (#1595)
* Added StringEnum<TEnum>

* Added tests

* Make sure the serializer can work with StringEnum

* Use StringEnum for EventInfo.Event

* Add convention test to assert that all Response models use StringEnum<> to wrap enum properties

* Add Stringnum<> to all response types failing convention test

* Handle StringEnum to Enum conversion when Issue response model populates IssueUpdate request model

* Fix unit test

* Refactor SimpleJsonSerializer to expose the DeserializeEnum strategy so it can be used in StringEnum class

* Need to expose/use SerializeEnum functionality too, so we use the correct string representation of enum values that have custom properties (eg ReactionType Plus1 to "+1")

* fix unit tests, since the string is now the "correct" upstream api value

* Add a couple of tests for the Enum serialize/deserialize when underscores, hyphens and custom property attributes are present

* Compare parsed values for equality

* add convention test to ensure enum members all have Parameter property set

* update test to cover implicit conversions too

* this test should work but fails at the moment due to magic hyphen removal in deserializer causing a one way trip from utf-8 to EncodingType.Utf8 with no way to get back

* (unsuccesfully) expand event info test to try to catch more cases of unknown event types

* fix broken integration test while im here

* Fixed build errors after .NET Core merge

* Value -> StringValue, ParsedValue -> Value

* Don't allow StringValue to be null

* Ignore enums not used in request/response models

* Added ParameterAttribute to almost all enum values

* Ignore Language enum

* Fix failing tests

* Fix milestone sort parameter and tests

* whitespace

* fix milestone unit tests

* Fix StringEnum.Equals ... This could've been embarrassing!

* Change SimpleJsonSerializer Enum handling to only use `[Parameter()]` attributes (no more magic removal of hyphen/underscores from strings)

* Tidy up this integration test while im here

* Only test request/response enums in convention test

* Keep skipping Language

* Remove unused method

* Remove excluded enum types

* Removed unnecessary ParameterAttributes

* Remove unused enum

* Add StringEnum test for string-comparison of two invalid values

* Bring back IssueCommentSort and use it in IssueCommentRequest

This reverts commit 38a4a291d1476ef8c992fe0f76956974b6f32a49.

* Use assembly instead of namespace for Octokit check

* Add failing test to reproduce the issue where only the first enum paramter/value was added to the cache

* Fix deserializer enum cache to include all enum members rather than only the first member encountered

* Use a static SimpleJsonSerializer in StringEnum

* Remove serializer instance in StringEnum

* Add some documentation on StringEnum<TEnum>

* Fix parameter value to resolve failing integration test
2017-06-25 19:29:57 +10:00

532 lines
25 KiB
C#

using System;
using System.Threading.Tasks;
using Octokit;
using Octokit.Tests.Integration;
using Xunit;
using Octokit.Tests.Integration.Helpers;
public class MilestonesClientTests : IDisposable
{
private readonly IMilestonesClient _milestonesClient;
private readonly RepositoryContext _context;
public MilestonesClientTests()
{
var github = Helper.GetAuthenticatedClient();
_milestonesClient = github.Issue.Milestone;
var repoName = Helper.MakeNameWithTimestamp("public-repo");
_context = github.CreateRepositoryContext(new NewRepository(repoName)).Result;
}
[IntegrationTest]
public async Task CanRetrieveOneMilestone()
{
var newMilestone = new NewMilestone("a milestone") { DueOn = DateTime.Now };
var created = await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, newMilestone);
var result = await _milestonesClient.Get(_context.RepositoryOwner, _context.RepositoryName, created.Number);
Assert.Equal("a milestone", result.Title);
}
[IntegrationTest]
public async Task CanRetrieveOneMilestoneWithRepositoryId()
{
var newMilestone = new NewMilestone("a milestone") { DueOn = DateTime.Now };
var created = await _milestonesClient.Create(_context.Repository.Id, newMilestone);
var result = await _milestonesClient.Get(_context.Repository.Id, created.Number);
Assert.Equal("a milestone", result.Title);
}
[IntegrationTest]
public async Task CanDeleteOneMilestone()
{
var newMilestone = new NewMilestone("a milestone") { DueOn = DateTime.Now };
var created = await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, newMilestone);
var milestone = await _milestonesClient.Get(_context.RepositoryOwner, _context.RepositoryName, created.Number);
Assert.Equal("a milestone", milestone.Title);
await _milestonesClient.Delete(_context.RepositoryOwner, _context.RepositoryName, created.Number);
await Assert.ThrowsAsync<NotFoundException>(() => _milestonesClient.Get(_context.RepositoryOwner, _context.RepositoryName, created.Number));
}
[IntegrationTest]
public async Task CanDeleteOneMilestoneWithRepositoryId()
{
var newMilestone = new NewMilestone("a milestone") { DueOn = DateTime.Now };
var created = await _milestonesClient.Create(_context.Repository.Id, newMilestone);
var milestone = await _milestonesClient.Get(_context.Repository.Id, created.Number);
Assert.Equal("a milestone", milestone.Title);
await _milestonesClient.Delete(_context.Repository.Id, created.Number);
await Assert.ThrowsAsync<NotFoundException>(() => _milestonesClient.Get(_context.Repository.Id, created.Number));
}
[IntegrationTest]
public async Task CanUpdateOneMilestone()
{
var newMilestone = new NewMilestone("a milestone") { DueOn = DateTime.Now };
var created = await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, newMilestone);
var result1 = await _milestonesClient.Get(_context.RepositoryOwner, _context.RepositoryName, created.Number);
Assert.Equal("a milestone", result1.Title);
await _milestonesClient.Update(_context.RepositoryOwner, _context.RepositoryName, created.Number, new MilestoneUpdate { Title = "New title" });
var result2 = await _milestonesClient.Get(_context.RepositoryOwner, _context.RepositoryName, created.Number);
Assert.Equal("New title", result2.Title);
}
[IntegrationTest]
public async Task CanUpdateOneMilestoneWithRepositoryId()
{
var newMilestone = new NewMilestone("a milestone") { DueOn = DateTime.Now };
var created = await _milestonesClient.Create(_context.Repository.Id, newMilestone);
var result1 = await _milestonesClient.Get(_context.Repository.Id, created.Number);
Assert.Equal("a milestone", result1.Title);
await _milestonesClient.Update(_context.Repository.Id, created.Number, new MilestoneUpdate { Title = "New title" });
var result2 = await _milestonesClient.Get(_context.Repository.Id, created.Number);
Assert.Equal("New title", result2.Title);
}
[IntegrationTest]
public async Task CanListEmptyMilestones()
{
var milestones = await _milestonesClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName);
Assert.Empty(milestones);
}
[IntegrationTest]
public async Task CanListEmptyMilestonesWithRepositoryId()
{
var milestones = await _milestonesClient.GetAllForRepository(_context.Repository.Id);
Assert.Empty(milestones);
}
[IntegrationTest]
public async Task CanListMilestonesWithDefaultSortByDueDateAsc()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1) };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
var milestones = await _milestonesClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName);
Assert.Equal(2, milestones.Count);
Assert.Equal("milestone 1", milestones[0].Title);
Assert.Equal("milestone 2", milestones[1].Title);
}
[IntegrationTest]
public async Task CanListMilestonesWithDefaultSortByDueDateAscWithRepositoryId()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1) };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
await _milestonesClient.Create(_context.Repository.Id, milestone1);
await _milestonesClient.Create(_context.Repository.Id, milestone2);
await _milestonesClient.Create(_context.Repository.Id, milestone3);
var milestones = await _milestonesClient.GetAllForRepository(_context.Repository.Id);
Assert.Equal(2, milestones.Count);
Assert.Equal("milestone 1", milestones[0].Title);
Assert.Equal("milestone 2", milestones[1].Title);
}
[IntegrationTest]
public async Task CanListMilestonesWithSortByDueDateDesc()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1) };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
var milestones = await _milestonesClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName,
new MilestoneRequest { SortProperty = MilestoneSort.DueDate, SortDirection = SortDirection.Descending });
Assert.Equal(2, milestones.Count);
Assert.Equal("milestone 2", milestones[0].Title);
Assert.Equal("milestone 1", milestones[1].Title);
}
[IntegrationTest]
public async Task CanListMilestonesWithSortByDueDateDescWithRepositoryId()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1) };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
await _milestonesClient.Create(_context.Repository.Id, milestone1);
await _milestonesClient.Create(_context.Repository.Id, milestone2);
await _milestonesClient.Create(_context.Repository.Id, milestone3);
var milestones = await _milestonesClient.GetAllForRepository(_context.Repository.Id,
new MilestoneRequest { SortProperty = MilestoneSort.DueDate, SortDirection = SortDirection.Descending });
Assert.Equal(2, milestones.Count);
Assert.Equal("milestone 2", milestones[0].Title);
Assert.Equal("milestone 1", milestones[1].Title);
}
[IntegrationTest]
public async Task CanListClosedMilestones()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1) };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
var milestones = await _milestonesClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName,
new MilestoneRequest { State = ItemStateFilter.Closed });
Assert.Equal(1, milestones.Count);
Assert.Equal("milestone 3", milestones[0].Title);
}
[IntegrationTest]
public async Task CanListClosedMilestonesWithRepositoryId()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1) };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
await _milestonesClient.Create(_context.Repository.Id, milestone1);
await _milestonesClient.Create(_context.Repository.Id, milestone2);
await _milestonesClient.Create(_context.Repository.Id, milestone3);
var milestones = await _milestonesClient.GetAllForRepository(_context.Repository.Id,
new MilestoneRequest { State = ItemStateFilter.Closed });
Assert.Equal(1, milestones.Count);
Assert.Equal("milestone 3", milestones[0].Title);
}
[IntegrationTest]
public async Task ReturnsCorrectCountOfMilestonesWithoutStart()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1) };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3) };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
var options = new ApiOptions
{
PageSize = 3,
PageCount = 1
};
var milestones = await _milestonesClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName, options);
Assert.Equal(3, milestones.Count);
}
[IntegrationTest]
public async Task ReturnsCorrectCountOfMilestonesWithoutStartWithRepositoryId()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1) };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3) };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
var options = new ApiOptions
{
PageSize = 3,
PageCount = 1
};
var milestones = await _milestonesClient.GetAllForRepository(_context.Repository.Id, options);
Assert.Equal(3, milestones.Count);
}
[IntegrationTest]
public async Task ReturnsCorrectCountOfMilestonesWithStart()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1) };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3) };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
var options = new ApiOptions
{
PageSize = 2,
PageCount = 1,
StartPage = 2
};
var milestones = await _milestonesClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName, options);
Assert.Equal(1, milestones.Count);
}
[IntegrationTest]
public async Task ReturnsCorrectCountOfMilestonesWithStartWithRepositoryId()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1) };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3) };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
var options = new ApiOptions
{
PageSize = 2,
PageCount = 1,
StartPage = 2
};
var milestones = await _milestonesClient.GetAllForRepository(_context.Repository.Id, options);
Assert.Equal(1, milestones.Count);
}
[IntegrationTest]
public async Task ReturnsDistinctResultsBasedOnStartPage()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1) };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
var startOptions = new ApiOptions
{
PageSize = 1,
PageCount = 1
};
var firstPage = await _milestonesClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName, startOptions);
var skipStartOptions = new ApiOptions
{
PageSize = 1,
PageCount = 1,
StartPage = 2
};
var secondPage = await _milestonesClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName, skipStartOptions);
Assert.NotEqual(firstPage[0].Number, secondPage[0].Number);
}
[IntegrationTest]
public async Task ReturnsDistinctResultsBasedOnStartPageWithRepositoryId()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1) };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
var startOptions = new ApiOptions
{
PageSize = 1,
PageCount = 1
};
var firstPage = await _milestonesClient.GetAllForRepository(_context.Repository.Id, startOptions);
var skipStartOptions = new ApiOptions
{
PageSize = 1,
PageCount = 1,
StartPage = 2
};
var secondPage = await _milestonesClient.GetAllForRepository(_context.Repository.Id, skipStartOptions);
Assert.NotEqual(firstPage[0].Number, secondPage[0].Number);
}
[IntegrationTest]
public async Task ReturnsCorrectCountOfMilestonesWithoutStartParametrized()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1), State = ItemState.Closed };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
var milestone4 = new NewMilestone("milestone 4") { DueOn = DateTime.Now.AddDays(4), State = ItemState.Closed };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone4);
var options = new ApiOptions
{
PageSize = 3,
PageCount = 1
};
var milestones = await _milestonesClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName, new MilestoneRequest { State = ItemStateFilter.Closed }, options);
Assert.Equal(3, milestones.Count);
}
[IntegrationTest]
public async Task ReturnsCorrectCountOfMilestonesWithoutStartParametrizedWithRepositoryId()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1), State = ItemState.Closed };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
var milestone4 = new NewMilestone("milestone 4") { DueOn = DateTime.Now.AddDays(4), State = ItemState.Closed };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone4);
var options = new ApiOptions
{
PageSize = 3,
PageCount = 1
};
var milestones = await _milestonesClient.GetAllForRepository(_context.Repository.Id, new MilestoneRequest { State = ItemStateFilter.Closed }, options);
Assert.Equal(3, milestones.Count);
}
[IntegrationTest]
public async Task ReturnsCorrectCountOfMilestonesWithStartParametrized()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1), State = ItemState.Closed };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
var milestone4 = new NewMilestone("milestone 4") { DueOn = DateTime.Now.AddDays(4), State = ItemState.Closed };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone4);
var options = new ApiOptions
{
PageSize = 2,
PageCount = 1,
StartPage = 2
};
var milestones = await _milestonesClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName, new MilestoneRequest { State = ItemStateFilter.Closed }, options);
Assert.Equal(1, milestones.Count);
}
[IntegrationTest]
public async Task ReturnsCorrectCountOfMilestonesWithStartParametrizedWithRepositoryId()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1), State = ItemState.Closed };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
var milestone4 = new NewMilestone("milestone 4") { DueOn = DateTime.Now.AddDays(4), State = ItemState.Closed };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone4);
var options = new ApiOptions
{
PageSize = 2,
PageCount = 1,
StartPage = 2
};
var milestones = await _milestonesClient.GetAllForRepository(_context.Repository.Id, new MilestoneRequest { State = ItemStateFilter.Closed }, options);
Assert.Equal(1, milestones.Count);
}
[IntegrationTest]
public async Task ReturnsDistinctResultsBasedOnStartPageParametrized()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1), State = ItemState.Closed };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
var milestoneRequest = new MilestoneRequest { State = ItemStateFilter.Closed };
var startOptions = new ApiOptions
{
PageSize = 1,
PageCount = 1
};
var firstPage = await _milestonesClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName, milestoneRequest, startOptions);
var skipStartOptions = new ApiOptions
{
PageSize = 1,
PageCount = 1,
StartPage = 2
};
var secondPage = await _milestonesClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName, milestoneRequest, skipStartOptions);
Assert.NotEqual(firstPage[0].Number, secondPage[0].Number);
}
[IntegrationTest]
public async Task ReturnsDistinctResultsBasedOnStartPageParametrizedWithRepositoryId()
{
var milestone1 = new NewMilestone("milestone 1") { DueOn = DateTime.Now };
var milestone2 = new NewMilestone("milestone 2") { DueOn = DateTime.Now.AddDays(1), State = ItemState.Closed };
var milestone3 = new NewMilestone("milestone 3") { DueOn = DateTime.Now.AddDays(3), State = ItemState.Closed };
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone1);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone2);
await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, milestone3);
var milestoneRequest = new MilestoneRequest { State = ItemStateFilter.Closed };
var startOptions = new ApiOptions
{
PageSize = 1,
PageCount = 1
};
var firstPage = await _milestonesClient.GetAllForRepository(_context.Repository.Id, milestoneRequest, startOptions);
var skipStartOptions = new ApiOptions
{
PageSize = 1,
PageCount = 1,
StartPage = 2
};
var secondPage = await _milestonesClient.GetAllForRepository(_context.Repository.Id, milestoneRequest, skipStartOptions);
Assert.NotEqual(firstPage[0].Number, secondPage[0].Number);
}
public void Dispose()
{
_context.Dispose();
}
}