mirror of
https://github.com/zoriya/octokit.net.git
synced 2025-12-05 23:06:10 +00:00
* Added StringEnum<TEnum> * Added tests * Make sure the serializer can work with StringEnum * Use StringEnum for EventInfo.Event * Add convention test to assert that all Response models use StringEnum<> to wrap enum properties * Add Stringnum<> to all response types failing convention test * Handle StringEnum to Enum conversion when Issue response model populates IssueUpdate request model * Fix unit test * Refactor SimpleJsonSerializer to expose the DeserializeEnum strategy so it can be used in StringEnum class * Need to expose/use SerializeEnum functionality too, so we use the correct string representation of enum values that have custom properties (eg ReactionType Plus1 to "+1") * fix unit tests, since the string is now the "correct" upstream api value * Add a couple of tests for the Enum serialize/deserialize when underscores, hyphens and custom property attributes are present * Compare parsed values for equality * add convention test to ensure enum members all have Parameter property set * update test to cover implicit conversions too * this test should work but fails at the moment due to magic hyphen removal in deserializer causing a one way trip from utf-8 to EncodingType.Utf8 with no way to get back * (unsuccesfully) expand event info test to try to catch more cases of unknown event types * fix broken integration test while im here * Fixed build errors after .NET Core merge * Value -> StringValue, ParsedValue -> Value * Don't allow StringValue to be null * Ignore enums not used in request/response models * Added ParameterAttribute to almost all enum values * Ignore Language enum * Fix failing tests * Fix milestone sort parameter and tests * whitespace * fix milestone unit tests * Fix StringEnum.Equals ... This could've been embarrassing! * Change SimpleJsonSerializer Enum handling to only use `[Parameter()]` attributes (no more magic removal of hyphen/underscores from strings) * Tidy up this integration test while im here * Only test request/response enums in convention test * Keep skipping Language * Remove unused method * Remove excluded enum types * Removed unnecessary ParameterAttributes * Remove unused enum * Add StringEnum test for string-comparison of two invalid values * Bring back IssueCommentSort and use it in IssueCommentRequest This reverts commit 38a4a291d1476ef8c992fe0f76956974b6f32a49. * Use assembly instead of namespace for Octokit check * Add failing test to reproduce the issue where only the first enum paramter/value was added to the cache * Fix deserializer enum cache to include all enum members rather than only the first member encountered * Use a static SimpleJsonSerializer in StringEnum * Remove serializer instance in StringEnum * Add some documentation on StringEnum<TEnum> * Fix parameter value to resolve failing integration test
129 lines
3.8 KiB
C#
129 lines
3.8 KiB
C#
using System;
|
|
using System.Diagnostics;
|
|
using System.Globalization;
|
|
using Octokit.Internal;
|
|
|
|
namespace Octokit
|
|
{
|
|
[DebuggerDisplay("{DebuggerDisplay,nq}")]
|
|
public class PullRequestReviewComment
|
|
{
|
|
public PullRequestReviewComment() { }
|
|
|
|
public PullRequestReviewComment(int id)
|
|
{
|
|
Id = id;
|
|
}
|
|
|
|
public PullRequestReviewComment(string url, int id, string diffHunk, string path, int? position, int? originalPosition, string commitId, string originalCommitId, User user, string body, DateTimeOffset createdAt, DateTimeOffset updatedAt, string htmlUrl, string pullRequestUrl)
|
|
{
|
|
Url = url;
|
|
Id = id;
|
|
DiffHunk = diffHunk;
|
|
Path = path;
|
|
Position = position;
|
|
OriginalPosition = originalPosition;
|
|
CommitId = commitId;
|
|
OriginalCommitId = originalCommitId;
|
|
User = user;
|
|
Body = body;
|
|
CreatedAt = createdAt;
|
|
UpdatedAt = updatedAt;
|
|
HtmlUrl = htmlUrl;
|
|
PullRequestUrl = pullRequestUrl;
|
|
}
|
|
|
|
/// <summary>
|
|
/// URL of the comment via the API.
|
|
/// </summary>
|
|
public string Url { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The comment Id.
|
|
/// </summary>
|
|
public int Id { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The diff hunk the comment is about.
|
|
/// </summary>
|
|
public string DiffHunk { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The relative path of the file the comment is about.
|
|
/// </summary>
|
|
public string Path { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The line index in the diff.
|
|
/// </summary>
|
|
public int? Position { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The comment original position.
|
|
/// </summary>
|
|
public int? OriginalPosition { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The commit Id the comment is associated with.
|
|
/// </summary>
|
|
public string CommitId { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The original commit Id the comment is associated with.
|
|
/// </summary>
|
|
public string OriginalCommitId { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The user that created the comment.
|
|
/// </summary>
|
|
public User User { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The text of the comment.
|
|
/// </summary>
|
|
public string Body { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The date the comment was created.
|
|
/// </summary>
|
|
public DateTimeOffset CreatedAt { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The date the comment was last updated.
|
|
/// </summary>
|
|
public DateTimeOffset UpdatedAt { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The URL for this comment on Github.com
|
|
/// </summary>
|
|
public string HtmlUrl { get; protected set; }
|
|
|
|
/// <summary>
|
|
/// The URL for the pull request via the API.
|
|
/// </summary>
|
|
public string PullRequestUrl { get; protected set; }
|
|
|
|
public ReactionSummary Reactions { get; protected set; }
|
|
|
|
internal string DebuggerDisplay
|
|
{
|
|
get { return string.Format(CultureInfo.InvariantCulture, "Id: {0}, Path: {1}, User: {2}, Url: {3}", Id, Path, User.DebuggerDisplay, Url); }
|
|
}
|
|
}
|
|
|
|
public enum PullRequestReviewCommentSort
|
|
{
|
|
/// <summary>
|
|
/// Sort by create date (default)
|
|
/// </summary>
|
|
[Parameter(Value = "created")]
|
|
Created,
|
|
|
|
/// <summary>
|
|
/// Sort by the date of the last update
|
|
/// </summary>
|
|
[Parameter(Value = "updated")]
|
|
Updated
|
|
}
|
|
}
|