mirror of
https://github.com/zoriya/octokit.net.git
synced 2025-12-05 23:06:10 +00:00
* First Iteration Need to finish tests and docs * Mostly Complete * Fixing tests and adding review comments * Added tests for reactive client * Moved Reviews inside fo the Pull request client for better organization and began initial intigration testing * Fixing bad recursive function breaking tests * test fixes * Add paging support to review comments call * Fixing recursive function * Addressing comments from PR * fixing CI break * Typo build break * Fixing Convention Tests * Adding correct nameof() usage in Ensure * Small consitancy changes * Trigger build * Address PR Comments * Fixup test naming * Fix sub client ordering and incorrect URL * Tidy up comments and remove StringEnum wrapper from Request models as it is only for Response models * Rename GetReview to Get * tweak debugger display * Rework integration tests - implement the easy Get/GetAll ones first... * Implement integration tests for Create method. Move helpers to create PR/review into SetupHelper class Fixed up review status enum to contain correct values Tests for Approve/RequestChanges currently failing as a user cant approve/request changes on their own PR * Implement secondary account settings for integration tests and a new [DualAccountTest] attribute for discovery when configured Change integration test to create PR from the 2nd account, so the main test account is able to perform review actions on the PR * Add integration tests for Delete, Dismiss and Submit methods Fixed up API client implementation for delete (was looking for incorrect 201 http status) Removed unnecessary await/async calls from client implementations that dont need to do anything with the result * Attempting to add comments as part of a review revealed that we cant use the existing PullRequestReviewCommentCreate class as the API throws a validation error due to the CommitId field These newer review APIs need a DraftPullRequestReviewComment (that doesnt have a commitId) instead * add second test account user/password to configure-integration-tests script
165 lines
4.6 KiB
C#
165 lines
4.6 KiB
C#
using System;
|
|
using System.Diagnostics;
|
|
using System.Diagnostics.CodeAnalysis;
|
|
using System.Globalization;
|
|
using Octokit.Internal;
|
|
|
|
namespace Octokit
|
|
{
|
|
[DebuggerDisplay("{DebuggerDisplay,nq}")]
|
|
[SuppressMessage("Microsoft.Naming", "CA1711:IdentifiersShouldNotHaveIncorrectSuffix")]
|
|
public struct StringEnum<TEnum> : IEquatable<StringEnum<TEnum>>
|
|
where TEnum : struct
|
|
{
|
|
private readonly string _stringValue;
|
|
|
|
private TEnum? _parsedValue;
|
|
|
|
public StringEnum(TEnum parsedValue)
|
|
{
|
|
if (!Enum.IsDefined(typeof(TEnum), parsedValue))
|
|
{
|
|
throw GetArgumentException(parsedValue.ToString());
|
|
}
|
|
|
|
// Use the SimpleJsonSerializer to serialize the TEnum into the correct string according to the GitHub Api strategy
|
|
_stringValue = SimpleJsonSerializer.SerializeEnum(parsedValue as Enum);
|
|
_parsedValue = parsedValue;
|
|
}
|
|
|
|
public StringEnum(string stringValue)
|
|
{
|
|
_stringValue = stringValue ?? string.Empty;
|
|
_parsedValue = null;
|
|
}
|
|
|
|
public string StringValue
|
|
{
|
|
get { return _stringValue; }
|
|
}
|
|
|
|
public TEnum Value
|
|
{
|
|
get { return _parsedValue ?? (_parsedValue = ParseValue()).Value; }
|
|
}
|
|
|
|
internal string DebuggerDisplay
|
|
{
|
|
get
|
|
{
|
|
TEnum value;
|
|
if (TryParse(out value))
|
|
{
|
|
return value.ToString();
|
|
}
|
|
|
|
return StringValue;
|
|
}
|
|
}
|
|
|
|
public bool TryParse(out TEnum value)
|
|
{
|
|
if (_parsedValue.HasValue)
|
|
{
|
|
// the value has been parsed already.
|
|
value = _parsedValue.Value;
|
|
return true;
|
|
}
|
|
|
|
if (string.IsNullOrEmpty(StringValue))
|
|
{
|
|
value = default(TEnum);
|
|
return false;
|
|
}
|
|
|
|
try
|
|
{
|
|
// Use the SimpleJsonSerializer to parse the string to Enum according to the GitHub Api strategy
|
|
value = (TEnum)SimpleJsonSerializer.DeserializeEnum(StringValue, typeof(TEnum));
|
|
|
|
// cache the parsed value for subsequent calls.
|
|
_parsedValue = value;
|
|
return true;
|
|
}
|
|
catch (ArgumentException)
|
|
{
|
|
value = default(TEnum);
|
|
return false;
|
|
}
|
|
}
|
|
|
|
public bool Equals(StringEnum<TEnum> other)
|
|
{
|
|
TEnum value;
|
|
TEnum otherValue;
|
|
if (TryParse(out value) && other.TryParse(out otherValue))
|
|
{
|
|
// if we're able to parse both values, compare the parsed enum
|
|
return value.Equals(otherValue);
|
|
}
|
|
|
|
// otherwise, we fall back to a case-insensitive comparison of the string values.
|
|
return string.Equals(StringValue, other.StringValue, StringComparison.OrdinalIgnoreCase);
|
|
}
|
|
|
|
public override bool Equals(object obj)
|
|
{
|
|
if (ReferenceEquals(null, obj))
|
|
{
|
|
return false;
|
|
}
|
|
|
|
return obj is StringEnum<TEnum> && Equals((StringEnum<TEnum>) obj);
|
|
}
|
|
|
|
public override int GetHashCode()
|
|
{
|
|
return StringComparer.OrdinalIgnoreCase.GetHashCode(StringValue);
|
|
}
|
|
|
|
public static bool operator ==(StringEnum<TEnum> left, StringEnum<TEnum> right)
|
|
{
|
|
return left.Equals(right);
|
|
}
|
|
|
|
public static bool operator !=(StringEnum<TEnum> left, StringEnum<TEnum> right)
|
|
{
|
|
return !left.Equals(right);
|
|
}
|
|
|
|
public static implicit operator StringEnum<TEnum>(string value)
|
|
{
|
|
return new StringEnum<TEnum>(value);
|
|
}
|
|
|
|
public static implicit operator StringEnum<TEnum>(TEnum parsedValue)
|
|
{
|
|
return new StringEnum<TEnum>(parsedValue);
|
|
}
|
|
|
|
public override string ToString()
|
|
{
|
|
return StringValue;
|
|
}
|
|
|
|
private TEnum ParseValue()
|
|
{
|
|
TEnum value;
|
|
if (TryParse(out value))
|
|
{
|
|
return value;
|
|
}
|
|
|
|
throw GetArgumentException(StringValue);
|
|
}
|
|
|
|
private static ArgumentException GetArgumentException(string value)
|
|
{
|
|
return new ArgumentException(string.Format(
|
|
CultureInfo.InvariantCulture,
|
|
"Value '{0}' is not a valid '{1}' enum value.",
|
|
value,
|
|
typeof(TEnum).Name));
|
|
}
|
|
}
|
|
} |