zoriya/react-native-svg
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-svg.git synced 2025-12-06 07:06:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: client rect on use element (#2513)

Browse Source 
# Summary

Use elements had incorrect `clientRect` based on templates' rect, which
was incorrect. With this change, it ensures client rect is based on path
transformed by CTM.

## Test Plan

Example app -> Filters -> FeComposite

## Compatibility

| OS      | Implemented |
| ------- | :---------: |
| Android |    ✅      |
This commit is contained in:
Jakub Grzywacz
2024-10-28 13:45:52 +01:00
committed by GitHub
parent 8e865a9bdb
commit 36ca5c4584
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
android/src/main/java/com/horcrux/svg/UseView.java
View File

@@ -13,6 +13,7 @@ import android.graphics.Canvas;
import android.graphics.Matrix; import android.graphics.Matrix;
import android.graphics.Paint; import android.graphics.Paint;
import android.graphics.Path; import android.graphics.Path;
import android.graphics.RectF;
import com.facebook.common.logging.FLog; import com.facebook.common.logging.FLog;
import com.facebook.react.bridge.Dynamic; import com.facebook.react.bridge.Dynamic;
import com.facebook.react.bridge.ReactContext; import com.facebook.react.bridge.ReactContext;
@@ -86,7 +87,11 @@ class UseView extends RenderableView {
template.draw(canvas, paint, opacity * mOpacity); template.draw(canvas, paint, opacity * mOpacity);
} }
this.setClientRect(template.getClientRect()); // TODO: replace getMatrix with mCTM when it will be fixed
RectF clientRect = new RectF();
this.getPath(canvas, paint).computeBounds(clientRect, true);
canvas.getMatrix().mapRect(clientRect);
this.setClientRect(clientRect);
template.restoreCanvas(canvas, count); template.restoreCanvas(canvas, count);
if (template instanceof RenderableView) { if (template instanceof RenderableView) {