zoriya/react-native-svg
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-svg.git synced 2026-06-06 08:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor pushNodeAndFont repeated code into static setIfExists method.

Browse Source
This commit is contained in:
Mikael Sand
2017-07-23 04:39:39 +03:00
parent 904b4096ef
commit 45b47fe119
1 changed files with 13 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/src/main/java/com/horcrux/svg/GlyphContext.java
+13 -25
View File
@@ -179,6 +179,14 @@ class GlyphContext {
} }
} }
private static void setIfExists(String key, WritableMap map, ReadableMap font, ReadableMap parent) {
if (font.hasKey(key)) {
map.putString(key, font.getString(key));
} else if (parent.hasKey(key)) {
map.putString(key, parent.getString(key));
}
}
private void pushNodeAndFont(GroupShadowNode node, @Nullable ReadableMap font) { private void pushNodeAndFont(GroupShadowNode node, @Nullable ReadableMap font) {
ReadableMap parent = getTopOrParentFont(node); ReadableMap parent = getTopOrParentFont(node);
mTop++; mTop++;
@@ -192,35 +200,15 @@ class GlyphContext {
mFontContext.add(map); mFontContext.add(map);
topFont = map; topFont = map;
if (font.hasKey(LETTER_SPACING)) { setIfExists(LETTER_SPACING, map, font, parent);
map.putString(LETTER_SPACING, font.getString(LETTER_SPACING));
} else if (parent.hasKey(LETTER_SPACING)) {
map.putString(LETTER_SPACING, parent.getString(LETTER_SPACING));
}
if (font.hasKey(FONT_FAMILY)) { setIfExists(FONT_FAMILY, map, font, parent);
map.putString(FONT_FAMILY, font.getString(FONT_FAMILY));
} else if (parent.hasKey(FONT_FAMILY)) {
map.putString(FONT_FAMILY, parent.getString(FONT_FAMILY));
}
if (font.hasKey(FONT_WEIGHT)) { setIfExists(FONT_WEIGHT, map, font, parent);
map.putString(FONT_WEIGHT, font.getString(FONT_WEIGHT));
} else if (parent.hasKey(FONT_WEIGHT)) {
map.putString(FONT_WEIGHT, parent.getString(FONT_WEIGHT));
}
if (font.hasKey(FONT_STYLE)) { setIfExists(FONT_STYLE, map, font, parent);
map.putString(FONT_STYLE, font.getString(FONT_STYLE));
} else if (parent.hasKey(FONT_STYLE)) {
map.putString(FONT_STYLE, parent.getString(FONT_STYLE));
}
if (font.hasKey(KERNING)) { setIfExists(KERNING, map, font, parent);
map.putString(KERNING, font.getString(KERNING));
} else if (parent.hasKey(KERNING)) {
map.putString(KERNING, parent.getString(KERNING));
}
float parentFontSize = (float) parent.getDouble(FONT_SIZE); float parentFontSize = (float) parent.getDouble(FONT_SIZE);