[android] Simplify SvgPackage

This commit is contained in:
Mikael Sand
2018-10-15 02:23:45 +03:00
parent a4e4b2af7c
commit 585e34bea9
5 changed files with 484 additions and 463 deletions
@@ -70,7 +70,6 @@ abstract public class RenderableView extends VirtualView {
private Paint.Cap mStrokeLinecap = Paint.Cap.ROUND;
private Paint.Join mStrokeLinejoin = Paint.Join.ROUND;
private @Nullable ReadableArray mFill;
private float mFillOpacity = 1;
private Path.FillType mFillRule = Path.FillType.WINDING;
@@ -300,7 +299,7 @@ abstract public class RenderableView extends VirtualView {
resultCanvas.drawBitmap(original, 0, 0, null);
resultCanvas.drawBitmap(maskBitmap, 0, 0, maskPaint);
// Render blended result into current render context
// Render composited result into current render context
canvas.drawBitmap(result, 0, 0, paint);
} else {
draw(canvas, paint, opacity);
File diff suppressed because it is too large Load Diff
@@ -19,30 +19,31 @@ import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import static com.horcrux.svg.RenderableViewManager.*;
public class SvgPackage implements ReactPackage {
@Override
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
return Arrays.<ViewManager>asList(
RenderableViewManager.createGroupViewManager(),
RenderableViewManager.createPathViewManager(),
RenderableViewManager.createCircleViewManager(),
RenderableViewManager.createEllipseViewManager(),
RenderableViewManager.createLineViewManager(),
RenderableViewManager.createRectViewManager(),
RenderableViewManager.createTextViewManager(),
RenderableViewManager.createTSpanViewManager(),
RenderableViewManager.createTextPathViewManager(),
RenderableViewManager.createImageViewManager(),
RenderableViewManager.createClipPathViewManager(),
RenderableViewManager.createDefsViewManager(),
RenderableViewManager.createUseViewManager(),
RenderableViewManager.createSymbolManager(),
RenderableViewManager.createLinearGradientManager(),
RenderableViewManager.createRadialGradientManager(),
RenderableViewManager.createPatternManager(),
RenderableViewManager.createMaskManager(),
new GroupViewManager(),
new PathViewManager(),
new CircleViewManager(),
new EllipseViewManager(),
new LineViewManager(),
new RectViewManager(),
new TextViewManager(),
new TSpanViewManager(),
new TextPathViewManager(),
new ImageViewManager(),
new ClipPathViewManager(),
new DefsViewManager(),
new UseViewManager(),
new SymbolManager(),
new LinearGradientManager(),
new RadialGradientManager(),
new PatternManager(),
new MaskManager(),
new SvgViewManager());
}
@@ -70,7 +70,7 @@ public class SvgView extends ReactViewGroup implements ReactCompoundView, ReactC
@Override
public void setId(int id) {
super.setId(id);
SvgViewManager.setSvgView(this);
SvgViewManager.setSvgView(id, this);
}
@Override
@@ -28,8 +28,8 @@ class SvgViewManager extends ReactViewManager {
private static final SparseArray<SvgView> mTagToSvgView = new SparseArray<>();
static void setSvgView(SvgView svg) {
mTagToSvgView.put(svg.getId(), svg);
static void setSvgView(int tag, SvgView svg) {
mTagToSvgView.put(tag, svg);
}
static @Nullable SvgView getSvgViewByTag(int tag) {