From 6377be5f2027ed67612364c7e3057d6c429ae810 Mon Sep 17 00:00:00 2001
From: Jakub Grzywacz <jakub.grzywacz@swmansion.com>
Date: Tue, 7 Jan 2025 14:43:58 +0100
Subject: [PATCH] fix: remove package from AndroidManifest.xml (#2600)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

# Summary

Fixes #2599

Starting with `v15.8.0`, we support `react-native@0.73+`, which
eliminates the need to worry about AGP versions below 7. Consequently,
the `package` attribute in `AndroidManifest.xml` can be safely removed,
along with the corresponding check in `build.gradle`.

## Test Plan

Build the app on all supported versions

## Compatibility

| OS      | Implemented |
| ------- | :---------: |
| Android |    ✅      |
---
 android/build.gradle                 | 4 +---
 android/src/main/AndroidManifest.xml | 3 +--
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/android/build.gradle b/android/build.gradle
index d6d618d7..854e1277 100644
--- a/android/build.gradle
+++ b/android/build.gradle
@@ -81,10 +81,8 @@ def FRESCO_VERSION = getFrescoVersion()
 
 android {
     compileSdkVersion safeExtGet('compileSdkVersion', 28)
+    namespace "com.horcrux.svg"
     def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION
-    if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
-        namespace "com.horcrux.svg"
-    }
     if (agpVersion.tokenize('.')[0].toInteger() >= 8) {
         buildFeatures {
             buildConfig = true
diff --git a/android/src/main/AndroidManifest.xml b/android/src/main/AndroidManifest.xml
index d85bd62e..c4e6c98d 100644
--- a/android/src/main/AndroidManifest.xml
+++ b/android/src/main/AndroidManifest.xml
@@ -1,2 +1 @@
-<manifest package="com.horcrux.svg">
-</manifest>
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"/>