zoriya/react-native-svg
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-svg.git synced 2025-12-06 07:06:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: CMake flags (#2603)

Browse Source 
# Summary

Fix typo in CMakeLists.txt flags and use `ReactAndroid_VERSION_MINOR`
instead of `REACT_NATIVE_MINOR_VERSION`

## Test Plan

Example apps should build without warnings/errors on 0.73+ as well as on
0.77.0-rc.6
This commit is contained in:
Jakub Grzywacz
2025-01-08 10:30:37 +01:00
committed by GitHub
parent d888de904e
commit 73bdb03f4c
2 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
android/build.gradle
View File

@@ -104,13 +104,6 @@ android {
buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString() buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString()
consumerProguardFiles 'proguard-rules.pro' consumerProguardFiles 'proguard-rules.pro'
buildConfigField("String", "REACT_NATIVE_MINOR_VERSION", "\"${REACT_NATIVE_MINOR_VERSION}\"")
externalNativeBuild {
cmake {
arguments "-DREACT_NATIVE_MINOR_VERSION=${REACT_NATIVE_MINOR_VERSION}"
}
}
} }
lintOptions { lintOptions {
abortOnError false abortOnError false

2
android/src/main/jni/CMakeLists.txt
View File

@@ -10,7 +10,7 @@ set(RNS_GENERATED_REACT_DIR ${RNS_GENERATED_JNI_DIR}/react/renderer/components/r
string( string(
APPEND APPEND
CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS
" -DREACT_NATIVE_MINOR_VERSION=321${REACT_NATIVE_MINOR_VERSION}") " -DREACT_NATIVE_MINOR_VERSION=${ReactAndroid_VERSION_MINOR}")
add_compile_options( add_compile_options(
-fexceptions -fexceptions