From 768ec5df45d7b6e4fca7060b5f9d47e69136323f Mon Sep 17 00:00:00 2001 From: Jakub Grzywacz Date: Tue, 15 Oct 2024 09:44:31 +0200 Subject: [PATCH] fix: do not remove filter region on recycle (#2488) # Summary Filter regions were nil as init is not called when view is reused. --- apple/Filters/RNSVGFilter.mm | 2 +- apple/Filters/RNSVGFilterPrimitive.mm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apple/Filters/RNSVGFilter.mm b/apple/Filters/RNSVGFilter.mm index 703626d5..d36d1d78 100644 --- a/apple/Filters/RNSVGFilter.mm +++ b/apple/Filters/RNSVGFilter.mm @@ -72,7 +72,7 @@ using namespace facebook::react; [super prepareForRecycle]; _filterUnits = kRNSVGUnitsObjectBoundingBox; _primitiveUnits = kRNSVGUnitsUserSpaceOnUse; - _filterRegion = nil; + _filterRegion = [[RNSVGFilterRegion alloc] init]; } #endif // RCT_NEW_ARCH_ENABLED diff --git a/apple/Filters/RNSVGFilterPrimitive.mm b/apple/Filters/RNSVGFilterPrimitive.mm index 57acda8c..195bc48a 100644 --- a/apple/Filters/RNSVGFilterPrimitive.mm +++ b/apple/Filters/RNSVGFilterPrimitive.mm @@ -16,7 +16,7 @@ - (void)prepareForRecycle { [super prepareForRecycle]; - _filterSubregion = nil; + _filterSubregion = [[RNSVGFilterRegion alloc] init]; _result = nil; } #endif // RCT_NEW_ARCH_ENABLED