diff --git a/android/src/main/java/com/horcrux/svg/Brush.java b/android/src/main/java/com/horcrux/svg/Brush.java index 34301d2c..43759828 100644 --- a/android/src/main/java/com/horcrux/svg/Brush.java +++ b/android/src/main/java/com/horcrux/svg/Brush.java @@ -37,11 +37,12 @@ class Brush { enum BrushType { LINEAR_GRADIENT(0), RADIAL_GRADIENT(1), - PATTERN(2); + @SuppressWarnings("unused")PATTERN(2); BrushType(int ni) { nativeInt = ni; } + @SuppressWarnings("unused") final int nativeInt; } @@ -51,6 +52,7 @@ class Brush { BrushUnits(int ni) { nativeInt = ni; } + @SuppressWarnings("unused") final int nativeInt; } diff --git a/android/src/main/java/com/horcrux/svg/FontStyle.java b/android/src/main/java/com/horcrux/svg/FontStyle.java index d1792933..cec356eb 100644 --- a/android/src/main/java/com/horcrux/svg/FontStyle.java +++ b/android/src/main/java/com/horcrux/svg/FontStyle.java @@ -3,5 +3,5 @@ package com.horcrux.svg; enum FontStyle { normal, italic, - oblique + @SuppressWarnings("unused")oblique } diff --git a/android/src/main/java/com/horcrux/svg/GlyphPathBag.java b/android/src/main/java/com/horcrux/svg/GlyphPathBag.java index 0b411dd3..5f111cd6 100644 --- a/android/src/main/java/com/horcrux/svg/GlyphPathBag.java +++ b/android/src/main/java/com/horcrux/svg/GlyphPathBag.java @@ -6,9 +6,9 @@ import android.graphics.Path; import java.util.ArrayList; class GlyphPathBag { - private ArrayList paths = new ArrayList<>(); - private int[][] data = new int[255][]; - Paint paint; + private final ArrayList paths = new ArrayList<>(); + private final int[][] data = new int[255][]; + private final Paint paint; GlyphPathBag(Paint paint) { this.paint = paint; diff --git a/android/src/main/java/com/horcrux/svg/SvgView.java b/android/src/main/java/com/horcrux/svg/SvgView.java index 1ff967f4..ab5e700f 100644 --- a/android/src/main/java/com/horcrux/svg/SvgView.java +++ b/android/src/main/java/com/horcrux/svg/SvgView.java @@ -9,6 +9,7 @@ package com.horcrux.svg; +import android.annotation.SuppressLint; import android.graphics.Bitmap; import android.graphics.Canvas; import android.graphics.Point; @@ -29,12 +30,15 @@ import javax.annotation.Nullable; /** * Custom {@link View} implementation that draws an RNSVGSvg React view and its \childrn. */ +@SuppressLint("ViewConstructor") public class SvgView extends View { public enum Events { + @SuppressWarnings("unused") EVENT_DATA_URL("onDataURL"); private final String mName; + @SuppressWarnings({"unused", "SameParameterValue"}) Events(final String name) { mName = name; } diff --git a/android/src/main/java/com/horcrux/svg/SvgViewManager.java b/android/src/main/java/com/horcrux/svg/SvgViewManager.java index 770b18e6..ec0236d6 100644 --- a/android/src/main/java/com/horcrux/svg/SvgViewManager.java +++ b/android/src/main/java/com/horcrux/svg/SvgViewManager.java @@ -51,6 +51,7 @@ class SvgViewManager extends BaseViewManager { mTagToSvgView.put(svg.getId(), svg); } + @SuppressWarnings("unused") static @Nullable SvgView getSvgViewByTag(int tag) { return mTagToSvgView.get(tag); } diff --git a/android/src/main/java/com/horcrux/svg/TSpanShadowNode.java b/android/src/main/java/com/horcrux/svg/TSpanShadowNode.java index 83f153e3..92febff7 100644 --- a/android/src/main/java/com/horcrux/svg/TSpanShadowNode.java +++ b/android/src/main/java/com/horcrux/svg/TSpanShadowNode.java @@ -87,6 +87,7 @@ class TSpanShadowNode extends TextShadowNode { return mCache; } + @SuppressWarnings("ConstantConditions") private Path getLinePath(String line, Paint paint, Canvas canvas) { final int length = line.length(); final Path path = new Path(); diff --git a/android/src/main/java/com/horcrux/svg/TextLayoutAlgorithm.java b/android/src/main/java/com/horcrux/svg/TextLayoutAlgorithm.java index dea6cb4c..b0de6d8b 100644 --- a/android/src/main/java/com/horcrux/svg/TextLayoutAlgorithm.java +++ b/android/src/main/java/com/horcrux/svg/TextLayoutAlgorithm.java @@ -2,7 +2,9 @@ package com.horcrux.svg; // TODO implement https://www.w3.org/TR/SVG2/text.html#TextLayoutAlgorithm +@SuppressWarnings("unused") public class TextLayoutAlgorithm { + @SuppressWarnings("EmptyMethod") void layoutText() { /* diff --git a/android/src/main/java/com/horcrux/svg/TextPathMethod.java b/android/src/main/java/com/horcrux/svg/TextPathMethod.java index dc1b82c1..d31edea8 100644 --- a/android/src/main/java/com/horcrux/svg/TextPathMethod.java +++ b/android/src/main/java/com/horcrux/svg/TextPathMethod.java @@ -2,5 +2,5 @@ package com.horcrux.svg; enum TextPathMethod { align, - stretch + @SuppressWarnings("unused")stretch } diff --git a/android/src/main/java/com/horcrux/svg/TextPathMidLine.java b/android/src/main/java/com/horcrux/svg/TextPathMidLine.java index 764a6478..6f2e5864 100644 --- a/android/src/main/java/com/horcrux/svg/TextPathMidLine.java +++ b/android/src/main/java/com/horcrux/svg/TextPathMidLine.java @@ -8,5 +8,5 @@ package com.horcrux.svg; */ enum TextPathMidLine { sharp, - smooth + @SuppressWarnings("unused")smooth } diff --git a/android/src/main/java/com/horcrux/svg/TextPathShadowNode.java b/android/src/main/java/com/horcrux/svg/TextPathShadowNode.java index c43e67ec..ade96c08 100644 --- a/android/src/main/java/com/horcrux/svg/TextPathShadowNode.java +++ b/android/src/main/java/com/horcrux/svg/TextPathShadowNode.java @@ -65,19 +65,21 @@ class TextPathShadowNode extends TextShadowNode { markUpdated(); } + @SuppressWarnings("unused") TextPathMethod getMethod() { return mMethod; } - public TextPathSpacing getSpacing() { + @SuppressWarnings("unused") + TextPathSpacing getSpacing() { return mSpacing; } - public TextPathSide getSide() { + TextPathSide getSide() { return mSide; } - public TextPathMidLine getMidLine() { + TextPathMidLine getMidLine() { return mMidLine; } diff --git a/android/src/main/java/com/horcrux/svg/TextPathSide.java b/android/src/main/java/com/horcrux/svg/TextPathSide.java index 41348dcf..e305e782 100644 --- a/android/src/main/java/com/horcrux/svg/TextPathSide.java +++ b/android/src/main/java/com/horcrux/svg/TextPathSide.java @@ -1,6 +1,6 @@ package com.horcrux.svg; enum TextPathSide { - left, + @SuppressWarnings("unused")left, right } diff --git a/android/src/main/java/com/horcrux/svg/TextPathSpacing.java b/android/src/main/java/com/horcrux/svg/TextPathSpacing.java index d1d0d992..4af8b3e9 100644 --- a/android/src/main/java/com/horcrux/svg/TextPathSpacing.java +++ b/android/src/main/java/com/horcrux/svg/TextPathSpacing.java @@ -1,6 +1,6 @@ package com.horcrux.svg; enum TextPathSpacing { - auto, + @SuppressWarnings("unused")auto, exact } diff --git a/android/src/main/java/com/horcrux/svg/TextShadowNode.java b/android/src/main/java/com/horcrux/svg/TextShadowNode.java index 0aef68ba..2d4dd2a7 100644 --- a/android/src/main/java/com/horcrux/svg/TextShadowNode.java +++ b/android/src/main/java/com/horcrux/svg/TextShadowNode.java @@ -27,7 +27,7 @@ import javax.annotation.Nullable; class TextShadowNode extends GroupShadowNode { String mTextLength = null; TextLengthAdjust mLengthAdjust = TextLengthAdjust.spacing; - AlignmentBaseline mAlignmentBaseline; + private AlignmentBaseline mAlignmentBaseline; private @Nullable ReadableArray mPositionX; private @Nullable ReadableArray mPositionY; private @Nullable ReadableArray mRotate;