mirror of
https://github.com/zoriya/react-native-svg.git
synced 2026-06-01 06:07:41 +00:00
feat: e2e snapshot tests (#2338)
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect --> # Summary This PR adds E2E tests based on view screenshots done via `react-native-view-shot`. It only works with devices that have their [pixel ratio](https://reactnative.dev/docs/pixelratio) equal `3`. If you want to use device with different pixel ratio, you need to adjust it in `e2e/generateReferences.ts` viewport and regenerate reference images (see below). Steps to run tests: - Run Metro server for example app via `yarn start` in example app's directory - Run `example` app on platform of your choice (currently only Android & iOS are supported) via `yarn android` or `yarn ios` in example app's directory - Run `yarn e2e` in project's root directory to start Jest server - Select `E2E` tab in example app - Wait for tests to finish - You can see test results, as well as diffs (actual rendered svg vs reference image) in `e2e/diffs` directory Steps to add new test cases: - Put SVG of your choice to `e2e/cases` directory - Run `yarn generateE2eRefrences`, this will open headless chrome browser via `puppeteer` and snapshot all rendered SVGs to .png files and later use them as reference in tests - You should see new .png files in `e2e/references` - When you run E2E tests again, it will use new test case(s) you've added ## Test Plan https://github.com/software-mansion/react-native-svg/assets/41289688/24ee5447-ce9a-43b6-9dde-76229d25a30a https://github.com/software-mansion/react-native-svg/assets/41289688/71d1873f-8155-4494-80bd-e4c1fa72a065 ### What's required for testing (prerequisites)? See Summary ### What are the steps to reproduce (after prerequisites)? See Summary ## Compatibility | OS | Implemented | | ------- | :---------: | | iOS | ✅ | | Android | ✅ | | Web | ❌ | ## Checklist <!-- Check completed item, when applicable, via: [X] --> - [X] I have tested this on a device and a simulator - [x] I added documentation in `README.md` - [X] I updated the typed files (typescript) - [X] I added a test for the API in the `__tests__` folder --------- Co-authored-by: bohdanprog <bohdan.artiukhov@swmansion.com> Co-authored-by: Jakub Grzywacz <jakub.grzywacz@swmansion.com>
This commit is contained in:
committed by
GitHub
parent
53ba6f2413
commit
a089cc2efc
@@ -1058,7 +1058,7 @@ PODS:
|
||||
- RCT-Folly (= 2022.05.16.00)
|
||||
- React-Core
|
||||
- ReactCommon/turbomodule/core
|
||||
- RNSVG (15.3.0):
|
||||
- RNSVG (15.6.0):
|
||||
- React-Core
|
||||
- SocketRocket (0.6.1)
|
||||
- Yoga (1.14.0)
|
||||
@@ -1278,10 +1278,10 @@ SPEC CHECKSUMS:
|
||||
React-utils: debda2c206770ee2785bdebb7f16d8db9f18838a
|
||||
ReactCommon: ddb128564dcbfa0287d3d1a2d10f8c7457c971f6
|
||||
RNReanimated: 2fb8bf314df48f4968d9080aec46c47eb44a446a
|
||||
RNSVG: a48668fd382115bc89761ce291a81c4ca5f2fd2e
|
||||
RNSVG: 5da7a24f31968ec74f0b091e3440080f347e279b
|
||||
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
|
||||
Yoga: 2b33a7ac96c58cdaa7b810948fc6a2a76ed2d108
|
||||
|
||||
PODFILE CHECKSUM: 0ddaec8b74c24b39086422661a8aeb46f68d0382
|
||||
PODFILE CHECKSUM: 867081623c4821048817e3d8ade1e288af6d41a7
|
||||
|
||||
COCOAPODS: 1.15.2
|
||||
|
||||
Reference in New Issue
Block a user