zoriya/react-native-svg
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-svg.git synced 2026-06-02 06:35:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove unnecessary code

Browse Source
This commit is contained in:
Horcrux
2016-07-27 14:55:58 +08:00
parent 7d09dcde29
commit b512d57c7a
16 changed files with 10 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/src/main/java/com/horcrux/svg/RNSVGClipPathShadowNode.java
-5
View File
@@ -22,11 +22,6 @@ public class RNSVGClipPathShadowNode extends RNSVGGroupShadowNode {
getSvgShadowNode().defineClipPath(this, mName);
}
@Override
protected void removeDefinition() {
getSvgShadowNode().removeClipPath(mName);
}
@Override
public int hitTest(Point point, View view) {
return -1;
android/src/main/java/com/horcrux/svg/RNSVGGroupShadowNode.java
-10
View File
@@ -81,16 +81,6 @@ public class RNSVGGroupShadowNode extends RNSVGPathShadowNode {
}
}
protected void removeDefinition() {
if (mName != null) {
getSvgShadowNode().removeTemplate(mName);
}
for (int i = getChildCount() - 1; i >= 0; i--) {
((RNSVGVirtualNode) getChildAt(i)).removeDefinition();
}
}
@Override
public void mergeProperties(RNSVGVirtualNode target, ReadableArray mergeList) {
if (mergeList.size() != 0) {
android/src/main/java/com/horcrux/svg/RNSVGImageShadowNode.java
+2 -4
View File
@@ -19,12 +19,10 @@ import android.net.Uri;
import android.util.Log;
import com.facebook.common.executors.UiThreadImmediateExecutorService;
import com.facebook.common.logging.FLog;
import com.facebook.common.executors.CallerThreadExecutor;
import com.facebook.common.references.CloseableReference;
import com.facebook.datasource.DataSource;
import com.facebook.common.logging.FLog;
import com.facebook.drawee.backends.pipeline.Fresco;
import com.facebook.imagepipeline.core.ImagePipeline;
import com.facebook.imagepipeline.datasource.BaseBitmapDataSubscriber;
import com.facebook.imagepipeline.image.CloseableBitmap;
import com.facebook.imagepipeline.image.CloseableImage;
@@ -91,7 +89,6 @@ public class RNSVGImageShadowNode extends RNSVGPathShadowNode {
final ImageRequest request = ImageRequestBuilder.newBuilderWithSource(mUri).build();
final boolean inMemoryCache = Fresco.getImagePipeline().isInBitmapMemoryCache(request);
if (inMemoryCache) {
tryRender(request, canvas, paint, opacity * mOpacity);
} else if (!mLoading) {
@@ -135,11 +132,12 @@ public class RNSVGImageShadowNode extends RNSVGPathShadowNode {
float w = PropHelper.fromPercentageToFloat(mW, mCanvasWidth, 0, mScale);
float h = PropHelper.fromPercentageToFloat(mH, mCanvasHeight, 0, mScale);
Paint alphaPaint = new Paint();
alphaPaint.setAlpha((int) (opacity * 255));
canvas.drawBitmap(bitmap, null, new Rect((int) x, (int) y, (int) (x + w), (int) (y + h)), alphaPaint);
restoreCanvas(canvas, count);
markUpdateSeen();
}
private void tryRender(@Nonnull final ImageRequest request, @Nonnull final Canvas canvas, @Nonnull final Paint paint, final float opacity) {
android/src/main/java/com/horcrux/svg/RNSVGLinearGradientShadowNode.java
-8
View File
@@ -70,12 +70,4 @@ public class RNSVGLinearGradientShadowNode extends RNSVGDefinitionShadowNode {
getSvgShadowNode().defineBrush(brush, mName);
}
}
@Override
protected void removeDefinition() {
if (mName != null) {
getSvgShadowNode().removeBrush(mName);
}
}
}
android/src/main/java/com/horcrux/svg/RNSVGRadialGradientShadowNode.java
-8
View File
@@ -83,12 +83,4 @@ public class RNSVGRadialGradientShadowNode extends RNSVGDefinitionShadowNode {
getSvgShadowNode().defineBrush(brush, mName);
}
}
@Override
protected void removeDefinition() {
if (mName != null) {
getSvgShadowNode().removeBrush(mName);
}
}
}
android/src/main/java/com/horcrux/svg/RNSVGSvgViewShadowNode.java
-13
View File
@@ -47,7 +47,6 @@ public class RNSVGSvgViewShadowNode extends LayoutShadowNode {
Paint paint = new Paint();
drawChildren(canvas, paint);
return bitmap;
}
@@ -101,10 +100,6 @@ public class RNSVGSvgViewShadowNode extends LayoutShadowNode {
mDefinedClipPaths.put(clipPathRef, clipPath);
}
public void removeClipPath(String clipPathRef) {
mDefinedClipPaths.remove(clipPathRef);
}
public RNSVGVirtualNode getDefinedClipPath(String clipPathRef) {
return mDefinedClipPaths.get(clipPathRef);
}
@@ -113,10 +108,6 @@ public class RNSVGSvgViewShadowNode extends LayoutShadowNode {
mDefinedTemplates.put(templateRef, template);
}
public void removeTemplate(String templateRef) {
mDefinedTemplates.remove(templateRef);
}
public RNSVGVirtualNode getDefinedTemplate(String templateRef) {
return mDefinedTemplates.get(templateRef);
}
@@ -125,10 +116,6 @@ public class RNSVGSvgViewShadowNode extends LayoutShadowNode {
mDefinedBrushes.put(brushRef, brush);
}
public void removeBrush(String brushRef) {
mDefinedBrushes.remove(brushRef);
}
public PropHelper.RNSVGBrush getDefinedBrush(String brushRef) {
return mDefinedBrushes.get(brushRef);
}
android/src/main/java/com/horcrux/svg/RNSVGViewBoxShadowNode.java
+1 -1
View File
@@ -167,7 +167,7 @@ public class RNSVGViewBoxShadowNode extends RNSVGGroupShadowNode {
@Override
public void mergeProperties(RNSVGVirtualNode target, ReadableArray mergeList) {
if (target.getClass() == RNSVGUseShadowNode.class) {
if (target instanceof RNSVGUseShadowNode) {
mFromSymbol = true;
mBoxWidth = ((RNSVGUseShadowNode)target).getWidth();
mBoxHeight = ((RNSVGUseShadowNode)target).getHeight();
android/src/main/java/com/horcrux/svg/RNSVGVirtualNode.java
-7
View File
@@ -299,16 +299,9 @@ public abstract class RNSVGVirtualNode extends LayoutShadowNode {
}
}
protected void removeDefinition() {
if (mName != null) {
getSvgShadowNode().removeTemplate(mName);
}
}
abstract public void mergeProperties(RNSVGVirtualNode target, ReadableArray mergeList, boolean inherited);
abstract public void mergeProperties(RNSVGVirtualNode target, ReadableArray mergeList);
abstract public void resetProperties();
}