zoriya/react-native-svg
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-svg.git synced 2026-06-04 15:44:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cache textRoot for getTextRootGlyphContext.

Browse Source 
Use getTextRootGlyphContext() instead of getTextRoot().getGlyphContext() in TextShadowNode.pushGlyphContext()
This commit is contained in:
Mikael Sand
2017-07-22 03:00:15 +03:00
parent bb6ee3e430
commit b7bfaab63d
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/src/main/java/com/horcrux/svg/GroupShadowNode.java
+5 -1
View File
@@ -29,6 +29,7 @@ class GroupShadowNode extends RenderableShadowNode {
@Nullable ReadableMap mFont; @Nullable ReadableMap mFont;
private GlyphContext mGlyphContext; private GlyphContext mGlyphContext;
private GroupShadowNode textRoot;
@ReactProp(name = "font") @ReactProp(name = "font")
public void setFont(@Nullable ReadableMap font) { public void setFont(@Nullable ReadableMap font) {
@@ -47,7 +48,10 @@ class GroupShadowNode extends RenderableShadowNode {
} }
GlyphContext getTextRootGlyphContext() { GlyphContext getTextRootGlyphContext() {
return getTextRoot().getGlyphContext(); if (textRoot == null) {
textRoot = getTextRoot();
}
return textRoot.getGlyphContext();
} }
void pushGlyphContext() { void pushGlyphContext() {
android/src/main/java/com/horcrux/svg/TextShadowNode.java
+1 -1
View File
@@ -178,6 +178,6 @@ class TextShadowNode extends GroupShadowNode {
@Override @Override
void pushGlyphContext() { void pushGlyphContext() {
boolean isTextNode = !(this instanceof TextPathShadowNode) && !(this instanceof TSpanShadowNode); boolean isTextNode = !(this instanceof TextPathShadowNode) && !(this instanceof TSpanShadowNode);
getTextRoot().getGlyphContext().pushContext(this, mFont, mRotate, mDeltaX, mDeltaY, mPositionX, mPositionY, isTextNode); getTextRootGlyphContext().pushContext(this, mFont, mRotate, mDeltaX, mDeltaY, mPositionX, mPositionY, isTextNode);
} }
} }