From ce602c1d624c687a8c80b4675d53953a8cc0932f Mon Sep 17 00:00:00 2001 From: Mikael Sand Date: Wed, 22 Aug 2018 15:29:28 +0300 Subject: [PATCH] Fix dynamic null handling --- .../java/com/horcrux/svg/RenderableShadowNode.java | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/android/src/main/java/com/horcrux/svg/RenderableShadowNode.java b/android/src/main/java/com/horcrux/svg/RenderableShadowNode.java index 1ab8082c..5cba5b4a 100644 --- a/android/src/main/java/com/horcrux/svg/RenderableShadowNode.java +++ b/android/src/main/java/com/horcrux/svg/RenderableShadowNode.java @@ -80,6 +80,11 @@ abstract public class RenderableShadowNode extends VirtualNode { @ReactProp(name = "fill") public void setFill(@Nullable Dynamic fill) { + if (fill == null || fill.isNull()) { + mFill = null; + markUpdated(); + return; + } ReadableType type = fill.getType(); if (type.equals(ReadableType.Array)) { mFill = fill.asArray(); @@ -121,6 +126,11 @@ abstract public class RenderableShadowNode extends VirtualNode { @ReactProp(name = "stroke") public void setStroke(@Nullable Dynamic strokeColors) { + if (strokeColors == null || strokeColors.isNull()) { + mStroke = null; + markUpdated(); + return; + } ReadableType type = strokeColors.getType(); if (type.equals(ReadableType.Array)) { mStroke = strokeColors.asArray();