zoriya/react-native-svg
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-svg.git synced 2026-06-04 15:44:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

add accessibility and testId props and virtual nodes to support e2e tests tools (#2001)

Browse Source 
PR adding accessibility and testId props and virtual nodes to support e2e tests tools and provide general accessibility support.

Co-authored-by: yonatan.altaraz <yonatan.altaraz@khealth.ai>
Co-authored-by: galkahana <gal.kahana@hotmail.com>
This commit is contained in:
toter3
2023-03-22 14:01:09 +02:00
committed by GitHub
parent eaf79ea3ee
commit d03604797f
8 changed files with 110 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apple/RNSVGNode.h
+3
View File
@@ -74,6 +74,9 @@ extern CGFloat const RNSVG_DEFAULT_FONT_SIZE;
@property (nonatomic, assign) CGRect markerBounds;
@property (nonatomic, copy) RCTDirectEventBlock onLayout;
@property (nonatomic, copy) NSString *testID;
@property (nonatomic, assign) BOOL accessible;
/**
* RNSVGSvgView which ownes current RNSVGNode
*/
apple/RNSVGNode.mm
+12
View File
@@ -190,6 +190,18 @@ CGFloat const RNSVG_DEFAULT_FONT_SIZE = 12;
_name = name;
}
- (void)setTestID:(NSString *)testID
{
self.accessibilityIdentifier = testID;
[self invalidate];
}
- (void)setAccessible:(BOOL)accessible
{
self.isAccessibilityElement = accessible;
[self invalidate];
}
- (void)setDisplay:(NSString *)display
{
if ([display isEqualToString:_display]) {
apple/ViewManagers/RNSVGNodeManager.mm
+4
View File
@@ -45,6 +45,10 @@ RCT_EXPORT_VIEW_PROPERTY(clipRule, RNSVGCGFCRule)
RCT_EXPORT_VIEW_PROPERTY(responsible, BOOL)
RCT_EXPORT_VIEW_PROPERTY(onLayout, RCTDirectEventBlock)
RCT_EXPORT_VIEW_PROPERTY(testID, NSString)
RCT_EXPORT_VIEW_PROPERTY(accessibilityLabel, NSString)
RCT_EXPORT_VIEW_PROPERTY(accessible, BOOL)
RCT_CUSTOM_SHADOW_PROPERTY(top, id, RNSVGNode) {}
RCT_CUSTOM_SHADOW_PROPERTY(right, id, RNSVGNode) {}
RCT_CUSTOM_SHADOW_PROPERTY(start, id, RNSVGNode) {}