From e79a6c198e528c77b015325592861ac7d5b32b5f Mon Sep 17 00:00:00 2001 From: Jakub Grzywacz Date: Fri, 24 Jan 2025 16:34:33 +0100 Subject: [PATCH] fix: FeDropShadow results and import react (#2625) # Summary * Add results alias in `FeDropShadow` * Import React in every tsx filter file to satisfy typescript/eslint * Replace `<>` with `` in `FeDropShadow` --- src/elements/filters/FeBlend.tsx | 1 + src/elements/filters/FeColorMatrix.tsx | 2 +- src/elements/filters/FeComponentTransfer.tsx | 2 +- .../filters/FeComponentTransferFunction.tsx | 1 + src/elements/filters/FeComposite.tsx | 1 + src/elements/filters/FeDropShadow.tsx | 15 +++++++++++---- src/elements/filters/FeFlood.tsx | 1 + src/elements/filters/FeGaussianBlur.tsx | 2 +- src/elements/filters/FeMerge.tsx | 2 +- src/elements/filters/FeMergeNode.tsx | 2 +- src/elements/filters/FeOffset.tsx | 2 +- src/elements/filters/Filter.tsx | 2 +- 12 files changed, 22 insertions(+), 11 deletions(-) diff --git a/src/elements/filters/FeBlend.tsx b/src/elements/filters/FeBlend.tsx index 672dc163..d243603b 100644 --- a/src/elements/filters/FeBlend.tsx +++ b/src/elements/filters/FeBlend.tsx @@ -1,3 +1,4 @@ +import React from 'react'; import { NativeMethods } from 'react-native'; import { extractFeBlend, diff --git a/src/elements/filters/FeColorMatrix.tsx b/src/elements/filters/FeColorMatrix.tsx index f98f4004..799e6853 100644 --- a/src/elements/filters/FeColorMatrix.tsx +++ b/src/elements/filters/FeColorMatrix.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import React from 'react'; import { NativeMethods } from 'react-native'; import RNSVGFeColorMatrix from '../../fabric/FeColorMatrixNativeComponent'; import { diff --git a/src/elements/filters/FeComponentTransfer.tsx b/src/elements/filters/FeComponentTransfer.tsx index 3ed6b6e6..c1c0b9d9 100644 --- a/src/elements/filters/FeComponentTransfer.tsx +++ b/src/elements/filters/FeComponentTransfer.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import React from 'react'; import FilterPrimitive from './FilterPrimitive'; import { warnUnimplementedFilter } from '../../lib/util'; diff --git a/src/elements/filters/FeComponentTransferFunction.tsx b/src/elements/filters/FeComponentTransferFunction.tsx index 469f09f3..a2dba015 100644 --- a/src/elements/filters/FeComponentTransferFunction.tsx +++ b/src/elements/filters/FeComponentTransferFunction.tsx @@ -1,3 +1,4 @@ +import React from 'react'; import { NumberArray, NumberProp } from '../../lib/extract/types'; import { warnUnimplementedFilter } from '../../lib/util'; import FilterPrimitive from './FilterPrimitive'; diff --git a/src/elements/filters/FeComposite.tsx b/src/elements/filters/FeComposite.tsx index 4968218f..0818e48d 100644 --- a/src/elements/filters/FeComposite.tsx +++ b/src/elements/filters/FeComposite.tsx @@ -1,3 +1,4 @@ +import React from 'react'; import { NativeMethods } from 'react-native'; import RNSVGFeComposite from '../../fabric/FeCompositeNativeComponent'; import { diff --git a/src/elements/filters/FeDropShadow.tsx b/src/elements/filters/FeDropShadow.tsx index 66a653f8..afeaea24 100644 --- a/src/elements/filters/FeDropShadow.tsx +++ b/src/elements/filters/FeDropShadow.tsx @@ -1,3 +1,4 @@ +import React from 'react'; import { ColorValue } from 'react-native'; import { NumberArray, NumberProp } from '../../lib/extract/types'; import FeFlood from './FeFlood'; @@ -25,9 +26,15 @@ export default class FeDropShadow extends FilterPrimitive { }; render() { - const { stdDeviation, in: in1 = 'SourceGraphic', dx, dy } = this.props; + const { + stdDeviation, + in: in1 = 'SourceGraphic', + dx, + dy, + result, + } = this.props; return ( - <> + { floodOpacity={this.props.floodOpacity} /> - + - + ); } } diff --git a/src/elements/filters/FeFlood.tsx b/src/elements/filters/FeFlood.tsx index 1aace13d..5dbbb782 100644 --- a/src/elements/filters/FeFlood.tsx +++ b/src/elements/filters/FeFlood.tsx @@ -1,3 +1,4 @@ +import React from 'react'; import { ColorValue, NativeMethods } from 'react-native'; import RNSVGFeFlood from '../../fabric/FeFloodNativeComponent'; import extractFeFlood, { extractFilter } from '../../lib/extract/extractFilter'; diff --git a/src/elements/filters/FeGaussianBlur.tsx b/src/elements/filters/FeGaussianBlur.tsx index d0a585ef..18277a0e 100644 --- a/src/elements/filters/FeGaussianBlur.tsx +++ b/src/elements/filters/FeGaussianBlur.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import React from 'react'; import { NativeMethods } from 'react-native'; import RNSVGFeGaussianBlur from '../../fabric/FeGaussianBlurNativeComponent'; import { diff --git a/src/elements/filters/FeMerge.tsx b/src/elements/filters/FeMerge.tsx index 2dddfa2e..4a73b414 100644 --- a/src/elements/filters/FeMerge.tsx +++ b/src/elements/filters/FeMerge.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import React from 'react'; import { NativeMethods } from 'react-native'; import RNSVGFeMerge from '../../fabric/FeMergeNativeComponent'; import { extractFeMerge, extractFilter } from '../../lib/extract/extractFilter'; diff --git a/src/elements/filters/FeMergeNode.tsx b/src/elements/filters/FeMergeNode.tsx index 0aa85e3d..a71d348c 100644 --- a/src/elements/filters/FeMergeNode.tsx +++ b/src/elements/filters/FeMergeNode.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import React from 'react'; import FilterPrimitive from './FilterPrimitive'; export interface FeMergeNodeProps { diff --git a/src/elements/filters/FeOffset.tsx b/src/elements/filters/FeOffset.tsx index 91d9952e..d486c0e3 100644 --- a/src/elements/filters/FeOffset.tsx +++ b/src/elements/filters/FeOffset.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import React from 'react'; import { NativeMethods } from 'react-native'; import RNSVGFeOffset from '../../fabric/FeOffsetNativeComponent'; import { extractFilter, extractIn } from '../../lib/extract/extractFilter'; diff --git a/src/elements/filters/Filter.tsx b/src/elements/filters/Filter.tsx index 4c516ce0..b40f6aa9 100644 --- a/src/elements/filters/Filter.tsx +++ b/src/elements/filters/Filter.tsx @@ -1,4 +1,4 @@ -import * as React from 'react'; +import React from 'react'; import { NativeMethods } from 'react-native'; import RNSVGFilter from '../../fabric/FilterNativeComponent'; import { NumberProp, Units } from '../../lib/extract/types';