zoriya/react-native-svg
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-svg.git synced 2025-12-05 22:56:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: unify filters types (#2394)

Browse Source 
# Summary

Use unified SVG types for `FeColorMatrix` and `FeGaussianBlur`
This commit is contained in:
Jakub Grzywacz
2024-08-05 08:30:32 +02:00
committed by GitHub
parent dc7bd2ce5f
commit e88e6403b7
3 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/elements/filters/FeColorMatrix.tsx
View File

@@ -6,13 +6,13 @@ import {
extractFilter,
extractIn,
} from '../../lib/extract/extractFilter';
import { FilterColorMatrixType } from '../../lib/extract/types';
import { FilterColorMatrixType, NumberArray } from '../../lib/extract/types';
import FilterPrimitive from './FilterPrimitive';
export type FeColorMatrixProps = {
in?: string;
type?: FilterColorMatrixType;
values?: number | Array<number> | string;
values?: NumberArray;
};
export default class FeColorMatrix extends FilterPrimitive<FeColorMatrixProps> {

4
src/elements/filters/FeGaussianBlur.tsx
View File

@@ -6,12 +6,12 @@ import {
extractFilter,
extractIn,
} from '../../lib/extract/extractFilter';
import { FilterEdgeMode, NumberProp } from '../../lib/extract/types';
import { FilterEdgeMode, NumberArray } from '../../lib/extract/types';
import FilterPrimitive from './FilterPrimitive';
export interface FeGaussianBlurProps {
in?: string;
stdDeviation?: NumberProp;
stdDeviation?: NumberArray;
// edgeMode is hard to implement and not supported by any
// browser except safari, so it's not implemented for now
// https://caniuse.com/mdn-api_svgfegaussianblurelement_edgemode

9
src/lib/extract/extractFilter.ts
View File

@@ -46,7 +46,9 @@ export const extractFeColorMatrix = (
if (props.values !== undefined) {
if (Array.isArray(props.values)) {
extracted.values = props.values;
extracted.values = props.values.map((num) =>
typeof num === 'number' ? num : parseFloat(num)
);
} else if (typeof props.values === 'number') {
extracted.values = [props.values];
} else if (typeof props.values === 'string') {
@@ -70,7 +72,10 @@ export const extractFeGaussianBlur = (
): FeGaussianBlurNativeProps => {
const extracted: FeGaussianBlurNativeProps = {};
if (
if (Array.isArray(props.stdDeviation)) {
extracted.stdDeviationX = Number(props.stdDeviation[0]) || 0;
extracted.stdDeviationY = Number(props.stdDeviation[1]) || 0;
} else if (
typeof props.stdDeviation === 'string' &&
props.stdDeviation.match(spaceReg)
) {