From f2ce29dabebc1cf391f54627d156cb1a6d57e068 Mon Sep 17 00:00:00 2001 From: Jakub Grzywacz Date: Mon, 20 Jan 2025 12:01:47 +0100 Subject: [PATCH] fix: don't set zero dimensions on RNSVGGroup (#2612) # Summary Fixes #2610 It's more of a hack than the best fix for that; however, it's a regression that we should address. ## Test Plan Test case provided in #2610 --- .../components/rnsvg/RNSVGLayoutableShadowNode.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/common/cpp/react/renderer/components/rnsvg/RNSVGLayoutableShadowNode.cpp b/common/cpp/react/renderer/components/rnsvg/RNSVGLayoutableShadowNode.cpp index a42fde95..d0e7498a 100644 --- a/common/cpp/react/renderer/components/rnsvg/RNSVGLayoutableShadowNode.cpp +++ b/common/cpp/react/renderer/components/rnsvg/RNSVGLayoutableShadowNode.cpp @@ -8,14 +8,18 @@ RNSVGLayoutableShadowNode::RNSVGLayoutableShadowNode( const ShadowNodeFamily::Shared &family, ShadowNodeTraits traits) : YogaLayoutableShadowNode(fragment, family, traits) { - setZeroDimensions(); + if (std::strcmp(this->getComponentName(), "RNSVGGroup") != 0) { + setZeroDimensions(); + } } RNSVGLayoutableShadowNode::RNSVGLayoutableShadowNode( const ShadowNode &sourceShadowNode, const ShadowNodeFragment &fragment) : YogaLayoutableShadowNode(sourceShadowNode, fragment) { - setZeroDimensions(); + if (std::strcmp(this->getComponentName(), "RNSVGGroup") != 0) { + setZeroDimensions(); + } } void RNSVGLayoutableShadowNode::setZeroDimensions() {