mirror of
https://github.com/zoriya/react-native-svg.git
synced 2025-12-06 07:06:11 +00:00
e2d9cbf1e3
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect --> # Summary This is a sibling PR to: https://github.com/software-mansion/react-native-svg/pull/2318 which fixed missing mount/unmount methods to correctly display SVG. This PR overrides the same `mountChildComponentView` and `unmountChildComponentView` methods but for `RNSVGSvgView` component. This will make the components and their behaviour aligned and more predictable. I included the test that specifically tests for attaching another external svg into and already existing SVG, should catch any edge cases with invalidation/redrawing. ## Test Plan `TestExample` app -> `TestSvgUriUpdating` example. https://github.com/software-mansion/react-native-svg/assets/3929868/49499914-7037-4ab0-a9a9-1e139d460117 ## Compatibility | OS | Implemented | | ------- | :---------: | | iOS | ✅ | ## Checklist <!-- Check completed item, when applicable, via: [X] --> - [x] I have tested this on a device and a simulator - [ ] I added documentation in `README.md` - [ ] I updated the typed files (typescript) - [ ] I added a test for the API in the `__tests__` folder
28 lines
937 B
JavaScript
28 lines
937 B
JavaScript
/* eslint-disable no-unused-vars */
|
|
import React from 'react';
|
|
|
|
import ColorTest from './src/ColorTest';
|
|
import PointerEventsBoxNone from './src/PointerEventsBoxNone';
|
|
import MountUnmount from './src/MountUnmount';
|
|
import Test1374 from './src/Test1374';
|
|
import Test1442 from './src/Test1442';
|
|
import Test1451 from './src/Test1451';
|
|
import Test1718 from './src/Test1718';
|
|
import Test1813 from './src/Test1813';
|
|
import Test1845 from './src/Test1845';
|
|
import Test1986 from './src/Test1986';
|
|
import Test2071 from './src/Test2071';
|
|
import Test2080 from './src/Test2080';
|
|
import Test2086 from './src/Test2086';
|
|
import Test2089 from './src/Test2089';
|
|
import Test2148 from './src/Test2148';
|
|
import Test2196 from './src/Test2196';
|
|
import Test2248 from './src/Test2248';
|
|
import Test2266 from './src/Test2266';
|
|
import Test2276 from './src/Test2276';
|
|
import Test2327 from './src/Test2327';
|
|
|
|
export default function App() {
|
|
return <ColorTest />;
|
|
}
|