zoriya/react-native-web
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-web.git synced 2026-06-03 18:52:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace invariant with console.error in View

Browse Source 
Jest dumps the invariant error to the console when unit tests run, which is
both annoying and more likely to cause unwanted error to go unnoticed. We're
also moving away from using 'invariant' in React. This patch replaces the
invariant with a call to 'console.error', which won't crash an app that is
using raw text nodes as View children, but it's better than nothing.
This commit is contained in:
Nicolas Gallagher
2019-12-21 16:58:14 +00:00
parent 287251a06a
commit 16c0109df6
2 changed files with 27 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native-web/src/exports/View/__tests__/index-test.js
Vendored
+22 -12
View File
@@ -10,13 +10,28 @@ describe('components/View', () => {
expect(container.firstChild).toMatchSnapshot(); expect(container.firstChild).toMatchSnapshot();
}); });
test('text node throws error (single)', () => { test('non-text is rendered', () => {
const subject = () => render(<View>hello</View>); const children = <View testID="1" />;
expect(subject).toThrow(); const { container } = render(<View>{children}</View>);
expect(container.firstChild).toMatchSnapshot();
}); });
test('text node throws error (array)', () => { describe('raw text nodes as children', () => {
const subject = () => beforeEach(() => {
jest.spyOn(console, 'error');
console.error.mockImplementation(() => {});
});
afterEach(() => {
console.error.mockRestore();
});
test('error logged (single)', () => {
render(<View>hello</View>);
expect(console.error).toBeCalled();
});
test('error logged (array)', () => {
render( render(
<View> <View>
<View /> <View />
@@ -24,13 +39,8 @@ describe('components/View', () => {
<View /> <View />
</View> </View>
); );
expect(subject).toThrow(); expect(console.error).toBeCalled();
}); });
test('non-text is rendered', () => {
const children = <View testID="1" />;
const { container } = render(<View>{children}</View>);
expect(container.firstChild).toMatchSnapshot();
}); });
describe('prop "hitSlop"', () => { describe('prop "hitSlop"', () => {
packages/react-native-web/src/exports/View/index.js
Vendored
+5 -5
View File
@@ -15,7 +15,6 @@ import applyNativeMethods from '../../modules/applyNativeMethods';
import createElement from '../createElement'; import createElement from '../createElement';
import css from '../StyleSheet/css'; import css from '../StyleSheet/css';
import filterSupportedProps from './filterSupportedProps'; import filterSupportedProps from './filterSupportedProps';
import invariant from 'fbjs/lib/invariant';
import StyleSheet from '../StyleSheet'; import StyleSheet from '../StyleSheet';
import TextAncestorContext from '../Text/TextAncestorContext'; import TextAncestorContext from '../Text/TextAncestorContext';
import React from 'react'; import React from 'react';
@@ -42,10 +41,11 @@ class View extends React.Component<ViewProps> {
if (process.env.NODE_ENV !== 'production') { if (process.env.NODE_ENV !== 'production') {
React.Children.toArray(this.props.children).forEach(item => { React.Children.toArray(this.props.children).forEach(item => {
invariant( if (typeof item === 'string') {
typeof item !== 'string', console.error(
`Unexpected text node: ${item}. A text node cannot be a child of a <View>.` `Unexpected text node: ${item}. A text node cannot be a child of a <View>.`
); );
}
}); });
} }