From 41159bcb1098182edabbb67ac741c3f7dee0ca83 Mon Sep 17 00:00:00 2001 From: Nicolas Gallagher Date: Mon, 11 Jul 2016 20:25:05 -0700 Subject: [PATCH] [fix] default DOM element for 'View' There are certain contexts where using a `div` is invalid HTML and may cause rendering issues. Change the default element created by `createReactDOMComponent` to a `span`. **Appendix** The following HTML results a validator error. test Error: Element `div` not allowed as child of element `button` in this context. Source: https://validator.w3.org/nu/#textarea --- src/modules/createReactDOMComponent/__tests__/index-test.js | 4 +++- src/modules/createReactDOMComponent/index.js | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/modules/createReactDOMComponent/__tests__/index-test.js b/src/modules/createReactDOMComponent/__tests__/index-test.js index 180d8344..afd01093 100644 --- a/src/modules/createReactDOMComponent/__tests__/index-test.js +++ b/src/modules/createReactDOMComponent/__tests__/index-test.js @@ -43,7 +43,9 @@ suite('modules/createReactDOMComponent', () => { test('prop "component"', () => { const component = 'main' - const element = shallow(createReactDOMComponent({ component })) + let element = shallow(createReactDOMComponent({})) + assert.equal(element.is('span'), true, 'Default element must be a "span"') + element = shallow(createReactDOMComponent({ component })) assert.equal(element.is('main'), true) }) diff --git a/src/modules/createReactDOMComponent/index.js b/src/modules/createReactDOMComponent/index.js index 68a373e1..d65483d4 100644 --- a/src/modules/createReactDOMComponent/index.js +++ b/src/modules/createReactDOMComponent/index.js @@ -22,7 +22,7 @@ const createReactDOMComponent = ({ accessibilityLiveRegion, accessibilityRole, accessible = true, - component = 'div', + component = 'span', testID, type, ...other