From 438f398022360bcf6396f9ea637bed46a9cf728b Mon Sep 17 00:00:00 2001 From: Nicolas Gallagher Date: Thu, 20 Apr 2017 09:14:41 -0700 Subject: [PATCH] Standardize styles for benchmark View implementations --- performance/src/components/View/aphrodite.js | 8 -------- performance/src/components/View/glamor.js | 8 -------- performance/src/components/View/jss.js | 8 -------- .../src/components/View/react-native-stylesheet.js | 8 -------- performance/src/components/View/styled-components.js | 6 ------ performance/src/components/View/styles.css | 6 ------ src/modules/createDOMProps/index.js | 1 - 7 files changed, 45 deletions(-) diff --git a/performance/src/components/View/aphrodite.js b/performance/src/components/View/aphrodite.js index 6a8d772d..020d09bf 100644 --- a/performance/src/components/View/aphrodite.js +++ b/performance/src/components/View/aphrodite.js @@ -17,14 +17,6 @@ const styles = StyleSheet.create({ margin: 0, padding: 0, position: 'relative', - // button and anchor reset - backgroundColor: 'transparent', - color: 'inherit', - font: 'inherit', - textAlign: 'inherit', - textDecoration: 'none', - // list reset - listStyle: 'none', // fix flexbox bugs minHeight: 0, minWidth: 0 diff --git a/performance/src/components/View/glamor.js b/performance/src/components/View/glamor.js index 997ae37a..261f29aa 100644 --- a/performance/src/components/View/glamor.js +++ b/performance/src/components/View/glamor.js @@ -16,14 +16,6 @@ const viewStyle = { margin: 0, padding: 0, position: 'relative', - // button and anchor reset - backgroundColor: 'transparent', - color: 'inherit', - font: 'inherit', - textAlign: 'inherit', - textDecorationLine: 'none', - // list reset - listStyle: 'none', // fix flexbox bugs minHeight: 0, minWidth: 0 diff --git a/performance/src/components/View/jss.js b/performance/src/components/View/jss.js index 95a1048f..31ce9c64 100644 --- a/performance/src/components/View/jss.js +++ b/performance/src/components/View/jss.js @@ -20,14 +20,6 @@ const styles = { margin: 0, padding: 0, position: 'relative', - // button and anchor reset - backgroundColor: 'transparent', - color: 'inherit', - font: 'inherit', - textAlign: 'inherit', - textDecorationLine: 'none', - // list reset - listStyle: 'none', // fix flexbox bugs minHeight: 0, minWidth: 0 diff --git a/performance/src/components/View/react-native-stylesheet.js b/performance/src/components/View/react-native-stylesheet.js index 1e3821f2..80302f24 100644 --- a/performance/src/components/View/react-native-stylesheet.js +++ b/performance/src/components/View/react-native-stylesheet.js @@ -21,14 +21,6 @@ const styles = StyleSheet.create({ margin: 0, padding: 0, position: 'relative', - // button and anchor reset - backgroundColor: 'transparent', - color: 'inherit', - font: 'inherit', - textAlign: 'inherit', - textDecoration: 'none', - // list reset - listStyle: 'none', // fix flexbox bugs minHeight: 0, minWidth: 0 diff --git a/performance/src/components/View/styled-components.js b/performance/src/components/View/styled-components.js index aa15c4c7..bb225c9a 100644 --- a/performance/src/components/View/styled-components.js +++ b/performance/src/components/View/styled-components.js @@ -12,12 +12,6 @@ const View = styled.div` margin: 0; padding: 0; position: relative; - background-color: transparent; - color: inherit; - font: inherit; - text-align: inherit; - text-decoration: none; - list-style: none; min-height: 0; min-width: 0; `; diff --git a/performance/src/components/View/styles.css b/performance/src/components/View/styles.css index 37539f23..2dda1491 100644 --- a/performance/src/components/View/styles.css +++ b/performance/src/components/View/styles.css @@ -10,12 +10,6 @@ margin: 0; padding: 0; position: relative; - background-color: transparent; - color: inherit; - font: inherit; - text-align: inherit; - text-decoration: none; - list-style: none; min-height: 0; min-width: 0; } diff --git a/src/modules/createDOMProps/index.js b/src/modules/createDOMProps/index.js index 677b57e7..b392cb08 100644 --- a/src/modules/createDOMProps/index.js +++ b/src/modules/createDOMProps/index.js @@ -58,7 +58,6 @@ const createDOMProps = (rnProps, resolveStyle = resolver) => { ...domProps } = props; - // MOVE TEXT / VIEW BUTTON RESET HERE const role = AccessibilityUtil.propsToAriaRole(props); const pointerEventStyle = pointerEvents !== undefined && pointerEventStyles[pointerEvents]; const reactNativeStyle = [