From 5335bcfd4869eb7a21256c09b517173158fe6dea Mon Sep 17 00:00:00 2001 From: Nicolas Gallagher Date: Sat, 26 Dec 2015 10:40:36 +0000 Subject: [PATCH] [chore] docs and formatting --- docs/components/Touchable.md | 10 +++++----- src/components/Image/index.js | 5 +---- src/components/ListView/index.js | 5 +++-- src/components/Text/index.js | 2 +- src/components/View/index.js | 2 +- 5 files changed, 11 insertions(+), 13 deletions(-) diff --git a/docs/components/Touchable.md b/docs/components/Touchable.md index 6e45de41..de33e0af 100644 --- a/docs/components/Touchable.md +++ b/docs/components/Touchable.md @@ -20,7 +20,7 @@ Unsupported React Native props: Overrides the text that's read by the screen reader when the user interacts with the element. -(web) **accessibilityRole**: oneOf(roles) +(web) **accessibilityRole**: oneOf(roles) = 'button' Allows assistive technologies to present and support interaction with the view in a manner that is consistent with user expectations for similar views of that @@ -35,12 +35,12 @@ assistive technologies of a `role` value change. When `false`, the view is hidden from screenreaders. -**activeOpacity**: number = 1 +**activeOpacity**: number = 0.8 Sets the opacity of the child view when `onPressIn` is called. The opacity is reset when `onPressOut` is called. -(web) **activeUnderlayColor**: string = 'transparent' +(web) **activeUnderlayColor**: string = 'black' Sets the color of the background highlight when `onPressIn` is called. The highlight is removed when `onPressOut` is called. @@ -49,7 +49,7 @@ highlight is removed when `onPressOut` is called. A single child element. -**delayLongPress**: number = 1000 +**delayLongPress**: number = 500 Delay in ms, from `onPressIn`, before `onLongPress` is called. @@ -59,7 +59,7 @@ Delay in ms, from `onPressIn`, before `onLongPress` is called. Delay in ms, from the start of the touch, before `onPressIn` is called. -**delayPressOut**: number = 0 +**delayPressOut**: number = 100 (TODO) diff --git a/src/components/Image/index.js b/src/components/Image/index.js index 110c5a52..d470c1f6 100644 --- a/src/components/Image/index.js +++ b/src/components/Image/index.js @@ -201,10 +201,7 @@ class Image extends React.Component { }} testID={testID} > - + {children ? ( ) : null} diff --git a/src/components/ListView/index.js b/src/components/ListView/index.js index 689ef88a..f61678a5 100644 --- a/src/components/ListView/index.js +++ b/src/components/ListView/index.js @@ -3,11 +3,12 @@ import ScrollView from '../ScrollView' class ListView extends React.Component { static propTypes = { - children: PropTypes.any + children: PropTypes.any, + style: PropTypes.style } static defaultProps = { - className: '' + style: {} } render() { diff --git a/src/components/Text/index.js b/src/components/Text/index.js index 548cc5c5..2fb5d34e 100644 --- a/src/components/Text/index.js +++ b/src/components/Text/index.js @@ -58,7 +58,7 @@ class Text extends React.Component { ...other } = this.props - const className = `Text ${_className}`.trim() + const className = `${_className} Text`.trim() const resolvedStyle = pickProps(style, textStyleKeys) return ( diff --git a/src/components/View/index.js b/src/components/View/index.js index 9cdc3901..38509bcc 100644 --- a/src/components/View/index.js +++ b/src/components/View/index.js @@ -59,7 +59,7 @@ class View extends React.Component { ...other } = this.props - const className = `View ${_className}`.trim() + const className = `${_className} View`.trim() const pointerEventsStyle = pointerEvents && { pointerEvents } const resolvedStyle = pickProps(style, viewStyleKeys)