From 781a4191f0f88abdbc074c56d63acaa5a4e427b6 Mon Sep 17 00:00:00 2001 From: Charlie Croom Date: Tue, 30 Mar 2021 10:30:12 -0400 Subject: [PATCH] [fix] View href 'target' string may start with underscore Close #1969 --- .../react-native-web/src/exports/View/__tests__/index-test.js | 2 +- packages/react-native-web/src/exports/View/index.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-native-web/src/exports/View/__tests__/index-test.js b/packages/react-native-web/src/exports/View/__tests__/index-test.js index 4968702d..787be1f0 100644 --- a/packages/react-native-web/src/exports/View/__tests__/index-test.js +++ b/packages/react-native-web/src/exports/View/__tests__/index-test.js @@ -110,7 +110,7 @@ describe('components/View', () => { const hrefAttrs = { download: 'filename.jpg', rel: 'nofollow', - target: 'blank' + target: '_blank' }; const { container } = render(); expect(container.firstChild).toMatchSnapshot(); diff --git a/packages/react-native-web/src/exports/View/index.js b/packages/react-native-web/src/exports/View/index.js index 790b7e20..d6ede28b 100644 --- a/packages/react-native-web/src/exports/View/index.js +++ b/packages/react-native-web/src/exports/View/index.js @@ -107,8 +107,8 @@ const View = forwardRef((props, forwardedRef) => { if (rel != null) { supportedProps.rel = rel; } - if (typeof target === 'string' && target.charAt(0) !== '_') { - supportedProps.target = '_' + target; + if (typeof target === 'string') { + supportedProps.target = target.charAt(0) !== '_' ? '_' + target : target; } }