From 956b4a3d7446911e3a4c4b67c64d67125f197b93 Mon Sep 17 00:00:00 2001 From: Nicolas Gallagher Date: Thu, 4 Feb 2021 14:33:01 -0800 Subject: [PATCH] [change] Remove automatic addition of 'rel="noopener"' from links Close #1428 --- .../__tests__/__snapshots__/index-test.js.snap | 2 -- .../src/modules/createDOMProps/__tests__/index-test.js | 5 ----- .../react-native-web/src/modules/createDOMProps/index.js | 7 ------- 3 files changed, 14 deletions(-) diff --git a/packages/react-native-web/src/modules/createDOMProps/__tests__/__snapshots__/index-test.js.snap b/packages/react-native-web/src/modules/createDOMProps/__tests__/__snapshots__/index-test.js.snap index 7a6aac89..bf7fe042 100644 --- a/packages/react-native-web/src/modules/createDOMProps/__tests__/__snapshots__/index-test.js.snap +++ b/packages/react-native-web/src/modules/createDOMProps/__tests__/__snapshots__/index-test.js.snap @@ -1,7 +1,5 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`modules/createDOMProps includes "rel" values for "a" elements (to securely open external links) 1`] = `" noopener noreferrer"`; - exports[`modules/createDOMProps includes base reset style for browser-styled elements 1`] = `"css-reset-4rbku5"`; exports[`modules/createDOMProps includes base reset style for browser-styled elements 2`] = `"css-reset-4rbku5"`; diff --git a/packages/react-native-web/src/modules/createDOMProps/__tests__/index-test.js b/packages/react-native-web/src/modules/createDOMProps/__tests__/index-test.js index 559557f0..afd41868 100644 --- a/packages/react-native-web/src/modules/createDOMProps/__tests__/index-test.js +++ b/packages/react-native-web/src/modules/createDOMProps/__tests__/index-test.js @@ -330,11 +330,6 @@ describe('modules/createDOMProps', () => { expect(props['data-testid']).toEqual(testID); }); - test('includes "rel" values for "a" elements (to securely open external links)', () => { - const props = createDOMProps('a', { target: '_blank' }); - expect(props.rel).toMatchSnapshot(); - }); - test('includes cursor style for pressable roles', () => { expect(createDOMProps('span', { accessibilityRole: 'link' }).className).toMatchSnapshot(); expect(createDOMProps('span', { accessibilityRole: 'button' }).className).toMatchSnapshot(); diff --git a/packages/react-native-web/src/modules/createDOMProps/index.js b/packages/react-native-web/src/modules/createDOMProps/index.js index 383e0276..f1af5976 100644 --- a/packages/react-native-web/src/modules/createDOMProps/index.js +++ b/packages/react-native-web/src/modules/createDOMProps/index.js @@ -210,13 +210,6 @@ const createDOMProps = (component, props) => { domProps.id = nativeID; } - // Link security - // https://mathiasbynens.github.io/rel-noopener/ - // Note: using "noreferrer" doesn't impact referrer tracking for https - // transfers (i.e., from https to https). - if (component === 'a' && domProps.target === '_blank') { - domProps.rel = `${domProps.rel || ''} noopener noreferrer`; - } // Automated test IDs if (testID != null) { domProps['data-testid'] = testID;