Update GitHub files

This commit is contained in:
Nicolas Gallagher
2017-07-27 11:38:50 -07:00
parent 20e1febe21
commit 9e58a7b5f1
3 changed files with 23 additions and 46 deletions
+10 -6
View File
@@ -104,13 +104,17 @@ Please open an issue with a proposal for a new feature or refactoring before
starting on the work. We don't want you to waste your efforts on a pull request starting on the work. We don't want you to waste your efforts on a pull request
that we won't want to accept. that we won't want to accept.
## Submitting Changes ## Pull requests
* Open a new issue in the [Issue tracker](https://github.com/necolas/react-native-web/issues). **Before submitting a pull request,** please make sure the following is done:
* Fork the repo.
* Create a new feature branch based off the `master` branch. 1. Fork the repository and create your branch from `master`.
* Make sure all tests pass and there are no linting errors. 2. If you've added code that should be tested, add tests!
* Submit a pull request, referencing any issues it addresses. 3. If you've changed APIs, update the documentation.
4. Ensure the tests pass (`yarn test`).
5. Lint and format your code (`yarn fmt && yarn lint`).
You can now submit a pull request, referencing any issues it addresses.
Please try to keep your pull request focused in scope and avoid including Please try to keep your pull request focused in scope and avoid including
unrelated commits. unrelated commits.
+12 -22
View File
@@ -1,30 +1,20 @@
<!-- **Do you want to request a *feature* or report a *bug*?**
React Native for Web is an implementation of React Native. If you have feature
requests, you should post them to https://productpains.com/product/react-native/.
GitHub issues should only be used for bugs or Web-specific features you believe
React Native requires.
Make sure to add ALL the information needed to understand the bug so that
someone can help. If the info is missing we'll add the 'needs more information'
label and close the issue until there is enough information.
-->
**What is the current behavior?** **What is the current behavior?**
Link to minimal test case: (template: [codepen](https://codepen.io/necolas/pen/PZzwBR?editors=0010)) **If the current behavior is a bug, please provide the steps to reproduce and
if a minimal demo of the problem via Glitch or similar (template:
**What is the expected behaviour?** https://glitch.com/edit/#!/react-native-web-playground).**
**Steps to reproduce**
1. 1.
2. 2.
**Environment (include versions)** **What is the expected behavior?**
OS: **Environment (include versions). Did this work in previous versions?**
Device:
Browser: * OS:
React Native for Web (version): * Device:
React (version): * Browser:
* React Native for Web (version):
* React (version):
+1 -18
View File
@@ -1,18 +1 @@
<!-- **Before submitting a pull request,** please make sure you have followed the steps the CONTRIBUTING guide.
Thanks for submitting a pull request! Make sure the PR does only one thing.
Please provide enough information so that others can review your pull
request. Make sure you have read the Contributing Guidelines -
https://github.com/necolas/react-native-web/CONTRIBUTING.md
-->
**This patch solves the following problem**
**Test plan**
**This pull request**
- [ ] includes documentation
- [ ] includes tests
- [ ] includes benchmark reports
- [ ] includes an interactive example
- [ ] includes screenshots/videos